From: Stanley Chu <stanley.chu@mediatek.com>
To: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Cc: "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"marc.w.gonzalez@free.fr" <marc.w.gonzalez@free.fr>,
"Andy Teng (鄧如宏)" <Andy.Teng@mediatek.com>,
"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>,
"Kuohong Wang (王國鴻)" <kuohong.wang@mediatek.com>,
"evgreen@chromium.org" <evgreen@chromium.org>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Peter Wang (王信友)" <peter.wang@mediatek.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"pedrom.sousa@synopsys.com" <pedrom.sousa@synopsys.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"beanhuo@micron.com" <beanhuo@micron.com>
Subject: Re: [PATCH v2 0/3] scsi: ufs: Add error handling of Auto-Hibernate
Date: Mon, 20 May 2019 09:15:37 +0800 [thread overview]
Message-ID: <1558314937.660.2.camel@mtkswgap22> (raw)
In-Reply-To: <1557912988-26758-1-git-send-email-stanley.chu@mediatek.com>
Hi Avri, Alim, Pedro,
Gentle ping for this patch.
On Wed, 2019-05-15 at 17:36 +0800, Stanley Chu wrote:
> Currently auto-hibernate is activated if host supports
> auto-hibern8 capability. However error-handling is not implemented,
> which makes the feature somewhat risky.
>
> If either "Hibernate Enter" or "Hibernate Exit" fail during
> auto-hibernate flow, the corresponding interrupt
> "UIC_HIBERNATE_ENTER" or "UIC_HIBERNATE_EXIT" shall be raised
> according to UFS specification.
>
> This patch adds auto-hibernate error-handling:
>
> - Monitor "Hibernate Enter" and "Hibernate Exit" interrupts after
> auto-hibernate feature is activated.
>
> - If fail happens, trigger error-handling just like "manual-hibernate"
> fail and apply the same recovery flow: schedule UFS error handler in
> ufshcd_check_errors(), and then do host reset and restore
> in UFS error handler.
>
> v2:
> - Fix sentences in commit message (Marc Gonzalez)
> - Make "Auto-Hibernate" error detection more precise (Bean Huo)
>
> Stanley Chu (3):
> scsi: ufs: Do not overwrite Auto-Hibernate timer
> scsi: ufs: Add error-handling of Auto-Hibernate
> scsi: ufs: Use re-factored Auto-Hibernate function
>
> drivers/scsi/ufs/ufshcd.c | 33 ++++++++++++++++++++++++++++++++-
> drivers/scsi/ufs/ufshcd.h | 5 +++++
> drivers/scsi/ufs/ufshci.h | 3 +++
> 3 files changed, 40 insertions(+), 1 deletion(-)
>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-05-20 1:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 9:36 [PATCH v2 0/3] scsi: ufs: Add error handling of Auto-Hibernate Stanley Chu
2019-05-15 9:36 ` [PATCH v2 1/3] scsi: ufs: Do not overwrite Auto-Hibernate timer Stanley Chu
2019-05-20 5:05 ` Alim Akhtar
2019-05-20 5:47 ` Avri Altman
2019-05-20 5:50 ` Stanley Chu
2019-05-15 9:36 ` [PATCH v2 2/3] scsi: ufs: Add error-handling of Auto-Hibernate Stanley Chu
2019-05-15 10:03 ` [EXT] " Bean Huo (beanhuo)
2019-05-20 5:37 ` Alim Akhtar
2019-05-15 9:36 ` [PATCH v2 3/3] scsi: ufs: Use re-factored Auto-Hibernate function Stanley Chu
2019-05-15 10:05 ` [EXT] " Bean Huo (beanhuo)
2019-05-20 5:41 ` Alim Akhtar
2019-05-20 1:15 ` Stanley Chu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558314937.660.2.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=Andy.Teng@mediatek.com \
--cc=Chun-hung.Wu@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=evgreen@chromium.org \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=pedrom.sousa@synopsys.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox