From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 936C8C04AAF for ; Mon, 20 May 2019 05:51:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A113206B6 for ; Mon, 20 May 2019 05:51:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="URTkanfY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A113206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dv9/xjuqtO6xaPc3uJhJfVYMr2FZtihMla1cIIq1Nfc=; b=URTkanfYt3Gc30 ceYSou6jEUJcbQF/zvUnLWKPZr3cQKcu7+rRCNtG9LLsPuRB2K4vrCHPxsU5LhlPk1GGwnBtibqon o5HJx/rTC/wMKx0uWO36mmCVXvKEn1QZdzrNKJbbfDCJ/bK7NGuQZIuM2eQCTtIAMecMtWzi20yfI T7V1cp47+fslbH+uYlN7olRficH6eY9BfHyydDj1kzJia60PngN8VptIyBFvdlt1x/vwVqgjmdx6+ 5LFVpO8w/miuJ0NmdRCTu9g1iZ0/lI2fzf8KNqiMpwc++EgRPR4R2sxCDTWFbpLaax4115EWh3ZmX vcK1pvSoXm35tNx4BXpg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSbCP-0003Tl-6a; Mon, 20 May 2019 05:51:01 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSbCM-0003Sk-CI; Mon, 20 May 2019 05:50:59 +0000 X-UUID: 3911db8285d646db9ff0a24d2e6793ef-20190519 X-UUID: 3911db8285d646db9ff0a24d2e6793ef-20190519 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1514278621; Sun, 19 May 2019 21:50:54 -0800 Received: from MTKMBS02N2.mediatek.inc (172.21.101.101) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 19 May 2019 22:50:53 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n2.mediatek.inc (172.21.101.101) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 20 May 2019 13:50:44 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 20 May 2019 13:50:44 +0800 Message-ID: <1558331444.660.3.camel@mtkswgap22> Subject: RE: [PATCH v2 1/3] scsi: ufs: Do not overwrite Auto-Hibernate timer From: Stanley Chu To: Avri Altman Date: Mon, 20 May 2019 13:50:44 +0800 In-Reply-To: References: <1557912988-26758-1-git-send-email-stanley.chu@mediatek.com> <1557912988-26758-2-git-send-email-stanley.chu@mediatek.com> <15a271c6-88c8-b9d5-68a8-dc142afdf224@samsung.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: C35318FB76C1B6118FB9D57F33EED020122AB4D17243F9CEC9A0A82013BC28C42000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190519_225058_418828_AC7B8E1E X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , "marc.w.gonzalez@free.fr" , "andy.teng@mediatek.com" , "chun-hung.wu@mediatek.com" , "kuohong.wang@mediatek.com" , "evgreen@chromium.org" , "linux-mediatek@lists.infradead.org" , "peter.wang@mediatek.com" , Alim Akhtar , "matthias.bgg@gmail.com" , "pedrom.sousa@synopsys.com" , "linux-arm-kernel@lists.infradead.org" , "beanhuo@micron.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Avri, On Mon, 2019-05-20 at 05:47 +0000, Avri Altman wrote: > > > > Hello Stanley, > > > > On 5/15/19 3:06 PM, Stanley Chu wrote: > > > Some vendor-specific initialization flow may set its own > > > auto-hibernate timer. In this case, do not overwrite timer value > > > as "default value" in ufshcd_init(). > > > > > > Signed-off-by: Stanley Chu > > > --- > > > drivers/scsi/ufs/ufshcd.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > > > index e040f9dd9ff3..1665820c22fd 100644 > > > --- a/drivers/scsi/ufs/ufshcd.c > > > +++ b/drivers/scsi/ufs/ufshcd.c > > > @@ -8309,7 +8309,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem > > *mmio_base, unsigned int irq) > > > UIC_LINK_HIBERN8_STATE); > > > > > > /* Set the default auto-hiberate idle timer value to 150 ms */ > > > - if (hba->capabilities & MASK_AUTO_HIBERN8_SUPPORT) { > > > + if (hba->capabilities & MASK_AUTO_HIBERN8_SUPPORT & !hba->ahit) { > A typo? Yes! Thanks for remind this. Will fix it in next version. > > > > > hba->ahit = FIELD_PREP(UFSHCI_AHIBERN8_TIMER_MASK, > > 150) | > > > FIELD_PREP(UFSHCI_AHIBERN8_SCALE_MASK, 3); > > > } > > > > > Looks good to me, > > Reviewed-by: Alim Akhtar Thanks. Stanley _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel