From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1014C04AAF for ; Mon, 20 May 2019 07:06:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96F8920815 for ; Mon, 20 May 2019 07:06:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NG5HUhPT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96F8920815 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mzJiK0Vr9u5PSPh0BioRDJdcEdsR65YYaSA/QDS9h98=; b=NG5HUhPTM3bxD+ 95y5CHZiRvJIxxu1pf/IEOWALQNl7xPBWfa4qbyy+JDydEYvS93E0nK++uZzWcYuU0DxfVWL8VjSk Iyqn5oLodIsYEE18MAeFF3tZIhOK03bkk3OKzK8KvTXtKhifJTtDdO/D95LAb+VZWR3qVR/3D6Ft3 QcHiwTwOVNcuGbcb+Rh5uf+ctxoo/lBG/EPaJAPSCIdhDaDfRAXqk+a9JGHUAvhhJ4HdXQAxBEPlI kowELkVZC/2kRum+5khlB/ZNWxkbHc57OyurA2i+hfBr2v9j020b81Ssgr1I4hi1ZSUWlgPhc7viU v6KJeRqoWu6TukRR5X3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hScNe-0002Mm-J1; Mon, 20 May 2019 07:06:42 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hScNa-0002M4-HC; Mon, 20 May 2019 07:06:40 +0000 X-UUID: b6adad78e60e4814b7f30b6c2e5a0b44-20190519 X-UUID: b6adad78e60e4814b7f30b6c2e5a0b44-20190519 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1962944480; Sun, 19 May 2019 23:06:32 -0800 Received: from MTKMBS33DR.mediatek.inc (172.27.6.106) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 20 May 2019 00:06:31 -0700 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS33DR.mediatek.inc (172.27.6.106) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 20 May 2019 15:06:28 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 20 May 2019 15:06:28 +0800 Message-ID: <1558335988.7311.34.camel@mtksdaap41> Subject: Re: [v2 1/5] drm/mediatek: move mipi_dsi_host_register to probe From: CK Hu To: Jitao Shi Date: Mon, 20 May 2019 15:06:28 +0800 In-Reply-To: <1558258588.367.5.camel@mszsdaap41> References: <20190416060501.76276-1-jitao.shi@mediatek.com> <20190416060501.76276-2-jitao.shi@mediatek.com> <1557222735.3498.11.camel@mtksdaap41> <1558258588.367.5.camel@mszsdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190520_000638_575417_A0FEBB48 X-CRM114-Status: GOOD ( 21.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , stonea168@163.com, dri-devel@lists.freedesktop.org, yingjoe.chen@mediatek.com, Ajay Kumar , Vincent Palatin , cawa.cheng@mediatek.com, bibby.hsieh@mediatek.com, Russell King , Thierry Reding , linux-pwm@vger.kernel.org, Sascha Hauer , Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , linux-mediatek@lists.infradead.org, Andy Yan , Matthias Brugger , eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org, Rahul Sharma , srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, Philipp Zabel , Kumar Gala , Sean Paul Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 2019-05-19 at 17:36 +0800, Jitao Shi wrote: > On Tue, 2019-05-07 at 17:52 +0800, CK Hu wrote: > > Hi, Jitao: > > > > On Tue, 2019-04-16 at 14:04 +0800, Jitao Shi wrote: > > > DSI panel driver need attach function which is inculde in > > > mipi_dsi_host_ops. > > > > > > If mipi_dsi_host_register is not in probe, dsi panel will > > > probe fail or more delay. > > > > I think this patch just prevent delay, not to prevent dsi panel probe > > fail. In [1], you mention mipi_dsi_attach() is called in > > panel_simple_dsi_probe(), but panel_simple_dsi_probe() is trigger by > > mipi_dsi_host_register(), so the probe would success. > > > > [1] > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/panel/panel-simple.c?h=v5.0-rc6#n2987 > > > > > > Yes, this just prevent delay. > > > > > > > So move the mipi_dsi_host_register to probe from bind. > > > > > > Signed-off-by: Jitao Shi > > > --- > > > drivers/gpu/drm/mediatek/mtk_dsi.c | 50 ++++++++++++++++++------------ > > > 1 file changed, 30 insertions(+), 20 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > > > index b00eb2d2e086..6c4ac37f983d 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > > > @@ -1045,12 +1045,6 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data) > > > return ret; > > > } > > > > > > - ret = mipi_dsi_host_register(&dsi->host); > > > - if (ret < 0) { > > > - dev_err(dev, "failed to register DSI host: %d\n", ret); > > > - goto err_ddp_comp_unregister; > > > - } > > > - > > > ret = mtk_dsi_create_conn_enc(drm, dsi); > > > if (ret) { > > > DRM_ERROR("Encoder create failed with %d\n", ret); > > > @@ -1060,8 +1054,6 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data) > > > return 0; > > > > > > err_unregister: > > > - mipi_dsi_host_unregister(&dsi->host); > > > -err_ddp_comp_unregister: > > > mtk_ddp_comp_unregister(drm, &dsi->ddp_comp); > > > return ret; > > > } > > > @@ -1097,31 +1089,37 @@ static int mtk_dsi_probe(struct platform_device *pdev) > > > > > > dsi->host.ops = &mtk_dsi_ops; > > > dsi->host.dev = dev; > > > + dsi->dev = dev; > > > > Why do this? > > > > Regards, > > CK > > > > There are some error message require this poweron(). So this should not be in this patch. This patch is related to the timing of mipi_dsi_host_register(). Regards, CK > > > > + ret = mipi_dsi_host_register(&dsi->host); > > > + if (ret < 0) { > > > + dev_err(dev, "failed to register DSI host: %d\n", ret); > > > + return ret; > > > + } > > > > > > ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > > > &dsi->panel, &dsi->bridge); > > > if (ret) > > > - return ret; > > > + goto err_unregister_host; > > > > > > dsi->engine_clk = devm_clk_get(dev, "engine"); > > > if (IS_ERR(dsi->engine_clk)) { > > > ret = PTR_ERR(dsi->engine_clk); > > > dev_err(dev, "Failed to get engine clock: %d\n", ret); > > > - return ret; > > > + goto err_unregister_host; > > > } > > > > > > dsi->digital_clk = devm_clk_get(dev, "digital"); > > > if (IS_ERR(dsi->digital_clk)) { > > > ret = PTR_ERR(dsi->digital_clk); > > > dev_err(dev, "Failed to get digital clock: %d\n", ret); > > > - return ret; > > > + goto err_unregister_host; > > > } > > > > > > dsi->hs_clk = devm_clk_get(dev, "hs"); > > > if (IS_ERR(dsi->hs_clk)) { > > > ret = PTR_ERR(dsi->hs_clk); > > > dev_err(dev, "Failed to get hs clock: %d\n", ret); > > > - return ret; > > > + goto err_unregister_host; > > > } > > > > > > regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel