From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC58C04AB6 for ; Wed, 29 May 2019 02:43:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A45F821019 for ; Wed, 29 May 2019 02:43:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HAWgua6Z"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QwH6V4R2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A45F821019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=6jMXMVpSg/ZtCgKLln7nK8Rkz8EO3QdNy716LDzNH+k=; b=HAW gua6ZEMH5wwG6D8HC6UzSqcIHxafJkgSo95HvhjjNlysqssLatOqO8t7gyyV+DzC5bdFFmH82bpd1 q8M0ZGLfQgB4qE/u/tZMDYvrEAIh7sXes+IOYEizcd3t0FeiQYDMoKDd5/JDFvZjcqm8h9i6toZDK njNfXSoRVwHhX0Eir96TwtUlMTDYHd132/zOiQc/KQbFz/hwiU9pja7Yt5hD32JgoqlP4xRbJbMHs sYXdOcZzF1SklsC9JhE7ga9C6wslgoD0OZ6XKeKvuebcAatkUSAeOSWr+I1XRdWoDIvLUETfXxjDB AlG2lXmEa/+R3Qk2u5rwVsRFmGe4ebQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVoYI-0003ZF-S0; Wed, 29 May 2019 02:42:54 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVoYF-0003Yk-P9 for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2019 02:42:53 +0000 Received: by mail-pl1-x643.google.com with SMTP id w7so382167plz.1 for ; Tue, 28 May 2019 19:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=2pzbdec/1JzOU+htU9qgwmgzRD0iXkmCaTXRbBzNegE=; b=QwH6V4R2xb0vcw3QrTM/J9tendGlR16G/+s3zQPU6a04C3HYdiHIxvYhx1aOcyXWYP ooS7hxyjSUzieuw9Qfp2wTMhLpHRVcu90eZ210CjprwDB9BDLDZ0PAJwQqqV7GrUmeBa YhrwMkhb1oWnkBplloGHwsZUkPIry9Hh84qj+inm1Me+v66pOlcL2kZhxYX97bJRhSJt p5QOVnTMQYQSz2qxoXVvt7APDOtdq/BGiWDtiWSp/wU4MISzFhnrJM5cMWDZjPxq6hD8 xJD/BfW4NNf5GFpYKuIqgMfg3oGTg6MbO5fwKqi9mzQsu2c6b1qLxDEdKyliwWEUmoKk TsOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2pzbdec/1JzOU+htU9qgwmgzRD0iXkmCaTXRbBzNegE=; b=ugNGrAYe+/K2m8jzV9LeqbY4TUSmcTbAA+/lTaq5rnAPaqFJt1MqIBzqi+VgDgOFi8 O6y5LR5g0r3Cn/ZWeFaET8Q9FhjABJLJ78H50Xn1FddrAZgz69Lcj1ILnXWqDAj3E7BC 7U+vRBCBEXae+oIypKZa0+0feOP2E1+zF+4PdwbHR3YBzY85lJcTxFW5elirqLAOtb87 ji0VE76+OBjC+4Rg9n5MBmsA+amOTr+5PdkBiWSN8MktIDpuVz1/HYk713A78dzbWrIZ ZrH6uKOkyLPkInTZWJexDMOWIrRt4g5iBfXQz7lJkI+cL507NdvQEXlzLXuiLvmjwQc9 doqw== X-Gm-Message-State: APjAAAVUZNrNB0Kb0mMHxUZkm8OmyDBzCdYkqbFevSt5ZPjxkl4lx6Oq Vc9Uwf4J4zgxnOtN6am+wLs= X-Google-Smtp-Source: APXvYqzrEGdW0HPJ6+WGHPma3v3/P3aC8F4tBF+UxqKOyrUZNity4s5dMzo8JslXmym7AtpRbpV/4w== X-Received: by 2002:a17:902:8f8f:: with SMTP id z15mr86941174plo.93.1559097770190; Tue, 28 May 2019 19:42:50 -0700 (PDT) Received: from xy-data.openstacklocal (ecs-159-138-22-150.compute.hwclouds-dns.com. [159.138.22.150]) by smtp.gmail.com with ESMTPSA id w4sm15152249pfi.87.2019.05.28.19.42.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 May 2019 19:42:49 -0700 (PDT) From: Young Xiao <92siuyang@gmail.com> To: rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: ns2: Fix potential NULL dereference Date: Wed, 29 May 2019 10:43:58 +0800 Message-Id: <1559097838-26070-1-git-send-email-92siuyang@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_194251_817918_78D556DC X-CRM114-Status: GOOD ( 10.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Young Xiao <92siuyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org platform_get_resource() may fail and return NULL, so we should better check it's return value to avoid a NULL pointer dereference a bit later in the code. Signed-off-by: Young Xiao <92siuyang@gmail.com> --- drivers/pinctrl/bcm/pinctrl-ns2-mux.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c index 4b5cf0e..2bf6af7 100644 --- a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c +++ b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c @@ -1048,6 +1048,8 @@ static int ns2_pinmux_probe(struct platform_device *pdev) return PTR_ERR(pinctrl->base0); res = platform_get_resource(pdev, IORESOURCE_MEM, 1); + if (!res) + return -EINVAL; pinctrl->base1 = devm_ioremap_nocache(&pdev->dev, res->start, resource_size(res)); if (!pinctrl->base1) { -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel