From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0910C07542 for ; Wed, 29 May 2019 08:28:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A33E20665 for ; Wed, 29 May 2019 08:28:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dExNTm6c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A33E20665 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/dsmn2GCsclaKhY+LAnxWhj8jIp6JETJ6sE7LuuBiYc=; b=dExNTm6cExyZj+ X/iP2kOHNSjtTz4jVjs9/drdkqoeF31FbNOmpyMqZojW9XKB3sYTxopOLZ8MAWzSyWO7ImmcaMeWw OXtF0nWC7GLirvEbuMHzrEScxmFsvJcPkW70q/Z3KwpbEktgcB/QxVjkH7YPcUIm/6YsaVOLz3bU5 qY03+S2XwczI9t9WJwS/0NcmOMLDr7vC/9bWm4El2Nbc9452vTOIzdRjzoMUsRkd+Asp1wQq7uRqw mLXMoiwv1HfSOAzHOUD50qX/KQXsceIX7tVT6tqkdFR9FALq6nziqo3ytHiqpSJdPGI3/CO1iFz1V wqX6DXwXUMWCuOQWYMYg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVtwj-00049a-Hk; Wed, 29 May 2019 08:28:29 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVtwf-00047a-8x; Wed, 29 May 2019 08:28:26 +0000 X-UUID: ee308e0e85f849dba1f04509e4e446ee-20190529 X-UUID: ee308e0e85f849dba1f04509e4e446ee-20190529 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1917238427; Wed, 29 May 2019 00:28:23 -0800 Received: from mtkmbs08n2.mediatek.inc (172.21.101.56) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 29 May 2019 01:28:18 -0700 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 29 May 2019 16:28:16 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 29 May 2019 16:28:16 +0800 Message-ID: <1559118496.4226.11.camel@mtksdaap41> Subject: Re: [PATCH 1/3] drm: mediatek: fix unbind functions From: CK Hu To: Hsin-Yi Wang Date: Wed, 29 May 2019 16:28:16 +0800 In-Reply-To: References: <20190527045054.113259-1-hsinyi@chromium.org> <20190527045054.113259-2-hsinyi@chromium.org> <1559093711.11380.6.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: A023916AAC1D56E857E7DE6AAAEAA623764789450FCB15420F9FB9F4341CEE5A2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190529_012825_314555_EDCC4C27 X-CRM114-Status: GOOD ( 12.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Philipp Zabel , David Airlie , lkml , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Hsin-Yi: On Wed, 2019-05-29 at 15:06 +0800, Hsin-Yi Wang wrote: > On Wed, May 29, 2019 at 9:35 AM CK Hu wrote: > > > > > I think mtk_dsi_destroy_conn_enc() has much thing to do and I would like > > you to do more. You could refer to [2] for complete implementation. > > > > [2] > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/exynos/exynos_drm_dsi.c?h=v5.2-rc2#n1575 > > > Hi CK, > > Since drm_encoder_cleanup() would already call drm_bridge_detach() to > detach bridge, I think we only need to handle panel case here. > We don't need to call mtk_dsi_encoder_disable() since > mtk_output_dsi_disable() is called in mtk_dsi_remove() and > dsi->enabled will be set to false. Calling second time will just > returns immediately. > So, besides setting > > dsi->panel = NULL; > dsi->conn.status = connector_status_disconnected; Sorry, I think your original patch is good enough, and you need not to do the besides setting. Regards, CK > > are there other things we need to do here? > > Original code doesn't have drm_kms_helper_hotplug_event(), and I'm not > sure if mtk dsi would need this. > Also, mtk_dsi_stop() would also stop irq. > > Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel