From: CK Hu <ck.hu@mediatek.com>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] drm: mediatek: fix unbind functions
Date: Thu, 30 May 2019 10:13:35 +0800 [thread overview]
Message-ID: <1559182415.6868.0.camel@mtksdaap41> (raw)
In-Reply-To: <20190529102555.251579-2-hsinyi@chromium.org>
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> detatch panel in mtk_dsi_destroy_conn_enc(), since .bind will try to
> attach it again.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Fixes: 2e54c14e310f ("drm/mediatek: Add DSI sub driver")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> change log v1->v2:
> * mipi_dsi_host_unregister() should be fixed in another patch on the list.
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index b00eb2d2e086..1ae3be99e0ff 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -844,6 +844,8 @@ static void mtk_dsi_destroy_conn_enc(struct mtk_dsi *dsi)
> /* Skip connector cleanup if creation was delegated to the bridge */
> if (dsi->conn.dev)
> drm_connector_cleanup(&dsi->conn);
> + if (dsi->panel)
> + drm_panel_detach(dsi->panel);
> }
>
> static void mtk_dsi_ddp_start(struct mtk_ddp_comp *comp)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-30 2:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 10:25 [PATCH v2 0/4] fix mediatek drm, dis, and disp-* unbind/bind Hsin-Yi Wang
2019-05-29 10:25 ` [PATCH v2 1/4] drm: mediatek: fix unbind functions Hsin-Yi Wang
2019-05-30 2:13 ` CK Hu [this message]
2019-05-29 10:25 ` [PATCH v2 2/4] drm: mediatek: unbind components in mtk_drm_unbind() Hsin-Yi Wang
2019-05-30 2:17 ` CK Hu
2019-05-29 10:25 ` [PATCH v2 3/4] drm: mediatek: call drm_atomic_helper_shutdown() when unbinding driver Hsin-Yi Wang
2019-05-30 2:22 ` CK Hu
2019-05-29 10:25 ` [PATCH v2 4/4] drm: mediatek: clear num_pipes when unbind driver Hsin-Yi Wang
2019-05-30 2:28 ` CK Hu
2019-06-04 1:33 ` [PATCH v2 0/4] fix mediatek drm, dis, and disp-* unbind/bind CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559182415.6868.0.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).