From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36A5CC072B1 for ; Thu, 30 May 2019 07:11:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED4E3249CD for ; Thu, 30 May 2019 07:11:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m0ceDjxH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED4E3249CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WkTd8jtLA/bb3Ll4XgFSFtzw2Qr+oxQdVYCP1yhViwQ=; b=m0ceDjxHqdLOJn DszBcxWhw1EYD3ND6hJsFXAtG9IC5rv42R+zBwK5DPct1KwhEiHsstheWfILFQFjbeCGRoEbbj8Hw 92ZMgiSeFpeOhtVhx85GDLrg6cFIKFLvar0OWLcrwQe7sdcluvhRqZHGYQdZWo3nE7IUWnksHkpMQ iVVxUn3xwMx4UurNFFLts+3UPi4RLcPKCmR92MykPghDpNf1BDlvvSpHhc5rVw7uZWCj1ORVuepgm FxGBKfodnAJaRN4sNeg4FT2Sfr5Nr4BS1HQukSMquBteiZ6kii/lE++Mukfp0RAxbICkImoRdHiGU XkvNhi5Wof2D6FIjsy4g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWFD8-0001Q1-Sd; Thu, 30 May 2019 07:10:50 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWFD4-0001P8-Lv; Thu, 30 May 2019 07:10:48 +0000 X-UUID: 2f9ae829a9d540bda714eca8f10a57b3-20190529 X-UUID: 2f9ae829a9d540bda714eca8f10a57b3-20190529 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2022672156; Wed, 29 May 2019 23:10:30 -0800 Received: from MTKMBS01N2.mediatek.inc (172.21.101.79) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 30 May 2019 00:10:29 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 30 May 2019 15:10:26 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 30 May 2019 15:10:26 +0800 Message-ID: <1559200226.23119.4.camel@mtksdaap41> Subject: Re: [PATCH v3] gpu/drm: mediatek: call mtk_dsi_stop() after mtk_drm_crtc_atomic_disable() From: CK Hu To: Hsin-Yi Wang Date: Thu, 30 May 2019 15:10:26 +0800 In-Reply-To: References: <20190528073908.633-1-hsinyi@chromium.org> <1559033586.5141.3.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 21091E5AA1B68CD54EA112FEDEABEE38DDE2401439AE716AE08C1FA05B4F42452000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190530_001047_249796_09A1EF39 X-CRM114-Status: GOOD ( 12.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , David Airlie , lkml , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Hsin-Yi: On Thu, 2019-05-30 at 10:55 +0800, Hsin-Yi Wang wrote: > On Tue, May 28, 2019 at 4:53 PM CK Hu wrote: > > > I think we've already discussed in [1]. I need a reason to understand > > this is hardware behavior or software bug. If this is a software bug, we > > need to fix the bug and code could be symmetric. > > > > [1] > > http://lists.infradead.org/pipermail/linux-mediatek/2019-March/018423.html > > > Hi CK, > > Jitao has replied in v2[1] > " > mtk_dsi_start must after dsi full setting. > If you put it in mtk_dsi_ddp_start, mtk_dsi_set_mode won't work. DSI > will keep cmd mode. So you see no irq. > ... > " > > [1] https://lore.kernel.org/patchwork/patch/1052505/#1276270 > > Thanks OK, this looks the hardware behavior, so I would like you to add comment in the code to describe why we need this asymmetric behavior. The description should be clear so that we could know how to modify the code flow in future. Regards, CK _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel