From: Dave Martin <Dave.Martin@arm.com>
To: kvmarm@lists.cs.columbia.edu
Cc: "Christoffer Dall" <cdall@kernel.org>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Andre Przywara" <andre.przywara@arm.com>,
"Will Deacon" <will.deacon@arm.com>,
"Kristina Martsenko" <kristina.martsenko@arm.com>,
"Zhang Lei" <zhang.lei@jp.fujitsu.com>,
"Amit Daniel Kachhap" <amit.kachhap@arm.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH kvmtool v4 1/8] update_headers.sh: Add missing shell quoting
Date: Fri, 7 Jun 2019 12:26:22 +0100 [thread overview]
Message-ID: <1559906789-20936-2-git-send-email-Dave.Martin@arm.com> (raw)
In-Reply-To: <1559906789-20936-1-git-send-email-Dave.Martin@arm.com>
update_headers.sh can break if the current working directory has a
funny name or if something odd is passed for LINUX_ROOT.
In the interest of cleanliness, quote where appropriate.
Signed-off-by: Dave Martin <Dave.Martin@arm.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
---
| 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--git a/util/update_headers.sh b/util/update_headers.sh
index 2d93646..4ba1b9f 100755
--- a/util/update_headers.sh
+++ b/util/update_headers.sh
@@ -11,17 +11,17 @@ if [ "$#" -ge 1 ]
then
LINUX_ROOT="$1"
else
- LINUX_ROOT=/lib/modules/$(uname -r)/source
+ LINUX_ROOT="/lib/modules/$(uname -r)/source"
fi
-if [ ! -d $LINUX_ROOT/include/uapi/linux ]
+if [ ! -d "$LINUX_ROOT/include/uapi/linux" ]
then
echo "$LINUX_ROOT does not seem to be valid Linux source tree."
echo "usage: $0 [path-to-Linux-source-tree]"
exit 1
fi
-cp $LINUX_ROOT/include/uapi/linux/kvm.h include/linux
+cp -- "$LINUX_ROOT/include/uapi/linux/kvm.h" include/linux
for arch in arm arm64 mips powerpc x86
do
@@ -30,6 +30,6 @@ do
arm64) KVMTOOL_PATH=arm/aarch64 ;;
*) KVMTOOL_PATH=$arch ;;
esac
- cp $LINUX_ROOT/arch/$arch/include/uapi/asm/kvm.h \
- $KVMTOOL_PATH/include/asm
+ cp -- "$LINUX_ROOT/arch/$arch/include/uapi/asm/kvm.h" \
+ "$KVMTOOL_PATH/include/asm"
done
--
2.1.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-07 11:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 11:26 [PATCH kvmtool v4 0/8] arm64: Pointer Authentication and SVE support Dave Martin
2019-06-07 11:26 ` Dave Martin [this message]
2019-06-07 11:26 ` [PATCH kvmtool v4 2/8] update_headers.sh: Cleanly report failure on error Dave Martin
2019-06-07 11:26 ` [PATCH kvmtool v4 3/8] update_headers.sh: arm64: Copy sve_context.h if available Dave Martin
2019-06-07 11:26 ` [PATCH kvmtool v4 4/8] update_headers: Sync kvm UAPI headers with linux v5.2-rc1 Dave Martin
2019-06-07 11:26 ` [PATCH kvmtool v4 5/8] KVM: arm/arm64: Add a vcpu feature for pointer authentication Dave Martin
2019-06-07 11:26 ` [PATCH kvmtool v4 6/8] KVM: arm/arm64: Back out ptrauth command-line arguments Dave Martin
2019-07-18 13:00 ` Andre Przywara
2019-06-07 11:26 ` [PATCH kvmtool v4 7/8] arm/arm64: Factor out ptrauth vcpu feature setup Dave Martin
2019-06-07 11:26 ` [PATCH kvmtool v4 8/8] arm64: Add SVE support Dave Martin
2019-07-03 9:35 ` [PATCH kvmtool v4 0/8] arm64: Pointer Authentication and " Will Deacon
2019-07-03 11:07 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559906789-20936-2-git-send-email-Dave.Martin@arm.com \
--to=dave.martin@arm.com \
--cc=alex.bennee@linaro.org \
--cc=amit.kachhap@arm.com \
--cc=andre.przywara@arm.com \
--cc=cdall@kernel.org \
--cc=kristina.martsenko@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=will.deacon@arm.com \
--cc=zhang.lei@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).