From: CK Hu <ck.hu@mediatek.com>
To: Derek Basehore <dbasehore@chromium.org>
Cc: p.zabel@pengutronix.de, maxime.ripard@bootlin.com,
sam@ravnborg.org, intel-gfx@lists.freedesktop.org,
joonas.lahtinen@linux.intel.com,
maarten.lankhorst@linux.intel.com, linux-kernel@vger.kernel.org,
jani.nikula@linux.intel.com, airlied@linux.ie,
thierry.reding@gmail.com, linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org, daniel@ffwll.ch,
rodrigo.vivi@intel.com, matthias.bgg@gmail.com, sean@poorly.run,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] drm/mtk: add panel orientation property
Date: Tue, 11 Jun 2019 09:42:17 +0800 [thread overview]
Message-ID: <1560217337.15546.1.camel@mtksdaap41> (raw)
In-Reply-To: <20190611002256.186969-6-dbasehore@chromium.org>
Hi, Derek:
On Mon, 2019-06-10 at 17:22 -0700, Derek Basehore wrote:
> This inits the panel orientation property for the mediatek dsi driver
> if the panel orientation (connector.display_info.panel_orientation) is
> not DRM_MODE_PANEL_ORIENTATION_UNKNOWN.
>
Looks good to me,
Acked-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Derek Basehore <dbasehore@chromium.org>
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 4a0b9150a7bb..08ffdc7526dd 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -782,10 +782,18 @@ static int mtk_dsi_create_connector(struct drm_device *drm, struct mtk_dsi *dsi)
> DRM_ERROR("Failed to attach panel to drm\n");
> goto err_connector_cleanup;
> }
> +
> + ret = drm_connector_init_panel_orientation_property(&dsi->conn);
> + if (ret) {
> + DRM_ERROR("Failed to init panel orientation\n");
> + goto err_panel_detach;
> + }
> }
>
> return 0;
>
> +err_panel_detach:
> + drm_panel_detach(dsi->panel);
> err_connector_cleanup:
> drm_connector_cleanup(&dsi->conn);
> return ret;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-11 1:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 0:22 [PATCH 0/5] Panel rotation patches Derek Basehore
2019-06-11 0:22 ` [PATCH 1/5] drm/panel: Add helper for reading DT rotation Derek Basehore
2019-06-11 0:22 ` [PATCH 2/5] dt-bindings: display/panel: Expand rotation documentation Derek Basehore
2019-06-11 0:22 ` [PATCH 3/5] drm/panel: Add attach/detach callbacks Derek Basehore
2019-06-11 0:22 ` [PATCH 4/5] drm/connector: Split out orientation quirk detection Derek Basehore
2019-06-11 0:22 ` [PATCH 5/5] drm/mtk: add panel orientation property Derek Basehore
2019-06-11 1:42 ` CK Hu [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-06-11 4:03 [PATCH v2 0/5] Panel rotation patches Derek Basehore
2019-06-11 4:03 ` [PATCH 5/5] drm/mtk: add panel orientation property Derek Basehore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560217337.15546.1.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dbasehore@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@bootlin.com \
--cc=p.zabel@pengutronix.de \
--cc=rodrigo.vivi@intel.com \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).