From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 0/4] Add i2s nodes on Exynos5420 and enable sound support on sdmk5420
Date: Mon, 12 Aug 2013 13:18:45 +0200 [thread overview]
Message-ID: <1563060.2xzTKrBOxD@amdc1227> (raw)
In-Reply-To: <1376302070-1877-1-git-send-email-padma.v@samsung.com>
Hi Padmavathi,
On Monday 12 of August 2013 15:37:46 Padmavathi Venna wrote:
> Changes since V3:
> - used existent fixed-clock binding for registering oscillator clock
> as fixed rate clock as pointed by Tomasz Figa
> - Made some changes in wm8994 regulator nodes as suggested by Tomasz
> Figa - Separated out only adding i2s nodes and enabling sound support on
> smdk5420 into different patch set as they are dependent on on some of
> already posted but not yet merged i2c, dwmmc, dma and audss clock
> controller patches on Kukjin for-next branch.
>
> Changes since V2:
> - Separated out driver side changes and dts changes in two
> patch sets
> - Added proper names for wm8994 regulators as commented by Mark
> - Moved common i2s nodes into the exynos5.dtsi
> - Added clock info in wm8994 node as requested by Mark.
> - Registered the 16.9MHz oscillator clock as fixed clock in the
> machine file. Right now no user of this clock but as Mark
> requested to add mclk info in wm8994 node, I added this part.
>
> This patch set is dependent on the following i2c, dma and audio subsystem
> clk controller patches.
> http://comments.gmane.org/gmane.linux.kernel.samsung-soc/20077
> http://comments.gmane.org/gmane.linux.kernel.samsung-soc/20661
> http://comments.gmane.org/gmane.linux.kernel.samsung-soc/20668
>
> This patch set is made based on Kukjin Kim for-next branch.
>
>
> Andrew Bresticker (1):
> ARM: dts: exynos5420: add i2s controllers
>
> Padmavathi Venna (3):
> ARM: dts: Add i2c bus 1 and it's audio codec child node on smdk5420
> ARM: dts: Add osc clock node on smdk5420.
> ARM: dts: Enable sound support on smdk5420
>
> arch/arm/boot/dts/exynos5420-smdk5420.dts | 81
> +++++++++++++++++++++++++++++ arch/arm/boot/dts/exynos5420.dtsi
> | 32 +++++++++++
> 2 files changed, 113 insertions(+), 0 deletions(-)
Except the node status misuse that I commented on in patches 1/4 and 4/4,
looks good to me:
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
prev parent reply other threads:[~2013-08-12 11:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 10:07 [PATCH V4 0/4] Add i2s nodes on Exynos5420 and enable sound support on sdmk5420 Padmavathi Venna
2013-08-12 10:07 ` [PATCH V4 1/4] ARM: dts: exynos5420: add i2s controllers Padmavathi Venna
2013-08-12 11:14 ` Tomasz Figa
2013-08-12 11:34 ` Mark Brown
2013-08-12 11:41 ` Tomasz Figa
2013-08-12 13:12 ` Mark Brown
2013-08-12 17:02 ` Tomasz Figa
2013-08-14 5:51 ` Padma Venkat
2013-08-14 8:19 ` Tomasz Figa
2013-08-12 10:07 ` [PATCH V4 2/4] ARM: dts: Add i2c bus 1 and it's audio codec child node on smdk5420 Padmavathi Venna
2013-08-12 10:07 ` [PATCH V4 3/4] ARM: dts: Add osc clock " Padmavathi Venna
2013-08-12 10:07 ` [PATCH V4 4/4] ARM: dts: Enable sound support " Padmavathi Venna
2013-08-12 11:17 ` Tomasz Figa
2013-08-12 11:18 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1563060.2xzTKrBOxD@amdc1227 \
--to=t.figa@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox