From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH/RFC 0/3] Allow OHCI drivers to override hub control operations
Date: Wed, 16 Apr 2014 01:00:36 +0200 [thread overview]
Message-ID: <1563131.ShpASGpY9t@avalon> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1404151402250.1310-100000@iolanthe.rowland.org>
Hi Alan,
On Tuesday 15 April 2014 14:05:14 Alan Stern wrote:
> On Tue, 15 Apr 2014, Laurent Pinchart wrote:
> > > I'm open to the idea of exporting the hub functions. In the end, it
> > > doesn't make all that much difference (it would save a little object
> > > code).
> >
> > I would have agreed to keep the code as it is today if you had thought
> > that exporting the hub functions was a really bad idea, but as you're open
> > to it, and as it removes a bit of code without much of a drawback, I think
> > it makes sense to perform that optimization.
>
> Agreed. We aren't really _encouraging_ people to do this, because it
> still takes some manual work to override the default operation.
>
> > By the way, as a second step, do you think it would make sense to handle
> > the vbus regulators directly in ohci_hub_control() ?
>
> I don't see any good way of doing this generically. Since it is
> currently needed only for PXA27x, we don't know what other
> architectures will require in the future.
Fine with me, let's revisit this later if needed then.
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2014-04-15 23:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 12:25 [PATCH/RFC 0/3] Allow OHCI drivers to override hub control operations Laurent Pinchart
2014-04-14 12:25 ` [PATCH/RFC 1/3] USB: OHCI: Export the ohci_hub_control function Laurent Pinchart
2014-04-14 12:25 ` [PATCH/RFC 2/3] USB: ohci-pxa27x: Add support for external vbus regulators Laurent Pinchart
2014-04-14 12:25 ` [PATCH/RFC 3/3] ARM: pxa: zeus: Replace OHCI init/exit functions with a regulator Laurent Pinchart
2014-04-14 14:35 ` [PATCH/RFC 0/3] Allow OHCI drivers to override hub control operations Alan Stern
2014-04-15 15:32 ` Laurent Pinchart
2014-04-15 18:05 ` Alan Stern
2014-04-15 23:00 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1563131.ShpASGpY9t@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox