From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60066C7618B for ; Wed, 24 Jul 2019 05:04:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3282C218DA for ; Wed, 24 Jul 2019 05:04:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lAgwW7Wm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3282C218DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7d3DujpdY3PQq9q6poc1UU15mOpT6eBLHc7j5ulQas8=; b=lAgwW7Wm9Caja8 /SRzdrSpK9aMktvikX35hmr/XSj6/+AiSjda8hH2UsHGdetLydmOjd1AaGAvTCRcVraUOcOyR3klg U9W7gw0OUZmZcoIBLBvcs27aKAE7VQCyJVaBjyY6Z8LdhkeL7UiZYh29ZkZFfM9Z+QP2zxKvNDmJ6 eeMGEPOGa06i61kD//HXmQHNydiTlCOS3+bRv06rZ4kpmSN014z4PGouF/Iah4TkPxXMpxBLWFMY1 JDEAC9b4e0QG+2jdXeB10zKJFFbkfEgUBHqAv+hGROFeIOJ8WObfoslqpVngQATSS7u4ZR4ShHMXt xEmraJY4Tr822/14z6uA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hq9Rv-00013f-IP; Wed, 24 Jul 2019 05:04:23 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hq9Rq-00012r-TH; Wed, 24 Jul 2019 05:04:21 +0000 X-UUID: 4da8042298db45679233cf6fa7b14acc-20190723 X-UUID: 4da8042298db45679233cf6fa7b14acc-20190723 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1727271314; Tue, 23 Jul 2019 21:04:05 -0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 23 Jul 2019 22:04:03 -0700 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 24 Jul 2019 13:04:02 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 24 Jul 2019 13:04:02 +0800 Message-ID: <1563944642.13531.0.camel@mtkswgap22> Subject: Re: [PATCH v4 2/3] dt-bindings: rng: add bindings for MediaTek ARMv8 SoCs From: Neal Liu To: Rob Herring Date: Wed, 24 Jul 2019 13:04:02 +0800 In-Reply-To: References: <1561361052-13072-1-git-send-email-neal.liu@mediatek.com> <1561361052-13072-3-git-send-email-neal.liu@mediatek.com> <20190722171320.GA9806@bogus> <1563848465.31451.4.camel@mtkswgap22> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190723_220418_951212_8149490B X-CRM114-Status: GOOD ( 27.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , Herbert Xu , wsd_upstream , Sean Wang , "linux-kernel@vger.kernel.org" , Crystal Guo =?UTF-8?Q?=28=E9=83=AD=E6=99=B6=29?= , "linux-crypto@vger.kernel.org" , Matt Mackall , Matthias Brugger , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2019-07-23 at 08:35 -0600, Rob Herring wrote: > On Mon, Jul 22, 2019 at 8:21 PM Neal Liu wrote: > > > > Please don't top post to lists. > > > Dear Rob, > > You can check my driver for detail: > > http://patchwork.kernel.org/patch/11012475/ or patchset 3/3 > > I could, or you could just answer my question. > > > > > This driver is registered as hardware random number generator, and > > combines with rng-core. > > We want to add one rng hw based on the dts. Is this proper or do you > > have other suggestion to meet this requirement? > > It depends. There doesn't appear to be any resource configuration, so > why does it need to be in DT. DT is not the only way instantiate > drivers. > > Rob This hwrng is only supported on some chipsets. It needs DT to identify which platform is supported or not. Is there any better idea to meet this requirement? Neal > > > > Thanks > > > > > > On Tue, 2019-07-23 at 01:13 +0800, Rob Herring wrote: > > > On Mon, Jun 24, 2019 at 03:24:11PM +0800, Neal Liu wrote: > > > > Document the binding used by the MediaTek ARMv8 SoCs random > > > > number generator with TrustZone enabled. > > > > > > > > Signed-off-by: Neal Liu > > > > --- > > > > .../devicetree/bindings/rng/mtk-sec-rng.txt | 10 ++++++++++ > > > > 1 file changed, 10 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/rng/mtk-sec-rng.txt > > > > > > > > diff --git a/Documentation/devicetree/bindings/rng/mtk-sec-rng.txt b/Documentation/devicetree/bindings/rng/mtk-sec-rng.txt > > > > new file mode 100644 > > > > index 0000000..c04ce15 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/rng/mtk-sec-rng.txt > > > > @@ -0,0 +1,10 @@ > > > > +MediaTek random number generator with TrustZone enabled > > > > + > > > > +Required properties: > > > > +- compatible : Should be "mediatek,mtk-sec-rng" > > > > > > What's the interface to access this? > > > > > > A node with a 'compatible' and nothing else is a sign of something that > > > a parent device should instantiate and doesn't need to be in DT. IOW, > > > what do complete bindings for firmware functions look like? > > > > > > > + > > > > +Example: > > > > + > > > > +hwrng: hwrng { > > > > + compatible = "mediatek,mtk-sec-rng"; > > > > +} > > > > -- > > > > 1.7.9.5 > > > > > > > > > > _______________________________________________ > > > Linux-mediatek mailing list > > > Linux-mediatek@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-mediatek > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel