From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA99CC0650F for ; Thu, 8 Aug 2019 06:01:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79C092186A for ; Thu, 8 Aug 2019 06:01:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gJ8Ol7dv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79C092186A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u+2ZriGHagBfB6CdgA+8kWvXIame0hFJMKFdKEVz4IA=; b=gJ8Ol7dvwMBo3m 4id+tysymz/GGRcN15jkYEQVW0jicx2J9/s6CLbpGdlxMk2TXpKZEnwW7VkJTL0cNrx5LElvVzh1s ZVxYBZBf6wOC5GKiBZjQB/02RgvCTptWof3kgnn3nwwBmMQ7p9vtF9fsXDCtG/qlONVsZjSm/Eo+y Zix55D6J8/SnKFgOxlgsvoGtAm8WSJOcVZf6A/klr1GykZ+GsOan2TBuvjVK2kmobINwrbN/XUX/X L/EmCogpwFxW22syalCldb0x/SLaslbMl7bI29zetxSww0UMUhypHBpEIUG++xHqfL7RbpNlcxHBm 8Wm09hue8+LWYai2rmKw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvbUO-00061h-Dl; Thu, 08 Aug 2019 06:01:28 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvbUJ-0005zc-M9; Thu, 08 Aug 2019 06:01:25 +0000 X-UUID: 3441cc41635b4423896bc944bba6aa89-20190807 X-UUID: 3441cc41635b4423896bc944bba6aa89-20190807 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1785554735; Wed, 07 Aug 2019 22:01:18 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 7 Aug 2019 23:01:16 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 8 Aug 2019 14:01:14 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 8 Aug 2019 14:01:15 +0800 Message-ID: <1565244075.26350.3.camel@mtkswgap22> Subject: Re: [PATCH v2] arm64: mm: print hexadecimal EC value in mem_abort_decode() From: Miles Chen To: Anshuman Khandual Date: Thu, 8 Aug 2019 14:01:15 +0800 In-Reply-To: <98bdbcfb-24ed-fcd8-4b2c-f2c78b245dda@arm.com> References: <20190807003336.28040-1-miles.chen@mediatek.com> <98bdbcfb-24ed-fcd8-4b2c-f2c78b245dda@arm.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190807_230123_734613_B030A621 X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , wsd_upstream@mediatek.com, Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, James Morse , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2019-08-08 at 11:19 +0530, Anshuman Khandual wrote: > > On 08/07/2019 06:03 AM, Miles Chen wrote: > > This change prints the hexadecimal EC value in mem_abort_decode(), > > which makes it easier to lookup the corresponding EC in > > the ARM Architecture Reference Manual. > > > > The commit 1f9b8936f36f ("arm64: Decode information from ESR upon mem > > faults") prints useful information when memory abort occurs. It would > > be easier to lookup "0x25" instead of "DABT" in the document. Then we > > can check the corresponding ISS. > > > > For example: > > Current info Document > > EC Exception class > > "CP15 MCR/MRC" 0x3 "MCR or MRC access to CP15a..." > > "ASIMD" 0x7 "Access to SIMD or floating-point..." > > "DABT (current EL)" 0x25 "Data Abort taken without..." > > ... > > > > Before: > > Unable to handle kernel paging request at virtual address 000000000000c000 > > Mem abort info: > > ESR = 0x96000046 > > Exception class = DABT (current EL), IL = 32 bits > > SET = 0, FnV = 0 > > EA = 0, S1PTW = 0 > > Data abort info: > > ISV = 0, ISS = 0x00000046 > > CM = 0, WnR = 1 > > > > After: > > Unable to handle kernel paging request at virtual address 000000000000c000 > > Mem abort info: > > ESR = 0x96000046 > > EC = 0x25: DABT (current EL), IL = 32 bits > > SET = 0, FnV = 0 > > EA = 0, S1PTW = 0 > > Data abort info: > > ISV = 0, ISS = 0x00000046 > > CM = 0, WnR = 1 > > > > Change since v1: > > print "EC" instead of "Exception class" > > print EC in fixwidth > > > > Cc: Mark Rutland > > Cc: Anshuman Khandual > > Cc: James Morse > > Signed-off-by: Miles Chen > > This version implements the suggestion, hence it should have > also contained acked-by tag from Mark from earlier version. > No problem. Sorry for not including the tag. I was not sure if I should add the acked-by tag from Mark in patch v2. > Reviewed-by: Anshuman Khandual If I send patch v3, I should include acked-by tag from Mark and Reviewed-by tag from you, right? Miles _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel