From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
Qii Wang <qii.wang@mediatek.com>,
Alexandru M Stan <amstan@chromium.org>,
Wolfram Sang <wsa@the-dreams.de>, Jun Gao <jun.gao@mediatek.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-i2c@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND] i2c: mediatek: disable zero-length transfers for mt8183
Date: Thu, 22 Aug 2019 16:24:38 +0800 [thread overview]
Message-ID: <1566462278.26641.1.camel@mtksdaap41> (raw)
In-Reply-To: <20190822055737.142384-1-hsinyi@chromium.org>
On Thu, 2019-08-22 at 13:57 +0800, Hsin-Yi Wang wrote:
> When doing i2cdetect quick write mode, we would get transfer
> error ENOMEM, and i2cdetect shows there's no device at the address.
> Quoting from mt8183 datasheet, the number of transfers to be
> transferred in one transaction should be set to bigger than 1,
> so we should forbid zero-length transfer and update functionality.
<...>
> @@ -933,8 +942,8 @@ static int mtk_i2c_probe(struct platform_device *pdev)
> i2c->dev = &pdev->dev;
> i2c->adap.dev.parent = &pdev->dev;
> i2c->adap.owner = THIS_MODULE;
> - i2c->adap.algo = &mtk_i2c_algorithm;
> i2c->adap.quirks = i2c->dev_comp->quirks;
> + i2c->adap.algo = &mtk_i2c_algorithm;
> i2c->adap.timeout = 2 * HZ;
> i2c->adap.retries = 1;
>
Why do you need to change this part?
Joe.C
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-22 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 5:57 [PATCH RESEND] i2c: mediatek: disable zero-length transfers for mt8183 Hsin-Yi Wang
2019-08-22 8:24 ` Yingjoe Chen [this message]
2019-08-22 9:35 ` Hsin-Yi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566462278.26641.1.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=amstan@chromium.org \
--cc=drinkcat@chromium.org \
--cc=hsinyi@chromium.org \
--cc=jun.gao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=qii.wang@mediatek.com \
--cc=tglx@linutronix.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).