From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D807C3A5A3 for ; Fri, 30 Aug 2019 06:22:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5907F21721 for ; Fri, 30 Aug 2019 06:22:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bS1R44zk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5907F21721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M5DoVuarQsYtHkMZpQdXyiRD6IDNZMWSmKXVfiBCGVc=; b=bS1R44zkndEXui vsm2dipF+AxZgpQJuOlqgtsnubCXr7PynhsJ/tDWZUGmovBavhSPnkz/2obFzrYaUJvc/h2huH7EO pxZi/fpFfZuHskz8vEGpgcZc2kV3sbPk3kgU2lxFLgmrzg1Z+e3cDZKOXBPxGE0l0LcT7pM8i1euo B2HOcqkVN1E0gSO8IiPUqPfH9WK8lUqaGGccqeS1CUZOsJLYKxqQv0CyZA+0HrJgW9DYH072Q1Zq5 mexYTvAFK8ElRIqYT6gJ+PMNqxREIBy55cStbdLUyko+UmtZmVqFOBYBPR+Y5H2BZLIuYCNvuPGNk p1EGlFDlBA6kAGPGwRiw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i3aJ1-0007aa-Uw; Fri, 30 Aug 2019 06:22:43 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i3aIw-0007ZN-DP; Fri, 30 Aug 2019 06:22:39 +0000 X-UUID: 812305690ab24653a2b0dc3efc22cbd8-20190829 X-UUID: 812305690ab24653a2b0dc3efc22cbd8-20190829 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2010545636; Thu, 29 Aug 2019 22:22:38 -0800 Received: from MTKMBS32DR.mediatek.inc (172.27.6.104) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 29 Aug 2019 23:22:37 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS32DR.mediatek.inc (172.27.6.104) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 30 Aug 2019 14:22:34 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 30 Aug 2019 14:22:34 +0800 Message-ID: <1567146149.7317.40.camel@mhfsdcap03> Subject: Re: [PATCH 02/11] dt-bindings: phy-mtk-tphy: make the ref clock optional From: Chunfeng Yun To: Rob Herring Date: Fri, 30 Aug 2019 14:22:29 +0800 In-Reply-To: <20190829192550.GA29881@bogus> References: <20190829192550.GA29881@bogus> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 98DB08F7F53AF6863050E9819BDD5FA46007C836A76BD5835C75A269FC4EE4DF2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190829_232238_459041_26FEC175 X-CRM114-Status: GOOD ( 18.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2019-08-29 at 14:25 -0500, Rob Herring wrote: > On Fri, Aug 23, 2019 at 03:00:09PM +0800, Chunfeng Yun wrote: > > Make the ref clock optional, then we no need refer to a fixed-clock > > in DTS anymore when the clock of USB3 PHY comes from oscillator > > directly > > > > Signed-off-by: Chunfeng Yun > > --- > > .../devicetree/bindings/phy/phy-mtk-tphy.txt | 13 +++++++------ > > 1 file changed, 7 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt > > index d5b327f85fa2..1c18bf10b2fe 100644 > > --- a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt > > +++ b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt > > @@ -34,12 +34,6 @@ Optional properties (controller (parent) node): > > > > Required properties (port (child) node): > > - reg : address and length of the register set for the port. > > -- clocks : a list of phandle + clock-specifier pairs, one for each > > - entry in clock-names > > -- clock-names : must contain > > - "ref": 48M reference clock for HighSpeed analog phy; and 26M > > - reference clock for SuperSpeed analog phy, sometimes is > > - 24M, 25M or 27M, depended on platform. > > - #phy-cells : should be 1 (See second example) > > cell after port phandle is phy type from: > > - PHY_TYPE_USB2 > > @@ -48,6 +42,13 @@ Required properties (port (child) node): > > - PHY_TYPE_SATA > > > > Optional properties (PHY_TYPE_USB2 port (child) node): > > +- clocks : a list of phandle + clock-specifier pairs, one for each > > + entry in clock-names > > +- clock-names : may contain > > + "ref": 48M reference clock for HighSpeed anolog phy; and 26M > > + reference clock for SuperSpeed anolog phy, sometimes is > > + 24M, 25M or 27M, depended on platform. > > How do you know the frequency when it is not present? It's always present, but sometimes it's always on by default (e.g. 48Mhz of U2 PHY), or comes from oscillator directly (e.g. 26Mhz of U3 PHY), so not controlled by CCF, of course we can use a fixed-clock in latter case, it's useful to make it optional for these two cases. Thanks > > > + > > - mediatek,eye-src : u32, the value of slew rate calibrate > > - mediatek,eye-vrt : u32, the selection of VRT reference voltage > > - mediatek,eye-term : u32, the selection of HS_TX TERM reference voltage > > -- > > 2.23.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel