From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 470B9C3A5A2 for ; Tue, 10 Sep 2019 07:48:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B9852084D for ; Tue, 10 Sep 2019 07:48:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lIwhD9Ng" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B9852084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=00N6HYH+PDCT5UmdDMh9rd3Y4x+8agylsv5jDS+Ftr0=; b=lIwhD9NgMSB6/S hDmjzwCMNZS+fMa2jpHtMc1leU8Mywju2X2IWVBi0PEOsdz5oLZVD18STVzuyrDo8g/dO7SCcCWfZ +cKs5fbw5l1dJTZotfBLejHvLS3xqPKoYXC2765rg7XZxg5j7v4ErbjyPeav1JoSxUrqRNUmtuGT4 LfofTKctni5RY6+gAD8Ps9oFJoYr25+n13Kqev9fe4NjKleH0S+Qw0sFdMScy3dcWWoWCpsgHf414 3YpJzGrcYiPpfsRDxQ5DZekZl62i4Y4uP4f9n36MtTceOxLVT15wQEZn5/W1wMFP3JzjM0XgZeEmA 4Np+OVqJOlt4yrYmd0yg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i7at1-00017L-CZ; Tue, 10 Sep 2019 07:48:27 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i7asx-00016b-RY for linux-arm-kernel@lists.infradead.org; Tue, 10 Sep 2019 07:48:25 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1i7asq-0002ke-3N; Tue, 10 Sep 2019 09:48:16 +0200 Message-ID: <1568101695.3062.1.camel@pengutronix.de> Subject: Re: [PATCH] reset: uniphier-glue: Add Pro5 USB3 support From: Philipp Zabel To: Kunihiko Hayashi , Rob Herring , Mark Rutland , Masahiro Yamada Date: Tue, 10 Sep 2019 09:48:15 +0200 In-Reply-To: <1568080527-1767-1-git-send-email-hayashi.kunihiko@socionext.com> References: <1568080527-1767-1-git-send-email-hayashi.kunihiko@socionext.com> X-Mailer: Evolution 3.22.6-1+deb9u2 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190910_004823_897033_398190D7 X-CRM114-Status: GOOD ( 16.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Masami Hiramatsu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jassi Brar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Kunihiko, On Tue, 2019-09-10 at 10:55 +0900, Kunihiko Hayashi wrote: > Pro5 SoC has same scheme of USB3 reset as Pro4, so the data for Pro5 is > equivalent to Pro4. > > Signed-off-by: Kunihiko Hayashi If it is exactly the same, you could keep using the same compatible: > --- > Documentation/devicetree/bindings/reset/uniphier-reset.txt | 5 +++-- > drivers/reset/reset-uniphier-glue.c | 4 ++++ > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/reset/uniphier-reset.txt b/Documentation/devicetree/bindings/reset/uniphier-reset.txt > index ea00517..e320a8c 100644 > --- a/Documentation/devicetree/bindings/reset/uniphier-reset.txt > +++ b/Documentation/devicetree/bindings/reset/uniphier-reset.txt > @@ -130,6 +130,7 @@ this layer. These clocks and resets should be described in each property. > Required properties: > - compatible: Should be > "socionext,uniphier-pro4-usb3-reset" - for Pro4 SoC USB3 > + "socionext,uniphier-pro5-usb3-reset" - for Pro5 SoC USB3 + "socionext,uniphier-pro5-usb3-reset", "socionext,uniphier-pro4-usb3-reset" - for Pro5 SoC USB3 [...] > diff --git a/drivers/reset/reset-uniphier-glue.c b/drivers/reset/reset-uniphier-glue.c > index a45923f..2b188b3bb 100644 > --- a/drivers/reset/reset-uniphier-glue.c > +++ b/drivers/reset/reset-uniphier-glue.c > @@ -141,6 +141,10 @@ static const struct of_device_id uniphier_glue_reset_match[] = { > .data = &uniphier_pro4_data, > }, > { > + .compatible = "socionext,uniphier-pro5-usb3-reset", > + .data = &uniphier_pro4_data, > + }, > + { > .compatible = "socionext,uniphier-pxs2-usb3-reset", > .data = &uniphier_pxs2_data, > }, And this change would not be necessary. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel