From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B72D2C3A5A2 for ; Tue, 10 Sep 2019 09:44:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A73C2081B for ; Tue, 10 Sep 2019 09:44:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pxlzSHzj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A73C2081B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=McxCXCeu0Op+/8veaMRnwEoOXIyrOl4uXoM6Rk19WS8=; b=pxlzSHzjvs5WQx iCExo7Xo4g9Q6qTWh9r8EFEXmsxlwquyC05EDK3Snq8OR6EObkK7fUubXw1eLP4YBGBzurT6Ud/sO QXKn5X39Etc8NsfhwYyiQ+8jGgq7d9rVHLKwiE0QO+XJq/6MBVn8yqKrxb56nAAdDfQJnlc3rm2ZE BB7dm+UZZxoC8V0GgHcjH2C2UBm7Fho2MBPAcG7YOUurK5Yc0/o1ggDsnMgVFH9J2kcQRhdhq8El8 /31PJQieAGHzGZKSjAy9AgBUbz7dmlFP7OPn9fNfa98jz9leVcQm8dqwAEzCoSJotx8zPsUi9D79V BlfVXib67ntKavKSxxWg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i7ch3-00018D-T9; Tue, 10 Sep 2019 09:44:13 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i7ch0-00016g-5f; Tue, 10 Sep 2019 09:44:11 +0000 X-UUID: 5cdb99cdf2104538aaf216cc49e2ba73-20190910 X-UUID: 5cdb99cdf2104538aaf216cc49e2ba73-20190910 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2069902611; Tue, 10 Sep 2019 01:44:00 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 10 Sep 2019 02:43:59 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 10 Sep 2019 17:43:58 +0800 Received: from [172.21.84.99] (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 10 Sep 2019 17:43:58 +0800 Message-ID: <1568108638.24886.7.camel@mtksdccf07> Subject: Re: [PATCH v2 1/2] mm/page_ext: support to record the last stack of page From: Walter Wu To: "Kirill A. Shutemov" Date: Tue, 10 Sep 2019 17:43:58 +0800 In-Reply-To: <20190910093103.4cmqk4semlhgpmle@box.shutemov.name> References: <20190909085339.25350-1-walter-zh.wu@mediatek.com> <36b5a8e0-2783-4c0e-4fc7-78ea652ba475@redhat.com> <1568077669.24886.3.camel@mtksdccf07> <20190910093103.4cmqk4semlhgpmle@box.shutemov.name> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190910_024410_221143_E089DE6C X-CRM114-Status: GOOD ( 19.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qian Cai , wsd_upstream@mediatek.com, Arnd Bergmann , David Hildenbrand , Andrey Konovalov , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Michal Hocko , linux-mm@kvack.org, Martin Schwidefsky , Alexander Potapenko , linux-arm-kernel@lists.infradead.org, Matthias Brugger , Andrey Ryabinin , Andrew Morton , Will Deacon , Thomas Gleixner , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2019-09-10 at 12:31 +0300, Kirill A. Shutemov wrote: > On Tue, Sep 10, 2019 at 09:07:49AM +0800, Walter Wu wrote: > > On Mon, 2019-09-09 at 12:57 +0200, David Hildenbrand wrote: > > > On 09.09.19 10:53, Walter Wu wrote: > > > > KASAN will record last stack of page in order to help programmer > > > > to see memory corruption caused by page. > > > > > > > > What is difference between page_owner and our patch? > > > > page_owner records alloc stack of page, but our patch is to record > > > > last stack(it may be alloc or free stack of page). > > > > > > > > Signed-off-by: Walter Wu > > > > --- > > > > mm/page_ext.c | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > > > > > > diff --git a/mm/page_ext.c b/mm/page_ext.c > > > > index 5f5769c7db3b..7ca33dcd9ffa 100644 > > > > --- a/mm/page_ext.c > > > > +++ b/mm/page_ext.c > > > > @@ -65,6 +65,9 @@ static struct page_ext_operations *page_ext_ops[] = { > > > > #if defined(CONFIG_IDLE_PAGE_TRACKING) && !defined(CONFIG_64BIT) > > > > &page_idle_ops, > > > > #endif > > > > +#ifdef CONFIG_KASAN > > > > + &page_stack_ops, > > > > +#endif > > > > }; > > > > > > > > static unsigned long total_usage; > > > > > > > > > > Are you sure this patch compiles? > > > > > This is patchsets, it need another patch2. > > We have verified it by running KASAN UT on Qemu. > > Any patchset must be bisectable: do not break anything in the middle of > patchset. > Thanks your reminder. I should explain complete message at commit log. Our patchsets is below: https://lkml.org/lkml/2019/9/9/104 https://lkml.org/lkml/2019/9/9/123 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel