From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D642C3A5A2 for ; Tue, 10 Sep 2019 12:46:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D63DE21019 for ; Tue, 10 Sep 2019 12:46:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kHbibZ5Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D63DE21019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0Q83sw0ZJhsi/bRx6Rc7j/fcjoTDXTZjR/Rd8SXO9Nw=; b=kHbibZ5ZDPgE1w ZjoDKk9S7NLq9Bs5Y8qtSrdrVWCXAzq6sw8SNDga5B6C6k14qmgw+yhtq6OubXK87WwV3H4wXOx+h 8hjU6a9fY6bmvW5m5ILIA7oJqvEpTwyl1HnLsVPMPWzN+9qUVodHi90UCUnVwt915Bn71E1c9KNnd ESrg1bjUEo0U8oEfumQIUYx1Wvja/e7CP6h61isrfQPEa4WXZYEZKLhGPtKEhM3la+sL9roZbplvy BmTSs58P5KxSHvlr453HQpmu7eJEcqDk7tNfboLcfY1fGt5pB2I618aVZWHPvldsq1NldZcQPu50o Z6H1fNDfRpDyLpndDOCg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i7fWy-00014c-L9; Tue, 10 Sep 2019 12:46:00 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i7fWv-00013L-3l; Tue, 10 Sep 2019 12:45:58 +0000 X-UUID: adbed42bd278419f9e538b2e790d0740-20190910 X-UUID: adbed42bd278419f9e538b2e790d0740-20190910 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1986774780; Tue, 10 Sep 2019 04:45:51 -0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 10 Sep 2019 05:45:49 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 10 Sep 2019 20:45:48 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 10 Sep 2019 20:45:48 +0800 Message-ID: <1568119549.24886.18.camel@mtksdccf07> Subject: Re: [PATCH v2 0/2] mm/kasan: dump alloc/free stack for page allocator From: Walter Wu To: Vlastimil Babka Date: Tue, 10 Sep 2019 20:45:49 +0800 In-Reply-To: <4faedb4d-f16c-1917-9eaa-b0f9c169fa50@suse.cz> References: <20190909082412.24356-1-walter-zh.wu@mediatek.com> <4faedb4d-f16c-1917-9eaa-b0f9c169fa50@suse.cz> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190910_054557_163800_BC967FD1 X-CRM114-Status: GOOD ( 11.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qian Cai , wsd_upstream@mediatek.com, Arnd Bergmann , linux-mm@kvack.org, Andrey Konovalov , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Michal Hocko , Martin Schwidefsky , Alexander Potapenko , linux-arm-kernel@lists.infradead.org, Matthias Brugger , Andrey Ryabinin , Andrew Morton , Will Deacon , Thomas Gleixner , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2019-09-10 at 13:53 +0200, Vlastimil Babka wrote: > On 9/10/19 12:50 PM, Andrey Ryabinin wrote: > > > > > > For slab objects we memorize both alloc and free stacks. You'll never know in advance what information will be usefull > > to fix an issue, so it usually better to provide more information. I don't think we should do anything different for pages. > > Exactly, thanks. > > > Given that we already have the page_owner responsible for providing alloc/free stacks for pages, all that we should in KASAN do is to > > enable the feature by default. Free stack saving should be decoupled from debug_pagealloc into separate option so that it can be enabled > > by KASAN and/or debug_pagealloc. > > Right. Walter, can you do it that way, or should I? > > Thanks, > Vlastimil I will send new patch v3. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel