From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA594C49ED9 for ; Thu, 12 Sep 2019 05:39:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEED020856 for ; Thu, 12 Sep 2019 05:39:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IsBZ3XIE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEED020856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X/6cJZbLt6QtM19lN6kIJbXzOhr/QvSEknpRAT+n6v8=; b=IsBZ3XIEYQm+He zmBEKuaD3qQcDZ6BuJ286dE84NxW4PLuX//sM4XWLLxCjFjG0y77YPrhEoqk4YloP87y37wBjPM50 evR7ipxaxqxdat5GYFNhvbHitFk+LWLjCsxd86qF6ld3f1ll2fBJLConJVxjIAna0laMCNwhxmoEn D+fuU9ZghzePdN6UqnWiQYH77ga+4U6H+AMSEgMkwWTgPkf2IG6ToicBKD5Zp9bQT0xFqdBzGo1Da 0Ycsd4q3KQ1AFYw8PivKnLSSpyx45KWV7hWD8+F2GLl7jwX1DhHI15L3wtVny9lWwVMWpzKb0OjLt HnCmqOwDq/Fue1ocXM2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8HpP-0003lS-JL; Thu, 12 Sep 2019 05:39:35 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8HpL-0003kA-Vv; Thu, 12 Sep 2019 05:39:33 +0000 X-UUID: 36771e0318794a80b637c25702678d7c-20190911 X-UUID: 36771e0318794a80b637c25702678d7c-20190911 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2132904841; Wed, 11 Sep 2019 21:39:28 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Sep 2019 22:39:27 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Sep 2019 13:39:25 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 12 Sep 2019 13:39:25 +0800 Message-ID: <1568266766.16730.15.camel@mtkswgap22> Subject: RE: [PATCH v1 3/3] scsi: ufs-mediatek: enable auto suspend capability From: Stanley Chu To: Avri Altman Date: Thu, 12 Sep 2019 13:39:26 +0800 In-Reply-To: References: <1568194890-24439-1-git-send-email-stanley.chu@mediatek.com> <1568194890-24439-4-git-send-email-stanley.chu@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190911_223932_031419_C6BDEDA9 X-CRM114-Status: GOOD ( 12.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "sthumma@codeaurora.org" , "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "marc.w.gonzalez@free.fr" , "vivek.gautam@codeaurora.org" , "andy.teng@mediatek.com" , "jejb@linux.ibm.com" , "chun-hung.wu@mediatek.com" , "kuohong.wang@mediatek.com" , "evgreen@chromium.org" , "subhashj@codeaurora.org" , "linux-mediatek@lists.infradead.org" , "peter.wang@mediatek.com" , "alim.akhtar@samsung.com" , "matthias.bgg@gmail.com" , "beanhuo@micron.com" , "pedrom.sousa@synopsys.com" , "linux-arm-kernel@lists.infradead.org" , "bvanassche@acm.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Avri, On Wed, 2019-09-11 at 10:58 +0000, Avri Altman wrote: > > > > Enable auto suspend capability in MediaTek UFS driver. > > > > Signed-off-by: Stanley Chu > Reviewed-by: Avri Altman > > > --- > > drivers/scsi/ufs/ufs-mediatek.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > > index 0f6ff33ce52e..b7b177c6194c 100644 > > --- a/drivers/scsi/ufs/ufs-mediatek.c > > +++ b/drivers/scsi/ufs/ufs-mediatek.c > > @@ -117,6 +117,11 @@ static int ufs_mtk_setup_clocks(struct ufs_hba > > *hba, bool on, > > return ret; > > } > > > > +static void ufs_mtk_set_caps(struct ufs_hba *hba) { > > + hba->caps |= UFSHCD_CAP_RPM_AUTOSUSPEND; } > Even a one-liner deserve new line for its closing brackets The wired format is just happening the same as [PATCH v1 2/3] scsi: ufs: override auto suspend tunables for ufs It looks fine in patchwork website: https://patchwork.kernel.org/patch/11140757/ I'll try to fix it in v2. Thanks, Stanley _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel