From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E58FAC5ACAE for ; Thu, 12 Sep 2019 08:33:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B829D208C2 for ; Thu, 12 Sep 2019 08:33:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m0J9d2eP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B829D208C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nJLaevfCICoxfAp0ncV+U4aouEbiThrKZwySngGki1Y=; b=m0J9d2ePgpAu7T unalLV41ehssyj7uAF8gfVAfyeU4eOz7oQ5KHfpkmC3HuLUDpScHCuypp73YLufGdF/YbDMCJaX1L py3u8xLrMbHSQyU9Gsik4SWaKgnTL//hCdXPNdxrfbWnBUtx+IrZyAnyb5kjT+PuCj3vY50cuVcSz j9aAkVPmTaP6cLx1lJyI2rEKhERpzjSf8/+O2ylddcVL8+Cyg1R1JbMvHHRdueZhJqkQHrYAdKgAQ GVFixV3poikJArcs/3VzuAwjwdJ5WPYvT0B8hmDm77+ys4aAseATkDsZRQQmJZLjc6BKwegp0qgjA rusOQRBLgeL4Md5qK7sg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8KXb-00089s-1W; Thu, 12 Sep 2019 08:33:23 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8KXX-00089I-4K; Thu, 12 Sep 2019 08:33:20 +0000 X-UUID: b002d592bacd42aebdda8548d8cc318e-20190912 X-UUID: b002d592bacd42aebdda8548d8cc318e-20190912 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1384775267; Thu, 12 Sep 2019 00:33:14 -0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Sep 2019 01:33:13 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Sep 2019 16:33:11 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 12 Sep 2019 16:33:11 +0800 Message-ID: <1568277192.16730.16.camel@mtkswgap22> Subject: Re: [PATCH v1 1/2] block: bypass blk_set_runtime_active for uninitialized q->dev From: Stanley Chu To: Jens Axboe Date: Thu, 12 Sep 2019 16:33:12 +0800 In-Reply-To: <66fddf12-0dc4-1c73-affd-f8404e87342f@kernel.dk> References: <1568183562-18241-1-git-send-email-stanley.chu@mediatek.com> <1568183562-18241-2-git-send-email-stanley.chu@mediatek.com> <66fddf12-0dc4-1c73-affd-f8404e87342f@kernel.dk> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190912_013319_179999_3F530B76 X-CRM114-Status: UNSURE ( 7.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , Andy Teng =?UTF-8?Q?=28=E9=84=A7=E5=A6=82=E5=AE=8F=29?= , "jejb@linux.ibm.com" , Chun-Hung Wu =?UTF-8?Q?=28=E5=B7=AB=E9=A7=BF=E5=AE=8F=29?= , Kuohong Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=8B=E9=B4=BB=29?= , "linux-block@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , Peter Wang =?UTF-8?Q?=28=E7=8E=8B=E4=BF=A1=E5=8F=8B=29?= , "matthias.bgg@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jens, > > void blk_set_runtime_active(struct request_queue *q) > > { > > + if (!q->dev) > > + return; > > + > > spin_lock_irq(&q->queue_lock); > > q->rpm_status = RPM_ACTIVE; > > pm_runtime_mark_last_busy(q->dev); > > I'd prefer just doing: > > if (q->dev) { > ... > } > > instead. Other than that little complaint, looks good to me. > OK! I will change it in v2. Thanks, Stanley _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel