From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4CA4C49ED7 for ; Mon, 16 Sep 2019 06:30:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63CC82067D for ; Mon, 16 Sep 2019 06:30:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lAGjfqe4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63CC82067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v3mc2jOPxcGi/82clebj66A3CuaWgrkmQCDC2s8kNhE=; b=lAGjfqe4tqstyb EgPTdS9S7DMV7WNlKBI46ORO4NDfh4m98REmhE+ULoQHKfuWdZMaMvPYBUd84n4E0rAwXoCaPetTl zI1OPIF2UfV9lNRFgTLtCM/kgTGCHoq4buJ09nt2Mh08v+bzzaOYIPWMLIjXbWC61cDm3CG3b24OV IsLEuzVOtLnW0Rtdac8RALWlz3PjRV9vKoZsU3bJim7pFf2mFNSux1fnZN9j0vtI5ag2tFep8noF7 0m/b7yS2LyBb1QaWVl1A79e9UuSeBn3e40+6DN4A4CsgET3WvrJhHFhUgZxnRGwJyHuysigQsZtIl IlUNLsLV8YCBtVlqmHNA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9kWV-0000c5-5k; Mon, 16 Sep 2019 06:30:07 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9kWP-0008S8-M1; Mon, 16 Sep 2019 06:30:03 +0000 X-UUID: 68082b7bc9aa4a5e91a2bb204e6d46d4-20190915 X-UUID: 68082b7bc9aa4a5e91a2bb204e6d46d4-20190915 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 415744337; Sun, 15 Sep 2019 22:29:56 -0800 Received: from MTKMBS02N2.mediatek.inc (172.21.101.101) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 15 Sep 2019 23:29:54 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs02n2.mediatek.inc (172.21.101.101) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 16 Sep 2019 14:29:52 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 16 Sep 2019 14:29:52 +0800 Message-ID: <1568615392.16730.17.camel@mtkswgap22> Subject: Re: [PATCH v2 3/3] scsi: ufs-mediatek: enable auto suspend capability From: Stanley Chu To: Bart Van Assche Date: Mon, 16 Sep 2019 14:29:52 +0800 In-Reply-To: <160452c7-c53c-155c-49a9-4365166032a8@acm.org> References: <1568270135-32442-1-git-send-email-stanley.chu@mediatek.com> <1568270135-32442-4-git-send-email-stanley.chu@mediatek.com> <160452c7-c53c-155c-49a9-4365166032a8@acm.org> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: 75057D6A14387FD4D93A3473C52F51AE3FD1B009813949CF92BCA4F9F378EA592000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190915_233001_736854_6BA55BF4 X-CRM114-Status: UNSURE ( 8.11 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sthumma@codeaurora.org, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, marc.w.gonzalez@free.fr, vivek.gautam@codeaurora.org, subhashj@codeaurora.org, jejb@linux.ibm.com, chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com, evgreen@chromium.org, avri.altman@wdc.com, linux-mediatek@lists.infradead.org, peter.wang@mediatek.com, alim.akhtar@samsung.com, andy.teng@mediatek.com, matthias.bgg@gmail.com, pedrom.sousa@synopsys.com, linux-arm-kernel@lists.infradead.org, beanhuo@micron.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bart, > > @@ -147,6 +152,8 @@ static int ufs_mtk_init(struct ufs_hba *hba) > > if (err) > > goto out_variant_clear; > > > > + ufs_mtk_set_caps(hba); > > + > > /* > > * ufshcd_vops_init() is invoked after > > * ufshcd_setup_clock(true) in ufshcd_hba_init() thus > > Please inline the ufs_mtk_set_caps() function. Introducing single line > functions like is done in this patch doesn't improve readability. > OK! Will be fixed in next version. Thanks, Stanley _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel