From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E208DC4360C for ; Tue, 8 Oct 2019 08:18:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 967A6206BB for ; Tue, 8 Oct 2019 08:18:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eqQnqLRe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 967A6206BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZcQPRhiQRtyUEzXaW1Bjtuts37z/8oFQozw/6qbDDRk=; b=eqQnqLReupW4AW UwMsKn00AZx8NujJrpPTyIEoWQz6aTM0vzupKVfPHcImQ87WwjV3bPtcCveK/9uGmRAqXV46a37dR sNjTS+jSUng64QiiCQL6fKvqDLoTud1b/cwWcesSXr0Ogrmbm2VwIj1mk0suDIyPkRKNCbOPAoMVV LT6Zk3vD2REYZ9mM2qS54qya0JT4suApG0E5SkllaR5WZvzQPFbkLOK4LJFFzseGa5nqJpJDSwVE+ JtNV3N7nNiwQvlW3ANTNYyIEpTO9SXcKRcw671sXoJiqeyBZb7oEPP+5EYS1TwXGZqm5VXsOcZrq/ +TZuxsBDLiMqnM9p/Hjw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHkhk-00082w-26; Tue, 08 Oct 2019 08:18:48 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHkhc-00081g-DO; Tue, 08 Oct 2019 08:18:46 +0000 X-UUID: fe2c85b2217f4f4fa1b7216afc6934b0-20191008 X-UUID: fe2c85b2217f4f4fa1b7216afc6934b0-20191008 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 122399423; Tue, 08 Oct 2019 00:18:37 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 8 Oct 2019 01:18:35 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 8 Oct 2019 16:18:33 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 8 Oct 2019 16:18:32 +0800 Message-ID: <1570522712.19130.42.camel@mhfsdcap03> Subject: Re: [PATCH] iommu/mediatek: Move the tlb_sync into tlb_flush From: Yong Wu To: Will Deacon Date: Tue, 8 Oct 2019 16:18:32 +0800 In-Reply-To: <20190930120926.t26ydhgggi2scg3e@willie-the-truck> References: <1569822142-14303-1-git-send-email-yong.wu@mediatek.com> <20190930120926.t26ydhgggi2scg3e@willie-the-truck> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 7D17782CEA9D438245218EEEE6BBEC1C3BB60458E15FE650459FFB65E1DB5FFA2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191008_011844_051287_141CAF4D X-CRM114-Status: GOOD ( 22.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com, Nicolas Boichat , cui.zhang@mediatek.com, srv_heupstream@mediatek.com, Tomasz Figa , Joerg Roedel , Will Deacon , linux-kernel@vger.kernel.org, Evan Green , chao.hao@mediatek.com, iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2019-09-30 at 13:09 +0100, Will Deacon wrote: > On Mon, Sep 30, 2019 at 01:42:22PM +0800, Yong Wu wrote: > > The commit 4d689b619445 ("iommu/io-pgtable-arm-v7s: Convert to IOMMU API > > TLB sync") help move the tlb_sync of unmap from v7s into the iommu > > framework. It helps add a new function "mtk_iommu_iotlb_sync", But it > > lacked the dom->pgtlock, then it will cause the variable > > "tlb_flush_active" may be changed unexpectedly, we could see this warning > > log randomly: > > > > mtk-iommu 10205000.iommu: Partial TLB flush timed out, falling back to > > full flush > > > > To fix this issue, we can add dom->pgtlock in the "mtk_iommu_iotlb_sync". > > And when checking this issue, we find that __arm_v7s_unmap call > > io_pgtable_tlb_add_flush consecutively when it is supersection/largepage, > > this also is potential unsafe for us. There is no tlb flush queue in the > > MediaTek M4U HW. The HW always expect the tlb_flush/tlb_sync one by one. > > If v7s don't always gurarantee the sequence, Thus, In this patch I move > > the tlb_sync into tlb_flush(also rename the function deleting "_nosync"). > > and we don't care if it is leaf, rearrange the callback functions. Also, > > the tlb flush/sync was already finished in v7s, then iotlb_sync and > > iotlb_sync_all is unnecessary. > > > > Besides, there are two minor changes: > > a) Use writel for the register F_MMU_INV_RANGE which is for triggering the > > HW work. We expect all the setting(iova_start/iova_end...) have already > > been finished before F_MMU_INV_RANGE. > > b) Reduce the tlb timeout value from 100000us to 1000us. the original value > > is so long that affect the multimedia performance. > > > > Fixes: 4d689b619445 ("iommu/io-pgtable-arm-v7s: Convert to IOMMU API TLB sync") > > Signed-off-by: Chao Hao > > Signed-off-by: Yong Wu > > --- > > This patch looks break the logic for tlb_flush and tlb_sync. I'm not > > sure if it > > is reasonable. If someone has concern, I could change: > > a) Add dom->pgtlock in the mtk_iommu_iotlb_sync > > b) Add a io_pgtable_tlb_sync in [1]. > > The patch looks ok to me, but please could you split it up so that the > timeout and writel are done separately? Thanks for the quick review, I will separate them. > > Thanks, > > Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel