From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C61F8ECE58C for ; Tue, 15 Oct 2019 05:25:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 898772089C for ; Tue, 15 Oct 2019 05:25:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NQF89xGh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 898772089C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U7gChswGlsKgqH/aMJV8J62yu3o1B+7ZQ5TUp7MQEqw=; b=NQF89xGhEn297T OdUMoMbPjcNS4SJoFLDDx6TQBIUPnsRK1nmA4B2I48wbJFW0wuRHpqyP5R0pcYARem7W0SVEsF0+g d97TVW4RLAPFvefzSSbSkWwQ1LB6WoNEFa3xF9F6klmIJl4QQWf8NVNfZ2jYrgXhiX0+/QVFn1LX7 ILbtqpWr60Ov8V4AAjduO11vmE9dNkdwmPq/P9o3780t+I9FGX4BqfoxONtHK3+S4Lz+5nM3T8Gzy Z+Zo8RpqvfJaiSYBzbgHyWLBHsckgW17qTOvghVqCTqWa9O9qRl8pCO77frJnGfQKVeg5UC0SFXIN qz515lJ8XoABJGeKt7LA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKFKu-00037L-Lk; Tue, 15 Oct 2019 05:25:32 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKFKr-00036m-1P; Tue, 15 Oct 2019 05:25:30 +0000 X-UUID: 197af47228ae4eb895e9b48d404216fd-20191014 X-UUID: 197af47228ae4eb895e9b48d404216fd-20191014 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1329948242; Mon, 14 Oct 2019 21:25:17 -0800 Received: from MTKMBS32DR.mediatek.inc (172.27.6.104) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 14 Oct 2019 22:25:22 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS32DR.mediatek.inc (172.27.6.104) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 15 Oct 2019 13:25:17 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 15 Oct 2019 13:25:16 +0800 Message-ID: <1571117118.19130.81.camel@mhfsdcap03> Subject: Re: [PATCH v3 4/7] iommu/mediatek: Delete the leaf in the tlb flush From: Yong Wu To: Robin Murphy Date: Tue, 15 Oct 2019 13:25:18 +0800 In-Reply-To: <20c74c20-864e-88af-3c58-ad3bb7600bcc@arm.com> References: <1571035101-4213-1-git-send-email-yong.wu@mediatek.com> <1571035101-4213-5-git-send-email-yong.wu@mediatek.com> <20c74c20-864e-88af-3c58-ad3bb7600bcc@arm.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 1320629692F0D088FC9AD967C2A18864D2766ABDB9AA66C650AFFE4EBC49898F2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191014_222529_085439_B74CC2AF X-CRM114-Status: GOOD ( 15.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com, Nicolas Boichat , cui.zhang@mediatek.com, srv_heupstream@mediatek.com, edison.hsieh@mediatek.com, Joerg Roedel , Will Deacon , linux-kernel@vger.kernel.org, Evan Green , chao.hao@mediatek.com, Tomasz Figa , iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2019-10-14 at 15:22 +0100, Robin Murphy wrote: > On 14/10/2019 07:38, Yong Wu wrote: > > In our tlb range flush, we don't care the "leaf". Remove it to simplify > > the code. no functional change. > > Presumably you don't care about the granule either? Yes. I only keep "granule" to satisfy the format of "tlb_flush_walk", then it's no need add a new helper function. > > Robin. > > > Signed-off-by: Yong Wu > > --- > > drivers/iommu/mtk_iommu.c | 16 ++++------------ > > 1 file changed, 4 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > > index 8712afc..19f936c 100644 > > --- a/drivers/iommu/mtk_iommu.c > > +++ b/drivers/iommu/mtk_iommu.c > > @@ -174,8 +174,7 @@ static void mtk_iommu_tlb_flush_all(void *cookie) > > } > > > > static void mtk_iommu_tlb_add_flush_nosync(unsigned long iova, size_t size, > > - size_t granule, bool leaf, > > - void *cookie) > > + size_t granule, void *cookie) > > { > > struct mtk_iommu_data *data = cookie; > > > > @@ -219,14 +218,7 @@ static void mtk_iommu_tlb_sync(void *cookie) > > static void mtk_iommu_tlb_flush_walk(unsigned long iova, size_t size, > > size_t granule, void *cookie) > > { > > - mtk_iommu_tlb_add_flush_nosync(iova, size, granule, false, cookie); > > - mtk_iommu_tlb_sync(cookie); > > -} > > - > > -static void mtk_iommu_tlb_flush_leaf(unsigned long iova, size_t size, > > - size_t granule, void *cookie) > > -{ > > - mtk_iommu_tlb_add_flush_nosync(iova, size, granule, true, cookie); > > + mtk_iommu_tlb_add_flush_nosync(iova, size, granule, cookie); > > mtk_iommu_tlb_sync(cookie); > > } > > > > @@ -245,7 +237,7 @@ static void mtk_iommu_tlb_flush_page_nosync(struct iommu_iotlb_gather *gather, > > static const struct iommu_flush_ops mtk_iommu_flush_ops = { > > .tlb_flush_all = mtk_iommu_tlb_flush_all, > > .tlb_flush_walk = mtk_iommu_tlb_flush_walk, > > - .tlb_flush_leaf = mtk_iommu_tlb_flush_leaf, > > + .tlb_flush_leaf = mtk_iommu_tlb_flush_walk, > > .tlb_add_page = mtk_iommu_tlb_flush_page_nosync, > > }; > > > > @@ -475,7 +467,7 @@ static void mtk_iommu_iotlb_sync(struct iommu_domain *domain, > > spin_lock_irqsave(&dom->pgtlock, flags); > > > > mtk_iommu_tlb_add_flush_nosync(gather->start, length, gather->pgsize, > > - false, data); > > + data); > > mtk_iommu_tlb_sync(data); > > > > if (!is_in_gather) > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel