From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CBB3C19776 for ; Wed, 26 Feb 2025 20:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:CC:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=soQ5BkZDufwYMdgMJdG7Zd6+UrF3nw3Qs6ixs6vY/CM=; b=F9eIicXoBSe3xxgU08UItB/h0J FyxNO60/a7wvcJlLTs4+WmXjZp35bq6WsMsPVSHGF34qMWRbEEb+AR3J1psFHMTgwm9CY147qdoVD MeG4C6l3susJAbktNU1luTYieF6hh2o9pC0/hjUjzw+EJWKeFH5+OKijxON/y8Tsu1QdqMwG23Yv+ lfR0fE2/HLj7wJo6tar22jCiOuj3x4O/ervPytJBZ5nJi0kuwTyXmRwvy20hzcx9PoPBVKv7cCKhx nb3/dkYdCIre0aMTlx/vn70SbfrE9XisGn5ho1WMuVlc+Il5GJtIqB7+uIkpxAEVvyewGjJxD/p1Y p3NM+KeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnOJK-00000005Nkj-0gD6; Wed, 26 Feb 2025 20:47:18 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tnOGx-00000005NUH-3gNa for linux-arm-kernel@lists.infradead.org; Wed, 26 Feb 2025 20:44:53 +0000 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51QG2v7O015427; Wed, 26 Feb 2025 21:43:40 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= soQ5BkZDufwYMdgMJdG7Zd6+UrF3nw3Qs6ixs6vY/CM=; b=6jTbVLkocKgNzD6j Y/2AYcivvlHsnAgchC1i19FlTLWjy2/Dl/Dyx+v5WaESHovbd3tpxosNSRjjv6FC zbcDphxZ+h0rc5bJoAAXPFgjoA9PpK7823zFRc/4/jKZ9nknFWX8rEYmmdHexX/7 bmUN9BmFoVtFIpAAPMKmY0q+CVneVa7zsksQfphYbUf/KppXC0YQ2hx/My1Buby6 HPsOOmfkMvhpAPGEBhyju4qcL1aPWoROj07o6guNinEP2MPtp8dB+8MbWuZTMXWQ KDVrdwQ4+xgiyWoNCccx7fxkUXKKMe7HeCev2w/MBb2eNy3JeGzOHxBJuuO+COPN sppSaw== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 451psuekdg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Feb 2025 21:43:39 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 04D6E4008B; Wed, 26 Feb 2025 21:42:20 +0100 (CET) Received: by euls16034.sgp.st.com (STMicroelectronics, from userid 89) id 744C145206A; Wed, 26 Feb 2025 19:14:03 +0100 (CET) Received: from Webmail-eu.st.com (eqndag1node5.st.com [10.75.129.134]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id E4EC05332BB; Wed, 26 Feb 2025 19:14:03 +0100 (CET) Received: from SAFDAG1NODE1.st.com (10.75.90.17) by EQNDAG1NODE5.st.com (10.75.129.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 26 Feb 2025 19:14:03 +0100 Received: from [10.48.86.222] (10.48.86.222) by SAFDAG1NODE1.st.com (10.75.90.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 26 Feb 2025 19:14:02 +0100 Message-ID: <157348a3-9b22-4196-b4b1-ee8fcc46a84d@foss.st.com> Date: Wed, 26 Feb 2025 19:14:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] clocksource: stm32-lptimer: add stm32mp25 support From: Fabrice Gasnier To: Krzysztof Kozlowski CC: , , , , , , , , , , , , , , , , , , References: <20250224180150.3689638-1-fabrice.gasnier@foss.st.com> <20250224180150.3689638-5-fabrice.gasnier@foss.st.com> <20250225-purring-herring-of-reputation-1aed2f@krzk-bin> <2df7bdd9-5072-4a9a-b142-1e1e3f20130c@foss.st.com> Content-Language: en-US In-Reply-To: <2df7bdd9-5072-4a9a-b142-1e1e3f20130c@foss.st.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.48.86.222] X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SAFDAG1NODE1.st.com (10.75.90.17) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-26_06,2025-02-26_01,2024-11-22_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250226_124452_209589_CA84C1FA X-CRM114-Status: GOOD ( 18.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/25/25 15:57, Fabrice Gasnier wrote: > On 2/25/25 13:02, Krzysztof Kozlowski wrote: >> On Mon, Feb 24, 2025 at 07:01:46PM +0100, Fabrice Gasnier wrote: >>> From: Patrick Delaunay >>> >>> Add the support of the new compatible for STM32MP25 SoC in driver, as >>> described in Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml >>> and used in arch/arm64/boot/dts/st/stm32mp251.dtsi. >>> >>> Signed-off-by: Patrick Delaunay >>> Signed-off-by: Fabrice Gasnier >>> --- >>> drivers/clocksource/timer-stm32-lp.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/clocksource/timer-stm32-lp.c b/drivers/clocksource/timer-stm32-lp.c >>> index a4c95161cb22..db055348e2cc 100644 >>> --- a/drivers/clocksource/timer-stm32-lp.c >>> +++ b/drivers/clocksource/timer-stm32-lp.c >>> @@ -197,6 +197,7 @@ static int stm32_clkevent_lp_probe(struct platform_device *pdev) >>> >>> static const struct of_device_id stm32_clkevent_lp_of_match[] = { >>> { .compatible = "st,stm32-lptimer-timer", }, >>> + { .compatible = "st,stm32mp25-lptimer-timer", }, >>> {}, >> >> Same question. > > Oops, I just figured out I have missed a change to this driver, to > enable interrupts, in order to comply with the LPTimer spec, starting > with STM32MP25. > > E.g. with earlier STM32MP13, STM32MP15 or even STM32H7: > * The LPTIM_IER register must only be modified when the LPTIM is > disabled (ENABLE bit reset to ‘0’) > > On STM32MP25: > * The LPTIMx_DIER register must only be modified when the LPTIM is > enabled (ENABLE bit set to 1) > > I'll add this as compatible data in next revision. This is specific behavior, to the new revision of the LPTimer hardware. It can be read from revision/identification registers. So this new compatible can be dropped. I'll remove "st,stm32mp25-lptimer-timer" compatible string in next revision. Thanks for reviewing, BR, Fabrice > > Best regards, > Fabrice > >> >> Best regards, >> Krzysztof >>