From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2400AC432C0 for ; Tue, 19 Nov 2019 07:57:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E824222311 for ; Tue, 19 Nov 2019 07:57:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XXUGLYm2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="PDT3vL3E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E824222311 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DnWQH+gAqLPxb0uX9W2+IeqISWwGDfUo1Q+6/ShZn4U=; b=XXUGLYm2UsAjIp BiwvK3OQ7MvhZOR5Hakb5P5a86JnAkq/AjNMh90IgRZwNE+LRvz5eUwFn0K/0g4UaXPtEa/x0lbc8 I7DVHhfjF7baQIP8eICB0BC02CpnzNmRNZUK7cxDKnhfipil0GNxkUogSOkGD0ZO/m0Zy80CBp2mW kO0/EK8lhAT9XziUb4cX3f28U6LYarLmyayAXW5QOKnEmJzqR6ODTs2M+DcfCFS0YcPdIIBCZVqft ow697m6RvIJZ8fPSJUpytULlxmdAB0kFtGHrhPe9lgCgUad2kIO9ybATRFmVb4MQEsxhwAr0zCCOo uKQqUCW0emTQSnF1kvqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWyOE-0007kX-EZ; Tue, 19 Nov 2019 07:57:34 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWyO8-0007j0-8b; Tue, 19 Nov 2019 07:57:32 +0000 X-UUID: c053ea45551e44dc9614489e57079924-20191118 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=yBnu1NtPajEa00aUiIIxVlbDQ8eChoLCV7rmSdXtLH4=; b=PDT3vL3EhKmVaDjFzp+2dEvjD54PpDO7kDG3B9MDJev5ur3npY9ZwcSTCtnxiKFKMA5UthNLEWgWtbILacQXvBHVftLSuitUIsefXCobp5KDTiYwhm57SkTqZC7od2q/tcEes1DyMM+U+lvbds7ABaRHhV9cSd7xRYzWqk+YlSs=; X-UUID: c053ea45551e44dc9614489e57079924-20191118 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1796284694; Mon, 18 Nov 2019 23:57:23 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 18 Nov 2019 23:57:37 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkcas07.mediatek.inc (172.21.101.84) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 19 Nov 2019 15:57:08 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 19 Nov 2019 15:57:08 +0800 Message-ID: <1574150240.19262.7.camel@mtksdccf07> Subject: Re: [RESEND, PATCH 1/1] arm: dts: mediatek: add mt7629 pwm support From: Sam Shih To: Matthias Brugger Date: Tue, 19 Nov 2019 15:57:20 +0800 In-Reply-To: <31fddc2b-65c7-02e8-dca2-b5d6dc050f87@gmail.com> References: <1571751001-28588-1-git-send-email-sam.shih@mediatek.com> <1571751001-28588-2-git-send-email-sam.shih@mediatek.com> <31fddc2b-65c7-02e8-dca2-b5d6dc050f87@gmail.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191118_235728_311100_FD4F90D0 X-CRM114-Status: GOOD ( 14.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 2019-11-10 at 21:51 +0100, Matthias Brugger wrote: > > On 22/10/2019 15:30, Sam Shih wrote: > > This adds pwm support for MT7629. > > Used: > > https://patchwork.kernel.org/patch/11160851/ > > > > Signed-off-by: Sam Shih > > --- > > arch/arm/boot/dts/mt7629.dtsi | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi > > index 9608bc2ccb3f..24375fc5f936 100644 > > --- a/arch/arm/boot/dts/mt7629.dtsi > > +++ b/arch/arm/boot/dts/mt7629.dtsi > > @@ -241,6 +241,21 @@ > > status = "disabled"; > > }; > > > > + pwm: pwm@11006000 { > > + compatible = "mediatek,mt7629-pwm"; > > + reg = <0x11006000 0x1000>; > > + interrupts = ; > > + clocks = <&topckgen CLK_TOP_PWM_SEL>, > > + <&pericfg CLK_PERI_PWM_PD>, > > + <&pericfg CLK_PERI_PWM1_PD>; > > + clock-names = "top", "main", "pwm1"; > > + assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>; > > + assigned-clock-parents = > > + <&topckgen CLK_TOP_UNIVPLL2_D4>; > > + num-pwms = <1>; > > num-pwms is not defined. Did you mean pwm-cells? > > Regards, > Matthias > > > + status = "disabled"; > > + }; > > + > > i2c: i2c@11007000 { > > compatible = "mediatek,mt7629-i2c", > > "mediatek,mt2712-i2c"; > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek Sorry for the Late Reply, The num-pwms field is redundant after we derive it from the compatible string. I forgot to remove it from the device tree. I will send a new version. Thanks, Best Regards, Sam Shih _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel