From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94019C432C0 for ; Fri, 22 Nov 2019 08:16:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57D802070A for ; Fri, 22 Nov 2019 08:16:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YVLlF+U2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="lpZUXKuD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57D802070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o3CjnV5xtkUBxoAYxPmTXe+2E2mJpKD5EqT+GZXAP4c=; b=YVLlF+U2wrJjqM EdtLwWpJILJPO84uZAPNeyhh7LhUYvU+5WU0yDhFCZ/NJ3a9LuduYe8Px/DZuDzBjecnhOTrG+bih WCXaCiXREdHChg6UKS6HqKwWg1kqCUNDju1aFEY0XtS+Sqxi69nvCbqb4JSLQYqRiZ21IPMzNFiPI HdJ7J9AHitecaO/joNb+aAMJBc5auSswVxM/CW62aEbj+Fy2Tc1ftTxxqL32Oyxlpu5sqMwjktBe1 HLjEQ65QwBRv3oqDhLywbxck3s+kQ8/NwiWmmkyPKpElgBgzGxOWs96z5ZWvlO/42zP7CwpdUKNYu 5anHfBw+1r5GKJKfXV0Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY46o-0000BQ-SL; Fri, 22 Nov 2019 08:16:06 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY46l-0000Av-Vn; Fri, 22 Nov 2019 08:16:05 +0000 X-UUID: 9b2bc4a688d046fca68a704e1b7cce0f-20191122 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=K2QceGAFr4kSuhEVcqRkxVbwPBJiY5InoLtmLU20XiU=; b=lpZUXKuDJAQewYko3iuJb+KSPvHi3BagShZhozXm62IM7qCD1TC0FVAyl6PJ0pdAw41ivgQky4F0iZIMByWd7SLXwXby6vm/FzDR5iQerHG/a4+4/Y8bjT70KX3cW8wamaUvCvVt2tONm1krCvbI/41Ozv4PlvwropZTuqsAf70=; X-UUID: 9b2bc4a688d046fca68a704e1b7cce0f-20191122 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 725854769; Fri, 22 Nov 2019 00:15:58 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 00:06:21 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 16:05:51 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 22 Nov 2019 16:06:21 +0800 Message-ID: <1574409958.19450.1.camel@mtksdaap41> Subject: Re: [PATCH v17 1/6] soc: mediatek: cmdq: fixup wrong input order of write api From: CK Hu To: Bibby Hsieh Date: Fri, 22 Nov 2019 16:05:58 +0800 In-Reply-To: <20191121015410.18852-2-bibby.hsieh@mediatek.com> References: <20191121015410.18852-1-bibby.hsieh@mediatek.com> <20191121015410.18852-2-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191122_001604_030324_C8DF1BB3 X-CRM114-Status: GOOD ( 10.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, Dennis-YC Hsieh , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Thu, 2019-11-21 at 09:54 +0800, Bibby Hsieh wrote: > Fixup a issue was caused by the previous fixup patch. > Reviewed-by: CK Hu > Fixes: 1a92f989126e ("soc: mediatek: cmdq: reorder the parameter") > > Signed-off-by: Bibby Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 7aa0517ff2f3..3c82de5f9417 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -155,7 +155,7 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys, > err = cmdq_pkt_append_command(pkt, CMDQ_CODE_MASK, 0, ~mask); > offset_mask |= CMDQ_WRITE_ENABLE_MASK; > } > - err |= cmdq_pkt_write(pkt, value, subsys, offset_mask); > + err |= cmdq_pkt_write(pkt, subsys, offset_mask, value); > > return err; > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel