From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14ABEC43215 for ; Fri, 22 Nov 2019 09:47:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEF8D20708 for ; Fri, 22 Nov 2019 09:47:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="og2dPFO7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="QUPYlak4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEF8D20708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YINu11qCx+fsgD3ULygabQvs1fLIrk9tCj7BJWQJEY0=; b=og2dPFO7PhGkzj DT4eAzHaBjEu49c++sW5JXf/sYTYIrFuYEs51EviP6nAcwhd3m/P96j5gjnajG0qhmhd8l+1IGKTP T0odqgZsT3LcVs/zlz3DQID3no7sqiaUd7Ji0nsxXsx7Uo0T1whD0l8NLb3twIN+urgess00/f2J+ iOn+dJMZzBo5DREeW2YIuqEQvm/cX/mSK+Y9jFJZcs2YdbOdATlerUNGNfLXcfWVru5cdQ4amIiMm bRwRCcwLqpMgGfIm7jz/Fjt6OttDxxgEzbtBhVsRgTLFOBcSa/zaSBhiyrcXn2D9Tu3/p3Gn/5Ebl Utnn8wIWfTdlGIPDgUGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY5Xg-0002nG-3O; Fri, 22 Nov 2019 09:47:56 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY5Vv-0001Eq-EH; Fri, 22 Nov 2019 09:46:09 +0000 X-UUID: f7030093493d4b19b8339ff967afe1ce-20191122 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=2ejSPwYplNKFDxLWJEW8hsrMYzKNBiloV5tEi9RI1Ag=; b=QUPYlak4FGynWG7yjOJa/3hANi8HiwO8bQdZa7VDoXtygZWieT4qbxvzcSl4CV+L6sIuiFoSs7qnE0aWQeWTSIzfei1VCY6Bna+SqXBfE6BC0W5MfTRec76oYphJkrzHfybHXtWoGKor9QqA54EIG8G8efh79h+q/HbTxUTLpkY=; X-UUID: f7030093493d4b19b8339ff967afe1ce-20191122 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1607348181; Fri, 22 Nov 2019 01:46:02 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 01:46:22 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 17:45:53 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 22 Nov 2019 17:45:51 +0800 Message-ID: <1574415960.19450.23.camel@mtksdaap41> Subject: Re: [PATCH v1 10/12] soc: mediatek: cmdq: add loop function From: CK Hu To: Dennis YC Hsieh Date: Fri, 22 Nov 2019 17:46:00 +0800 In-Reply-To: <1574327552-11806-11-git-send-email-dennis-yc.hsieh@mediatek.com> References: <1574327552-11806-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574327552-11806-11-git-send-email-dennis-yc.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191122_014607_693246_82949385 X-CRM114-Status: GOOD ( 15.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Dennis: On Thu, 2019-11-21 at 17:12 +0800, Dennis YC Hsieh wrote: > Add finalize loop function in cmdq helper functions which loop whole pkt > in gce hardware thread without cpu operation. > > Signed-off-by: Dennis YC Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 41 ++++++++++++++++++++++++++++++++ > include/linux/soc/mediatek/mtk-cmdq.h | 8 +++++++ > 2 files changed, 49 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 4235cf8..3b10241 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -385,12 +385,27 @@ int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value) > } > EXPORT_SYMBOL(cmdq_pkt_assign); > > +static bool cmdq_pkt_finalized(struct cmdq_pkt *pkt) > +{ > + struct cmdq_instruction *inst; > + > + if (pkt->cmd_buf_size < 2 * CMDQ_INST_SIZE) > + return false; > + > + inst = pkt->va_base + pkt->cmd_buf_size - 2 * CMDQ_INST_SIZE; > + return inst->op == CMDQ_CODE_EOC; > +} > + > static int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > { > struct cmdq_client *cl = pkt->cl; > struct cmdq_instruction inst = { {0} }; > int err; > > + /* do not finalize twice */ > + if (cmdq_pkt_finalized(pkt)) > + return 0; > + > /* insert EOC and generate IRQ for each command iteration */ > inst.op = CMDQ_CODE_EOC; > inst.value = CMDQ_EOC_IRQ_EN; > @@ -406,6 +421,32 @@ static int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > return err; > } > > +int cmdq_pkt_finalize_loop(struct cmdq_pkt *pkt) > +{ > + struct cmdq_client *cl = pkt->cl; > + struct cmdq_instruction inst = { {0} }; > + int err; > + > + /* do not finalize twice */ > + if (cmdq_pkt_finalized(pkt)) > + return 0; Why not just export cmdq_pkt_finalize() for user and do not call cmdq_pkt_finalize() in cmdq_pkt_flush_async(), so you don't need to check this. I would be more like to export API such as cmdq_pkt_eoc(), cmdq_pkt_jump(), this would provide more flexibility for user to assemble the command it want. Regards, CK > + > + /* insert EOC and generate IRQ for each command iteration */ > + inst.op = CMDQ_CODE_EOC; > + err = cmdq_pkt_append_command(pkt, inst); > + if (err < 0) > + return err; > + > + /* JUMP abaolute to begin */ > + inst.op = CMDQ_CODE_JUMP; > + inst.offset = 1; > + inst.value = pkt->pa_base >> cmdq_mbox_shift(cl->chan); > + err = cmdq_pkt_append_command(pkt, inst); > + > + return err; > +} > +EXPORT_SYMBOL(cmdq_pkt_finalize_loop); > + > static void cmdq_pkt_flush_async_cb(struct cmdq_cb_data data) > { > struct cmdq_pkt *pkt = (struct cmdq_pkt *)data.data; > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > index b3474f2..77e8944 100644 > --- a/include/linux/soc/mediatek/mtk-cmdq.h > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > @@ -203,6 +203,14 @@ int cmdq_pkt_poll_mask(struct cmdq_pkt *pkt, u8 subsys, > int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value); > > /** > + * cmdq_pkt_finalize_loop() - Append EOC and jump command to loop pkt. > + * @pkt: the CMDQ packet > + * > + * Return: 0 for success; else the error code is returned > + */ > +int cmdq_pkt_finalize_loop(struct cmdq_pkt *pkt); > + > +/** > * cmdq_pkt_flush_async() - trigger CMDQ to asynchronously execute the CMDQ > * packet and call back at the end of done packet > * @pkt: the CMDQ packet _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel