From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41507C432C0 for ; Mon, 25 Nov 2019 07:51:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E18820748 for ; Mon, 25 Nov 2019 07:51:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E09QC7GW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="CTn4oY6M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E18820748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kV6kIBSgAHYHm/OfpxB8x07ygFvkOeq1/8ETXJkB5lE=; b=E09QC7GWVWHoVl 0S40isUkiO4//LdrC7tXFwRCYt//bRhyDxSQpiMAyHyKG7rJZ5AmknaUi1VPfHD2nqijYXTi/Qma1 WTQlP+va+SmLvtOBIioIOubTFXgdqMZLGXWI7MhrCLjfiAMq56e9u3/hhIABf4O3qfxAAQB3fMWHg staujZLnG1ROCPPdLyBtrY1O6ur4Y+G9TBhWNTr3tOadlM1e2KTvty6bwKu+kcue3wvJwBIbRuqVG /kHVDxum+0xsXcQer2Kk3MOoNELWQz2gfxgiI30obw6KDlnGJH2ptsgHTQ/39Kn74ppQpl8qApilv H4sYImBqq3BtQQlWJFZw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iZ99Q-000846-87; Mon, 25 Nov 2019 07:51:16 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iZ99M-00083T-8N; Mon, 25 Nov 2019 07:51:14 +0000 X-UUID: f5b9ab6cc71f43939f847d27592a9fac-20191124 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=dKoy+Dj949qquDmvkLLiMXT3sCo/sHKTe8EGHTNJRjE=; b=CTn4oY6MT2wOJ0kzFZvDENY4K7Ieq0x2H3cedeFvd6/tmlhLWeQ/8KEnjgwBeGruL41WtJD6WbYSrb+AhaR4nOSXhmwZcF6xVZuHTP6CLwRC6Yv26KBwnI7lLZK8Ff6+BQk8HrjqmnfhsNsC2+qsyvBjesuFfowGcoTXdz4vLDM=; X-UUID: f5b9ab6cc71f43939f847d27592a9fac-20191124 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 463010977; Sun, 24 Nov 2019 23:51:09 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 24 Nov 2019 23:41:15 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 25 Nov 2019 15:40:54 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 25 Nov 2019 15:40:24 +0800 Message-ID: <1574667666.9851.5.camel@mtkswgap22> Subject: Re: [PATCH v1 06/12] soc: mediatek: cmdq: add assign function From: Dennis-YC Hsieh To: CK Hu Date: Mon, 25 Nov 2019 15:41:06 +0800 In-Reply-To: <1574660121.26500.1.camel@mtksdaap41> References: <1574327552-11806-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574327552-11806-7-git-send-email-dennis-yc.hsieh@mediatek.com> <1574660121.26500.1.camel@mtksdaap41> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191124_235112_299318_37C9E68E X-CRM114-Status: GOOD ( 19.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi CK, On Mon, 2019-11-25 at 13:35 +0800, CK Hu wrote: > Hi, Dennis: > > On Thu, 2019-11-21 at 17:12 +0800, Dennis YC Hsieh wrote: > > Add assign function in cmdq helper which assign constant value into > > internal register by index. > > > > Signed-off-by: Dennis YC Hsieh > > --- > > drivers/soc/mediatek/mtk-cmdq-helper.c | 24 +++++++++++++++++++++++- > > include/linux/mailbox/mtk-cmdq-mailbox.h | 1 + > > include/linux/soc/mediatek/mtk-cmdq.h | 14 ++++++++++++++ > > 3 files changed, 38 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > > index 274f6f3..d419e99 100644 > > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > > @@ -14,6 +14,7 @@ > > #define CMDQ_EOC_IRQ_EN BIT(0) > > #define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \ > > << 32 | CMDQ_EOC_IRQ_EN) > > +#define CMDQ_REG_TYPE 1 > > > > struct cmdq_instruction { > > union { > > @@ -23,8 +24,17 @@ struct cmdq_instruction { > > union { > > u16 offset; > > u16 event; > > + u16 reg_dst; > > + }; > > + union { > > + u8 subsys; > > + struct { > > + u8 sop:5; > > + u8 arg_c_t:1; > > + u8 arg_b_t:1; > > + u8 arg_a_t:1; > > + }; > > }; > > - u8 subsys; > > u8 op; > > }; > > > > @@ -279,6 +289,18 @@ int cmdq_pkt_poll_mask(struct cmdq_pkt *pkt, u8 subsys, > > } > > EXPORT_SYMBOL(cmdq_pkt_poll_mask); > > > > +int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value) > > +{ > > + struct cmdq_instruction inst = { {0} }; > > + > > + inst.op = CMDQ_CODE_LOGIC; > > + inst.arg_a_t = CMDQ_REG_TYPE; > > It looks like that arg_a_t could have a meaningful name. > > Regards, > CK > Ok, I'll rename it. Thanks for your comment. Regards, Dennis > > + inst.reg_dst = reg_idx; > > + inst.value = value; > > + return cmdq_pkt_append_command(pkt, inst); > > +} > > +EXPORT_SYMBOL(cmdq_pkt_assign); > > + > > static int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > > { > > struct cmdq_client *cl = pkt->cl; > > diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailbox/mtk-cmdq-mailbox.h > > index dfe5b2e..121c3bb 100644 > > --- a/include/linux/mailbox/mtk-cmdq-mailbox.h > > +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h > > @@ -59,6 +59,7 @@ enum cmdq_code { > > CMDQ_CODE_JUMP = 0x10, > > CMDQ_CODE_WFE = 0x20, > > CMDQ_CODE_EOC = 0x40, > > + CMDQ_CODE_LOGIC = 0xa0, > > }; > > > > enum cmdq_cb_status { > > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > > index a74c1d5..8334021 100644 > > --- a/include/linux/soc/mediatek/mtk-cmdq.h > > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > > @@ -152,6 +152,20 @@ int cmdq_pkt_poll(struct cmdq_pkt *pkt, u8 subsys, > > */ > > int cmdq_pkt_poll_mask(struct cmdq_pkt *pkt, u8 subsys, > > u16 offset, u32 value, u32 mask); > > + > > +/** > > + * cmdq_pkt_assign() - Append logic assign command to the CMDQ packet, ask GCE > > + * to execute an instruction that set a constant value into > > + * internal register and use as value, mask or address in > > + * read/write instruction. > > + * @pkt: the CMDQ packet > > + * @reg_idx: the CMDQ internal register ID > > + * @value: the specified value > > + * > > + * Return: 0 for success; else the error code is returned > > + */ > > +int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value); > > + > > /** > > * cmdq_pkt_flush_async() - trigger CMDQ to asynchronously execute the CMDQ > > * packet and call back at the end of done packet > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel