From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10CA0C43603 for ; Tue, 10 Dec 2019 08:02:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A25CE20726 for ; Tue, 10 Dec 2019 08:02:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NtDEcEIf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="pnYDze4P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A25CE20726 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aYSIh7nfdY9505wkwtrQDh/Sncm44StqAiEeeaGW3sM=; b=NtDEcEIf+cAyLr Sm5VIyfS742fFUsIfJ6WSWJHPjmeSpJWgIQZzZEOSFiMMtoCUdV59CCOloZGRJBhaQpvkzD28Wqfd ay4lf1D0qgOjFwLLKhMQTM8Q+0198NoRrCDJiM/94f2ePhUTntrVJkbCkNWamecjIuVnh477m8i88 En1NaiLaPQ7SNaiVNpf32GxbRnQPqBfoRYJ9T9qaFNoZOEELl9ETORABlZxbPFHaFKDBLDt4R+yOE 8P966z2Opi55H4is3tnAQrWAc847KX4ttl+ujniUIgAiOBpb5F1xgmW0Mh01ZowAqPUC4AR1YNRTx zjODfZdSgTtwbBIUOnCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieaTV-0003zA-OQ; Tue, 10 Dec 2019 08:02:29 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieaTL-0003oc-MK; Tue, 10 Dec 2019 08:02:21 +0000 X-UUID: cd3fc1aeeae84335a2081af39e063573-20191210 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=JL3qkLaljq80IvyBNK1e0OAptSLHH1w7K2FYS4Mu4+8=; b=pnYDze4PDw3LNvqsJ9N4j1pEKHzA6nP7bTtf5VdAtRdg62/wshCcXA0I+rXCj4TpesT5BKuR2OnBUtsFti05F5uz5aoa0Dn1bFAyp8bWKaypVtKNJFFueIH+Npb4YKMWPQS7hSoATkJZX6KjTIEtJeVh7L5xYseeyUOkPZ4JRGo=; X-UUID: cd3fc1aeeae84335a2081af39e063573-20191210 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1466602751; Tue, 10 Dec 2019 00:00:25 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 9 Dec 2019 23:51:20 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 10 Dec 2019 15:50:03 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 10 Dec 2019 15:50:26 +0800 Message-ID: <1575964221.13210.1.camel@mtksdaap41> Subject: Re: [PATCH v2 11/14] soc: mediatek: cmdq: export finalize function From: CK Hu To: Dennis YC Hsieh Date: Tue, 10 Dec 2019 15:50:21 +0800 In-Reply-To: <1574819937-6246-13-git-send-email-dennis-yc.hsieh@mediatek.com> References: <1574819937-6246-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574819937-6246-13-git-send-email-dennis-yc.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191210_000219_753143_D034D2AD X-CRM114-Status: GOOD ( 15.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Dennis: On Wed, 2019-11-27 at 09:58 +0800, Dennis YC Hsieh wrote: > Export finalize function to client which helps append eoc and jump > command to pkt. Reviewed-by: CK Hu > > Signed-off-by: Dennis YC Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 7 ++----- > include/linux/soc/mediatek/mtk-cmdq.h | 8 ++++++++ > 2 files changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 244b8528eb16..38e0c13e1922 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -392,7 +392,7 @@ int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value) > } > EXPORT_SYMBOL(cmdq_pkt_assign); > > -static int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > +int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > { > struct cmdq_client *cl = pkt->cl; > struct cmdq_instruction inst = { {0} }; > @@ -412,6 +412,7 @@ static int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > > return err; > } > +EXPORT_SYMBOL(cmdq_pkt_finalize); > > static void cmdq_pkt_flush_async_cb(struct cmdq_cb_data data) > { > @@ -446,10 +447,6 @@ int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb cb, > unsigned long flags = 0; > struct cmdq_client *client = (struct cmdq_client *)pkt->cl; > > - err = cmdq_pkt_finalize(pkt); > - if (err < 0) > - return err; > - > pkt->cb.cb = cb; > pkt->cb.data = data; > pkt->async_cb.cb = cmdq_pkt_flush_async_cb; > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > index 4bce240dbb56..998bc90f9da9 100644 > --- a/include/linux/soc/mediatek/mtk-cmdq.h > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > @@ -204,6 +204,14 @@ int cmdq_pkt_poll_mask(struct cmdq_pkt *pkt, u8 subsys, > */ > int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value); > > +/** > + * cmdq_pkt_finalize() - Append EOC and jump command to pkt. > + * @pkt: the CMDQ packet > + * > + * Return: 0 for success; else the error code is returned > + */ > +int cmdq_pkt_finalize(struct cmdq_pkt *pkt); > + > /** > * cmdq_pkt_flush_async() - trigger CMDQ to asynchronously execute the CMDQ > * packet and call back at the end of done packet _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel