From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2120DC43603 for ; Wed, 11 Dec 2019 08:13:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D753421556 for ; Wed, 11 Dec 2019 08:13:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Nsl0lgKR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="VrSyV1Cp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D753421556 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LJpFGeX5VpXWLdAjs+9k4prsF+0+O83A1wZoAZDMv3I=; b=Nsl0lgKRu3CWbp RQZsyL9V9wemLOl4rMDCRI8nBr6NIY3P3L5VtRCsc5uacW0YsFPe2fRGr+/z1p1ITYl8Xpz6+6GQe N/g87KVxqmHg/LGqObi7UZhNHGb2n8jGjcvoRIu/g5AW/U4oQW8vMJGT9pX9uOVrwr9LitjpZyQTc 3fGphaeP3afQ7AlutovV4+xpbZd6g/cdZPrFxf2OcDZOADWIyhh6Tch8jWxN8Sbtm4JLkNlllo8Wb SP78UsLtDGMFdUht7tJU0cF9l3GR81DcPDfWFqb5OxgtW7ldk8WD2VO50I/SsSKWdKfKwgnhEnPK1 SoOYVQxv4VF8nTWXrGUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iex83-00028p-Ff; Wed, 11 Dec 2019 08:13:51 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iex7z-00027D-7C; Wed, 11 Dec 2019 08:13:48 +0000 X-UUID: 53c14fa4ae144fad8c9fbb3e631e4350-20191211 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=LMtGwOTN7KKUaEd8A9wg9LxG6VsxXxh0GBa84A4j5NY=; b=VrSyV1Cp/l36nS3QpKYFQo/XlsRas7PPPnVbCA0Vmr0Xq/oddPdYCRZ+S1LbSxLa35dk22OAX4BCsnJciiodIVZTT0ChjctJfIyvGXWxdOJosTtSwLsF9p3akTdDJSv8K+NEZp+u963N+G6BOLk9LhnhyLF5R0EpP+D0ff2xj7o=; X-UUID: 53c14fa4ae144fad8c9fbb3e631e4350-20191211 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 447750902; Wed, 11 Dec 2019 00:13:35 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Dec 2019 00:13:49 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Dec 2019 16:13:09 +0800 Received: from [172.21.84.99] (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 11 Dec 2019 16:12:57 +0800 Message-ID: <1576052012.1631.13.camel@mtksdccf07> Subject: Re: [PATCH] [RESEND] arm64: dts: mt8173: Add dynamic power node. From: Michael Kao To: Daniel Lezcano Date: Wed, 11 Dec 2019 16:13:32 +0800 In-Reply-To: <4aaf8cee-eaa2-5de4-37f0-094b9bc8da22@linaro.org> References: <20191122090610.17015-1-michael.kao@mediatek.com> <4aaf8cee-eaa2-5de4-37f0-094b9bc8da22@linaro.org> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191211_001347_267662_454C9465 X-CRM114-Status: GOOD ( 13.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Dawei Chien , linux-kernel@vger.kernel.org, Eduardo Valentin , Rob Herring , linux-mediatek@lists.infradead.org, hsinyi@chromium.org, Matthias Brugger , Zhang Rui , mn.tsou@mediatek.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2019-12-05 at 17:00 +0100, Daniel Lezcano wrote: > Hi Michael, > > > On 22/11/2019 10:06, michael.kao@mediatek.com wrote: > > From: "michael.kao" > > > > This device node is for calculating dynamic power in mW. > > Since mt8173 has two clusters, there are two dynamic power > > coefficient as well. > > Are you sure about the values? Usually, Big is ~x4 little, here it is ~x2. Hi Daniel, I have confirmed again with our IC designer. The dynamic power coefficients are these value is right. Designer comment that it is result from different IC implement. > > > Signed-off-by: Dawei Chien > > Signed-off-by: Michael.Kao > > > > --- > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > index 15f1842f6df3..b03ca5a71338 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > @@ -157,6 +157,7 @@ > > enable-method = "psci"; > > cpu-idle-states = <&CPU_SLEEP_0>; > > #cooling-cells = <2>; > > + dynamic-power-coefficient = <263>; > > clocks = <&infracfg CLK_INFRA_CA53SEL>, > > <&apmixedsys CLK_APMIXED_MAINPLL>; > > clock-names = "cpu", "intermediate"; > > @@ -170,6 +171,7 @@ > > enable-method = "psci"; > > cpu-idle-states = <&CPU_SLEEP_0>; > > #cooling-cells = <2>; > > + dynamic-power-coefficient = <263>; > > clocks = <&infracfg CLK_INFRA_CA53SEL>, > > <&apmixedsys CLK_APMIXED_MAINPLL>; > > clock-names = "cpu", "intermediate"; > > @@ -183,6 +185,7 @@ > > enable-method = "psci"; > > cpu-idle-states = <&CPU_SLEEP_0>; > > #cooling-cells = <2>; > > + dynamic-power-coefficient = <530>; > > clocks = <&infracfg CLK_INFRA_CA72SEL>, > > <&apmixedsys CLK_APMIXED_MAINPLL>; > > clock-names = "cpu", "intermediate"; > > @@ -196,6 +199,7 @@ > > enable-method = "psci"; > > cpu-idle-states = <&CPU_SLEEP_0>; > > #cooling-cells = <2>; > > + dynamic-power-coefficient = <530>; > > clocks = <&infracfg CLK_INFRA_CA72SEL>, > > <&apmixedsys CLK_APMIXED_MAINPLL>; > > clock-names = "cpu", "intermediate"; > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel