From: CK Hu <ck.hu@mediatek.com>
To: <matthias.bgg@kernel.org>
Cc: Matthias Brugger <mbrugger@suse.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
bibby.hsieh@mediatek.com,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: mediatek: cmdq: delete not used define
Date: Thu, 12 Dec 2019 13:11:32 +0800 [thread overview]
Message-ID: <1576127492.8315.1.camel@mtksdaap41> (raw)
In-Reply-To: <20191211185950.31358-1-matthias.bgg@kernel.org>
Hi, Matthias:
On Wed, 2019-12-11 at 19:59 +0100, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Define CMDQ_EOC_CMD was actually never used. Delete it.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>
> ---
>
> drivers/soc/mediatek/mtk-cmdq-helper.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 3c82de5f9417..1127c19c4e91 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -12,8 +12,6 @@
> #define CMDQ_ARG_A_WRITE_MASK 0xffff
> #define CMDQ_WRITE_ENABLE_MASK BIT(0)
> #define CMDQ_EOC_IRQ_EN BIT(0)
> -#define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \
> - << 32 | CMDQ_EOC_IRQ_EN)
>
> static void cmdq_client_timeout(struct timer_list *t)
> {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-12 5:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 18:59 [PATCH] soc: mediatek: cmdq: delete not used define matthias.bgg
2019-12-12 1:36 ` Bibby Hsieh
2019-12-12 5:11 ` CK Hu [this message]
2019-12-14 22:07 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1576127492.8315.1.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=bibby.hsieh@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox