From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBBC1C43603 for ; Fri, 13 Dec 2019 08:09:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1494206DA for ; Fri, 13 Dec 2019 08:09:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CBcVEY5a"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Zfzmf3ee" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1494206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bJI8qAx8SsaoyAv4RWJmFxJvPMY0Q1WIn3e2W2XdWvc=; b=CBcVEY5a0y9txE uXCsJ+NKmreyY4yYHw6+o/hR6n6UYOixKuF8Nmw4vc2RBXIhQaLpKbEjSR3nqMMcsRkqSv10Mq+yQ cH40XiEPS0RIH2i7tR7FJlgSw4fWjVLhiVx3+Jumd97wXftHKjo/cRz76r8RIcYu/kkNI473LgQE8 ytaSC1kxqFh+3w3TvTtP/vcAueisZcMopoG675AEXTUrFknKko4A62S9TzWlhg9XRsnMf8hdmB0oR xdvbv0gXTiFITF1bDlvBdDVMqkQ4UFsJMSk13AN6VHl5M2gV0aY3X6SE22sCdnAFxwPgvpdg6ycFf pQLRDy1RRxeHU+aaAUqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifg1D-0006h0-CJ; Fri, 13 Dec 2019 08:09:47 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifg1A-0006gZ-A8; Fri, 13 Dec 2019 08:09:45 +0000 X-UUID: 08c5585388254b87b29b892e9444109d-20191213 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=XJhy5g+NHFwDI5f0gUqZjPngJbGRrCHM6x7omxpoGFE=; b=Zfzmf3eeptgNR+cdaGZfy0k5q6FPpIVUdSfVXDRiJb7hUZaUP2sw4GA2U9fqz9gyeEeoE570TCJ3YSr1ZSqjh5pvEtFeAXGahzHxo0vo5wTqfo76dhcY7/DSz0KScAApushiW8tjfsjfuvkPRD+vD0JremZqlEVDzi767EuJmiY=; X-UUID: 08c5585388254b87b29b892e9444109d-20191213 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 13295992; Fri, 13 Dec 2019 00:09:40 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Dec 2019 00:09:55 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Dec 2019 16:09:23 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 13 Dec 2019 16:09:34 +0800 Message-ID: <1576224575.13335.1.camel@mtksdaap41> Subject: Re: [PATCH v2, 1/2] drm/mediatek: Fix gamma correction issue From: CK Hu To: Yongqiang Niu Date: Fri, 13 Dec 2019 16:09:35 +0800 In-Reply-To: <1576224191.31822.2.camel@mhfsdcap03> References: <1576222132-31586-1-git-send-email-yongqiang.niu@mediatek.com> <1576222132-31586-2-git-send-email-yongqiang.niu@mediatek.com> <1576223336.9817.3.camel@mtksdaap41> <1576224191.31822.2.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: E0C81D5B10B64C1A208C0F2484C5E394387DD294A1723E0D5353D5CFEA9397FD2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_000944_360467_C501A975 X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Yongqiang: On Fri, 2019-12-13 at 16:03 +0800, Yongqiang Niu wrote: > On Fri, 2019-12-13 at 15:48 +0800, CK Hu wrote: > > Hi, Yongqiang: > > > > The title is too rough. Any bug of gamma would be this title. I would > > like the title show explicitly what it does. > > > > On Fri, 2019-12-13 at 15:28 +0800, Yongqiang Niu wrote: > > > if there is no gamma function in the crtc > > > display path, don't add gamma property > > > for crtc > > > > > > Signed-off-by: Yongqiang Niu > > > --- > > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 10 ++++++++-- > > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > > index ca4fc47..9a8e1d4 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > > @@ -734,6 +734,7 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > > > int pipe = priv->num_pipes; > > > int ret; > > > int i; > > > + uint gamma_lut_size = 0; > > > > > > if (!path) > > > return 0; > > > @@ -785,6 +786,9 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > > > } > > > > > > mtk_crtc->ddp_comp[i] = comp; > > > + > > > + if (comp->funcs->gamma_set) > > > + gamma_lut_size = MTK_LUT_SIZE; > > > } > > > > > > for (i = 0; i < mtk_crtc->ddp_comp_nr; i++) > > > @@ -805,8 +809,10 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > > > NULL, pipe); > > > if (ret < 0) > > > return ret; > > > - drm_mode_crtc_set_gamma_size(&mtk_crtc->base, MTK_LUT_SIZE); > > > - drm_crtc_enable_color_mgmt(&mtk_crtc->base, 0, false, MTK_LUT_SIZE); > > > + > > > + if (gamma_lut_size) > > > + drm_mode_crtc_set_gamma_size(&mtk_crtc->base, gamma_lut_size); > > > + drm_crtc_enable_color_mgmt(&mtk_crtc->base, 0, false, gamma_lut_size); > > > > If there is no gamma, shall we enable color management? > > > > Regards, > > CK > > drm_crtc_enable_color_mgmt will check the gamma_lut_size parameter, > if no gamma, gamma_lut_size will be 0, and gamma_lut_size will not attch > gamma property for the crtc OK, you're right. So Reviewed-by: CK Hu and what title would you like? I could modify it when I apply this patch. Regards, CK > > > > > priv->num_pipes++; > > > mutex_init(&mtk_crtc->hw_lock); > > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel