linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Amit Daniel Kachhap <amit.kachhap@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	Kees Cook <keescook@chromium.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	Kristina Martsenko <kristina.martsenko@arm.com>,
	James Morse <james.morse@arm.com>,
	Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
	Amit Daniel Kachhap <amit.kachhap@arm.com>,
	Mark Brown <Mark.Brown@arm.com>,
	Vincenzo Frascino <Vincenzo.Frascino@arm.com>,
	Will Deacon <will@kernel.org>, Dave Martin <Dave.Martin@arm.com>
Subject: [PATCH v3 11/16] arm64: __show_regs: strip PAC from lr in printk
Date: Mon, 16 Dec 2019 14:17:13 +0530	[thread overview]
Message-ID: <1576486038-9899-12-git-send-email-amit.kachhap@arm.com> (raw)
In-Reply-To: <1576486038-9899-1-git-send-email-amit.kachhap@arm.com>

lr is printed with %pS which will try to find an entry in kallsyms.
After enabling pointer authentication, this match will fail due to
PAC present in the lr.

Strip PAC from the lr to display the correct symbol name.

Suggested-by: James Morse <james.morse@arm.com>
Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com>
---
Changes since last version:
* None.

 arch/arm64/kernel/process.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
index 0d4a3b8..d35b4c0 100644
--- a/arch/arm64/kernel/process.c
+++ b/arch/arm64/kernel/process.c
@@ -262,7 +262,7 @@ void __show_regs(struct pt_regs *regs)
 
 	if (!user_mode(regs)) {
 		printk("pc : %pS\n", (void *)regs->pc);
-		printk("lr : %pS\n", (void *)lr);
+		printk("lr : %pS\n", (void *)ptrauth_strip_insn_pac(lr));
 	} else {
 		printk("pc : %016llx\n", regs->pc);
 		printk("lr : %016llx\n", lr);
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-12-16  8:52 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16  8:47 [PATCH v3 00/16] arm64: return address signing Amit Daniel Kachhap
2019-12-16  8:47 ` [PATCH v3 01/16] arm64: cpufeature: add pointer auth meta-capabilities Amit Daniel Kachhap
2020-01-15 12:26   ` Catalin Marinas
2020-01-15 13:52     ` Suzuki Kuruppassery Poulose
2020-01-15 16:01       ` Catalin Marinas
2020-01-16 12:35         ` Amit Kachhap
2019-12-16  8:47 ` [PATCH v3 02/16] arm64: rename ptrauth key structures to be user-specific Amit Daniel Kachhap
2020-01-15 16:42   ` Catalin Marinas
2019-12-16  8:47 ` [PATCH v3 03/16] arm64: install user ptrauth keys at kernel exit time Amit Daniel Kachhap
2020-01-15 17:02   ` Catalin Marinas
2020-01-16 12:39     ` Amit Kachhap
2019-12-16  8:47 ` [PATCH v3 04/16] arm64: create macro to park cpu in an infinite loop Amit Daniel Kachhap
2020-01-07 11:13   ` Suzuki Kuruppassery Poulose
2020-01-15 17:03   ` Catalin Marinas
2019-12-16  8:47 ` [PATCH v3 05/16] arm64: ptrauth: Add bootup/runtime flags for __cpu_setup Amit Daniel Kachhap
2020-01-07 11:18   ` Suzuki Kuruppassery Poulose
2020-01-09  8:33     ` Amit Kachhap
2020-01-15 17:30   ` Catalin Marinas
2020-01-16 12:40     ` Amit Kachhap
2019-12-16  8:47 ` [PATCH v3 06/16] arm64: enable ptrauth earlier Amit Daniel Kachhap
2020-01-07 11:35   ` Suzuki Kuruppassery Poulose
2020-01-09  8:29     ` Amit Kachhap
2020-01-10 10:18       ` Suzuki Kuruppassery Poulose
2020-01-16 16:24   ` Catalin Marinas
2020-01-17 10:43     ` Amit Kachhap
2020-01-17 12:00       ` Catalin Marinas
2020-01-20 14:27         ` Amit Kachhap
2019-12-16  8:47 ` [PATCH v3 07/16] arm64: initialize and switch ptrauth kernel keys Amit Daniel Kachhap
2020-01-16 18:00   ` Catalin Marinas
2019-12-16  8:47 ` [PATCH v3 08/16] arm64: initialize ptrauth keys for kernel booting task Amit Daniel Kachhap
2020-01-16 17:59   ` Catalin Marinas
2020-01-20 10:50     ` Amit Kachhap
2019-12-16  8:47 ` [PATCH v3 09/16] arm64: mask PAC bits of __builtin_return_address Amit Daniel Kachhap
2020-01-17 10:14   ` Catalin Marinas
2020-01-20 14:20     ` Amit Kachhap
2020-01-21 16:52       ` Catalin Marinas
2019-12-16  8:47 ` [PATCH v3 10/16] arm64: unwind: strip PAC from kernel addresses Amit Daniel Kachhap
2020-01-17 10:22   ` Catalin Marinas
2019-12-16  8:47 ` Amit Daniel Kachhap [this message]
2020-01-17 10:25   ` [PATCH v3 11/16] arm64: __show_regs: strip PAC from lr in printk Catalin Marinas
2019-12-16  8:47 ` [PATCH v3 12/16] arm64: suspend: restore the kernel ptrauth keys Amit Daniel Kachhap
2020-01-17 10:31   ` Catalin Marinas
2019-12-16  8:47 ` [PATCH v3 13/16] arm64: kprobe: disable probe of ptrauth instruction Amit Daniel Kachhap
2020-01-17 11:16   ` Catalin Marinas
2020-01-20 14:24     ` Amit Kachhap
2019-12-16  8:47 ` [PATCH v3 14/16] kconfig: Add support for 'as-option' Amit Daniel Kachhap
2019-12-17 11:43   ` Masahiro Yamada
2020-01-17 11:33   ` Catalin Marinas
2020-01-17 17:51     ` Masahiro Yamada
2020-01-20 10:26     ` Vincenzo Frascino
2019-12-16  8:47 ` [PATCH v3 15/16] arm64: compile the kernel with ptrauth return address signing Amit Daniel Kachhap
2020-01-17 11:49   ` Catalin Marinas
2020-01-21 14:37     ` Amit Kachhap
2020-01-21 14:46       ` Vincenzo Frascino
2020-01-21 16:50       ` Catalin Marinas
2019-12-16  8:47 ` [PATCH v3 16/16] lkdtm: arm64: test kernel pointer authentication Amit Daniel Kachhap
2020-01-17 11:53   ` Catalin Marinas
2019-12-16  9:35 ` [RESEND PATCH v3 00/16] arm64: return address signing Amit Daniel Kachhap
2019-12-30 19:09 ` [PATCH " Kees Cook
2020-01-07 11:07   ` Amit Kachhap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1576486038-9899-12-git-send-email-amit.kachhap@arm.com \
    --to=amit.kachhap@arm.com \
    --cc=Dave.Martin@arm.com \
    --cc=Mark.Brown@arm.com \
    --cc=Vincenzo.Frascino@arm.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=james.morse@arm.com \
    --cc=keescook@chromium.org \
    --cc=kristina.martsenko@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=ramana.radhakrishnan@arm.com \
    --cc=richard.henderson@linaro.org \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).