From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76657C2D0CE for ; Fri, 3 Jan 2020 05:10:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 425032253D for ; Fri, 3 Jan 2020 05:10:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iKvZG/+f"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="gLoH/uxp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 425032253D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+Hm1PoTJXXt7TbtcW9wRX0Oilb/9h7lB/AtARR1OFbc=; b=iKvZG/+f6WmMTF wLFc3UKvY89kXFsTlzh6h9dm+lXfi8+Vs8LubR872bduZO59PxSOmuqTk1QYTRXnyUQtJ8Y8Yd+is sXdRXKtTEIGR5qqcgjRAYG+gOSeyOW8aiwULY1+lVKtpOEB8ixxcEBeAb+Ji0qvb/9Io7QoZSYzIt 9SvDu15M16645OpEtNWhCQtrlaIyUH7nspCagub2tQpVz/M0M/htwzVreRGrAUm17LdpVd0uf6K70 LB8EHoHDkdwGb/hhJ+3G1EJCS5UT7BSW6X/OXMoEOpx8GpHiiZCKiwaRu49cb3aQ2Wu0saNS+DWbn /Pj6+y2NnH/KUiyLENLw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1inFEX-0000wq-UG; Fri, 03 Jan 2020 05:10:49 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1inFEU-0000wG-Ke; Fri, 03 Jan 2020 05:10:48 +0000 X-UUID: db2464a7b7cc41a7ac60c5d2f4a4c066-20200102 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=IHfE2/cUwA9PEC02rixYfsxdmjk+Xm9SLy2M7/wL2z0=; b=gLoH/uxpS5v/wPVDWh1RDv2Z1+spfEKGpl4N58+bzVp7JoTGjqDD45E80mZ1QQQaUV3byb5rS5EtFSXJRxBvT5XHi6FRh3dNvO5NyBIl9qDDJ6y/Cj5ukchHCdNVivkDJSco+yUq2zYnlqrJ4gjDW+T4xqTUuVjwOJ0UEVfVgpA=; X-UUID: db2464a7b7cc41a7ac60c5d2f4a4c066-20200102 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1101560080; Thu, 02 Jan 2020 21:10:42 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 21:11:04 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 3 Jan 2020 13:10:07 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 3 Jan 2020 13:11:06 +0800 Message-ID: <1578028238.31107.2.camel@mtksdaap41> Subject: Re: [RESEND PATCH v6 01/17] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display From: CK Hu To: Yongqiang Niu Date: Fri, 3 Jan 2020 13:10:38 +0800 In-Reply-To: <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com> References: <1578021148-32413-1-git-send-email-yongqiang.niu@mediatek.com> <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: CA0325267D1E118D9AC11A3B80C3B2A10A2F0AF8FD38E2509178C262CC5F8E2C2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200102_211046_683970_4AF9C7E6 X-CRM114-Status: GOOD ( 12.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Yongqiang: On Fri, 2020-01-03 at 11:12 +0800, Yongqiang Niu wrote: > Update device tree binding documention for rdma_fifo_size > > Signed-off-by: Yongqiang Niu > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > index 681502e..34bef44 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > @@ -70,6 +70,10 @@ Required properties (DMA function blocks): > argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > for details. > > +Required properties (DMA function blocks): > +- mediatek,rdma_fifo_size: rdma fifo size may be different even in same SOC, add this > + property to the corresponding rdma I think "mediatek,rdma_fifo_size" is not a 'required' property. In mt8173.dtsi [1], there is no mediatek,rdma_fifo_size in rdma0, rdma1, and rdma2. So I think you should move this to 'optional' property. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/mediatek/mt8173.dtsi?h=v5.5-rc4 Regards, CK > + > Examples: > > mmsys: clock-controller@14000000 { > @@ -211,3 +215,12 @@ od@14023000 { > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; > clocks = <&mmsys CLK_MM_DISP_OD>; > }; > + > +rdma1: rdma@1400c000 { > + compatible = "mediatek,mt8183-disp-rdma"; > + reg = <0 0x1400c000 0 0x1000>; > + interrupts = ; > + power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>; > + clocks = <&mmsys CLK_MM_DISP_RDMA1>; > + mediatek,rdma_fifo_size = <2048>; > +}; > \ No newline at end of file _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel