From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AB50C35249 for ; Mon, 3 Feb 2020 15:01:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BBB920838 for ; Mon, 3 Feb 2020 15:01:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pY9E7xta"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vL9HRIWL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BBB920838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:From:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=VTdziI+al20qtbKGMzzcMXh8Gdx36I8/b4EIs+mEwKE=; b=pY9E7xtanMUm41 Nyk7l54IVjzRE2awIH0AzShq4I+rgIlegxNpO1WSGOYOlnW2VTU5p9nuJaqOEOKTAJhJO9PN0uYJP I/ELD9+BB+2nS0KpqrMi2LIEi2XM44X1fP60ycrKgvz38vt28VVPqSh99OTkttlCfKh8/Z5UCJnSh 9HDpjtP/e7CmU76aGA3xPKfw2wJdb5dKEgkAWg0ettuc73z52r/yr3/kUFh2Xq/BhyPjA6wj8QxFR DL6QxYt7gkjBMN0+ufruhUXcPQ1kTJteUBdW1k0PrGiQPy51b3zOZLKICzCDb/unqsot3hyKm/fUN JQ4fWaruQgpQiP06bUQA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iydEF-00078U-PP; Mon, 03 Feb 2020 15:01:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iydEC-00075g-Ec for linux-arm-kernel@lists.infradead.org; Mon, 03 Feb 2020 15:01:33 +0000 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9A2D92082E; Mon, 3 Feb 2020 15:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580742092; bh=SCq3/lnyNgfDSoTqwh/lSS4TR1b3t2ZWt2lO1bAbzFo=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=vL9HRIWLQlqD8q4O/t5mQD1LRW5GQJDX/NtfnvmHmc28fIs9YLFSdt6ZM0/1Df8wR SZNKcdiTR4fF7vZt1WoRbPmT9etY5517UlBOZGbWa+uf4l2H9FkFhRvvqqLHGtw2lw bawVyQgd1kczctiJUEWe5UAGkbgrwVQPmFiEAowE= Subject: Patch "media: si470x-i2c: Move free() past last use of 'radio'" has been added to the 4.9-stable tree To: gregkh@linuxfoundation.org, julia.lawall@lip6.fr, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org, lkp@intel.com From: Date: Mon, 03 Feb 2020 15:01:29 +0000 In-Reply-To: <20200203132130.12748-1-lee.jones@linaro.org> Message-ID: <158074208934130@kroah.com> MIME-Version: 1.0 X-stable: commit X-Patchwork-Hint: ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200203_070132_527148_4BB6AB38 X-CRM114-Status: GOOD ( 12.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable-commits@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a note to let you know that I've just added the patch titled media: si470x-i2c: Move free() past last use of 'radio' to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: media-si470x-i2c-move-free-past-last-use-of-radio.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From lee.jones@linaro.org Mon Feb 3 14:58:36 2020 From: Lee Jones Date: Mon, 3 Feb 2020 13:21:30 +0000 Subject: media: si470x-i2c: Move free() past last use of 'radio' To: stable@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-ID: <20200203132130.12748-1-lee.jones@linaro.org> From: Lee Jones A pointer to 'struct si470x_device' is currently used after free: drivers/media/radio/si470x/radio-si470x-i2c.c:462:25-30: ERROR: reference preceded by free on line 460 Shift the call to free() down past its final use. NB: Not sending to Mainline, since the problem does not exist there, it was caused by the backport of 2df200ab234a ("media: si470x-i2c: add missed operations in remove") to the stable trees. Cc: # v3.18+ Reported-by: kbuild test robot Reported-by: Julia Lawall Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- drivers/media/radio/si470x/radio-si470x-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/radio/si470x/radio-si470x-i2c.c +++ b/drivers/media/radio/si470x/radio-si470x-i2c.c @@ -458,10 +458,10 @@ static int si470x_i2c_remove(struct i2c_ free_irq(client->irq, radio); video_unregister_device(&radio->videodev); - kfree(radio); v4l2_ctrl_handler_free(&radio->hdl); v4l2_device_unregister(&radio->v4l2_dev); + kfree(radio); return 0; } Patches currently in stable-queue which might be from lee.jones@linaro.org are queue-4.9/media-si470x-i2c-move-free-past-last-use-of-radio.patch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel