From: Siddharth Gupta <sidgup@codeaurora.org>
To: ohad@wizery.com, bjorn.andersson@linaro.org
Cc: tsoni@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
rishabhb@codeaurora.org, Siddharth Gupta <sidgup@codeaurora.org>,
psodagud@codeaurora.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] remoteproc: core: Prevent sleep when rproc crashes
Date: Wed, 19 Feb 2020 18:11:53 -0800 [thread overview]
Message-ID: <1582164713-6413-3-git-send-email-sidgup@codeaurora.org> (raw)
In-Reply-To: <1582164713-6413-1-git-send-email-sidgup@codeaurora.org>
Remoteproc recovery should be fast and any delay will have an impact on the
user-experience. Use power management APIs (pm_stay_awake and pm_relax) to
ensure that the system does not go to sleep.
Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
---
drivers/remoteproc/remoteproc_core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 5ab65a4..52e318c 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -1712,6 +1712,8 @@ static void rproc_crash_handler_work(struct work_struct *work)
if (!rproc->recovery_disabled)
rproc_trigger_recovery(rproc);
+
+ pm_relax(&rproc->dev);
}
/**
@@ -2242,6 +2244,8 @@ void rproc_report_crash(struct rproc *rproc, enum rproc_crash_type type)
return;
}
+ pm_stay_awake(&rproc->dev);
+
dev_err(&rproc->dev, "crash detected in %s: type %s\n",
rproc->name, rproc_crash_to_string(type));
--
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-20 2:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 2:11 [PATCH 0/2] remoteproc: core: Add core functionality to the remoteproc framework Siddharth Gupta
2020-02-20 2:11 ` [PATCH 1/2] remoteproc: core: Add an API for booting with firmware name Siddharth Gupta
2020-02-24 18:30 ` Mathieu Poirier
2020-02-26 23:10 ` Siddharth Gupta
2020-02-20 2:11 ` Siddharth Gupta [this message]
2020-02-24 18:53 ` [PATCH 2/2] remoteproc: core: Prevent sleep when rproc crashes Mathieu Poirier
2020-04-07 18:00 ` Siddharth Gupta
2020-04-07 22:29 ` Bjorn Andersson
2020-04-07 22:59 ` rishabhb
2020-04-07 23:26 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582164713-6413-3-git-send-email-sidgup@codeaurora.org \
--to=sidgup@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=psodagud@codeaurora.org \
--cc=rishabhb@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).