From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0AB9C11D27 for ; Fri, 21 Feb 2020 04:40:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96B0F24650 for ; Fri, 21 Feb 2020 04:40:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qIoxFdeq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="rATm3auc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96B0F24650 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DQNsw2vDsO0+yC8E9iaZKH/sdqwHlwjtrlJusmvqono=; b=qIoxFdeqU+9RvT Gboa/UFHGA6ifdmV+D7zcWiLWjq+hc1Z8FIT9nuHqAgbTumcTX/5JDkRfqoqMPKs73id2PC+Emn+k DvM+LxD2AvWxYXKRsTw9UbOwh9+ht7BlWWLp5Nv70HiFqeXClUgRYG0nX74rFOs5c0VUS3LSoM+55 WMn4MdFgaX1EIWe2hrjM4Cv/5R6dVEbhhveUASIGXiJkaMmxPNPEcDUmyI7q7qH9NnGeG9nhkdJYO JJdTTlLmkddXOoNm2vWbe6y+/SA3fsegP09dyQTP6VDXrTsTlkawAOAPW7SRMYhr2vzOeehBJCDvu /WORYC/FD219kfdjv61g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j506l-0005R4-LX; Fri, 21 Feb 2020 04:40:11 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j506g-00046U-3r; Fri, 21 Feb 2020 04:40:08 +0000 X-UUID: 83e1bbc277d24677be71ac1f3fb7374a-20200220 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=c6LxKOrtf7zqmWMQ6HOJ1i4yDenxu3IQklK++RZdHNY=; b=rATm3auciYfKwqBo300ayxZ+epaBIPidFLEOlYR9R+lDw3Sp+wVUGJfQ/SnMCJj2IlLlRrnfPhygOlPO76AN/7FP6irXcAVyfhVWuWJj5+EoGJyr4O+QUJUqF41kXVEViY6blmVtLf130JmWPN0aA6yAcj65lUJZjI08MHLM4xs=; X-UUID: 83e1bbc277d24677be71ac1f3fb7374a-20200220 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1511868965; Thu, 20 Feb 2020 20:39:59 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 20 Feb 2020 20:39:57 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 21 Feb 2020 12:39:09 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 21 Feb 2020 12:40:26 +0800 Message-ID: <1582259996.1846.7.camel@mtksdaap41> Subject: Re: [PATCH v8 0/6] arm/arm64: mediatek: Fix mmsys device probing From: CK Hu To: Enric Balletbo i Serra Date: Fri, 21 Feb 2020 12:39:56 +0800 In-Reply-To: <20200220172147.919996-1-enric.balletbo@collabora.com> References: <20200220172147.919996-1-enric.balletbo@collabora.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200220_204006_180769_B839BDC3 X-CRM114-Status: GOOD ( 20.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Kate Stewart , Minghsiu Tsai , Andrew-CT Chen , airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, Richard Fontana , laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, Collabora Kernel ML , linux-clk@vger.kernel.org, Nicolas Boichat , Weiyi Lu , Krzysztof Kozlowski , wens@csie.org, linux-arm-kernel@lists.infradead.org, mtk01761 , Owen Chen , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Daniel Vetter , frank-w@public-files.de, Seiya Wang , sean.wang@mediatek.com, Houlong Wei , robh+dt@kernel.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org, Matthias Brugger , Thomas Gleixner , Mauro Carvalho Chehab , Allison Randal , Matthias Brugger , Fabien Parent , sboyd@kernel.org, Greg Kroah-Hartman , rdunlap@infradead.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, matthias.bgg@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Enric: On Thu, 2020-02-20 at 18:21 +0100, Enric Balletbo i Serra wrote: > Dear all, > > Those patches are intended to solve an old standing issue on some > Mediatek devices (mt8173, mt2701 and mt2712) in a slightly different way > to the precedent series. > > Up to now both drivers, clock and drm are probed with the same device tree > compatible. But only the first driver get probed, which in effect breaks > graphics on those devices. > > The version eight of the series tries to solve the problem with a > different approach than the previous series but similar to how is solved > on other Mediatek devices. > > The MMSYS (Multimedia subsystem) in Mediatek SoCs has some registers to > control clock gates (which is used in the clk driver) and some registers > to set the routing and enable the differnet blocks of the display > and MDP (Media Data Path) subsystem. On this series the clk driver is > not a pure clock controller but a system controller that can provide > access to the shared registers between the different drivers that need > it (mediatek-drm and mediatek-mdp). And the biggest change is, that in > this version, clk driver is the entry point (parent) which will trigger > the probe of the corresponding mediatek-drm driver and pass its MMSYS > platform data for display configuration. When mmsys is a system controller, I prefer to place mmsys in drivers/soc/mediatek, and it share registers for clock, display, and mdp driver. This means the probe function is placed in drivers/soc/mediatek ,its display clock function, mdp clock function are placed in drivers/clk, display routing are placed in drivers/gpu/drm, and mdp routing are placed in dirvers/video. Regards, CK > > All this series was tested on the Acer R13 Chromebook only. > > For reference, here are the links to the old discussions: > > * v7: https://patchwork.kernel.org/project/linux-mediatek/list/?series=241217 > * v6: https://patchwork.kernel.org/project/linux-mediatek/list/?series=213219 > * v5: https://patchwork.kernel.org/project/linux-mediatek/list/?series=44063 > * v4: > * https://patchwork.kernel.org/patch/10530871/ > * https://patchwork.kernel.org/patch/10530883/ > * https://patchwork.kernel.org/patch/10530885/ > * https://patchwork.kernel.org/patch/10530911/ > * https://patchwork.kernel.org/patch/10530913/ > * v3: > * https://patchwork.kernel.org/patch/10367857/ > * https://patchwork.kernel.org/patch/10367861/ > * https://patchwork.kernel.org/patch/10367877/ > * https://patchwork.kernel.org/patch/10367875/ > * https://patchwork.kernel.org/patch/10367885/ > * https://patchwork.kernel.org/patch/10367883/ > * https://patchwork.kernel.org/patch/10367889/ > * https://patchwork.kernel.org/patch/10367907/ > * https://patchwork.kernel.org/patch/10367909/ > * https://patchwork.kernel.org/patch/10367905/ > * v2: No relevant discussion, see v3 > * v1: > * https://patchwork.kernel.org/patch/10016497/ > * https://patchwork.kernel.org/patch/10016499/ > * https://patchwork.kernel.org/patch/10016505/ > * https://patchwork.kernel.org/patch/10016507/ > > Best regards, > Enric > > Changes in v8: > - Be a builtin_platform_driver like other mediatek mmsys drivers. > - New patches introduced in this series. > > Changes in v7: > - Add R-by from CK > - Add R-by from CK > - Fix check of return value of of_clk_get > - Fix identation > - Free clk_data->clks as well > - Get rid of private data structure > > Enric Balletbo i Serra (2): > drm/mediatek: Move MMSYS configuration to include/linux/platform_data > clk/drm: mediatek: Fix mediatek-drm device probing > > Matthias Brugger (4): > drm/mediatek: Use regmap for register access > drm/mediatek: Omit warning on probe defers > media: mtk-mdp: Check return value of of_clk_get > clk: mediatek: mt8173: Switch MMSYS to platform driver > > drivers/clk/mediatek/Kconfig | 6 + > drivers/clk/mediatek/Makefile | 1 + > drivers/clk/mediatek/clk-mt2701-mm.c | 30 +++ > drivers/clk/mediatek/clk-mt2712-mm.c | 44 +++++ > drivers/clk/mediatek/clk-mt8173-mm.c | 172 ++++++++++++++++++ > drivers/clk/mediatek/clk-mt8173.c | 104 ----------- > drivers/gpu/drm/mediatek/mtk_disp_color.c | 5 +- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 5 +- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 5 +- > drivers/gpu/drm/mediatek/mtk_dpi.c | 12 +- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 53 +++--- > drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 4 +- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 56 +----- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 113 +----------- > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 13 +- > drivers/gpu/drm/mediatek/mtk_dsi.c | 8 +- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 +- > drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 6 + > include/linux/platform_data/mtk_mmsys.h | 73 ++++++++ > 20 files changed, 401 insertions(+), 317 deletions(-) > create mode 100644 drivers/clk/mediatek/clk-mt8173-mm.c > create mode 100644 include/linux/platform_data/mtk_mmsys.h > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel