From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05A62C35DEE for ; Tue, 25 Feb 2020 02:16:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8A0F21927 for ; Tue, 25 Feb 2020 02:16:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tnFShDZs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="juMGCsAh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8A0F21927 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G4JRZYDUkTx8MpwzTJGyg1OK6Ki7I9YBg8gINYfM8vo=; b=tnFShDZsLouIav CFHdNNa8oxf8EFpDjPUGRRvb46F9Y0lwSHmrrs9N55UNDtU5m+nKnltBniDwmJBoxv8cWzcf9jUpP I3+CwceAYYdCMspK5WXIHLm+bhcbS1iMhEhlQw2PApQjqgNb2SZdloAaEOLzIIqPUCLo9pQaVGK5P o4YUF9DtPfRAoBJ0z+E3wURAhjyPgrbO5GbztrJFr20VuzjsngAT4brF3v/MBJLYD7CTm4jCoSnGV vVxv4pdKvAw16pV7iBxhb0FyVMOLGT5Dk/i6OFGAfOWLiUWOJawrVtHBemFIWQNbMDsd+FJwRKzbZ UHdCsSDIsXA3IaSO8Igg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6Pli-0000uR-K5; Tue, 25 Feb 2020 02:16:18 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6PlN-0000ZB-69; Tue, 25 Feb 2020 02:15:58 +0000 X-UUID: 4e06724025704201bcfdf617f47b2e6c-20200224 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=vFmdE11xim42gZLvGB5rqIwRp1BgTnnvR3iRXzqexqc=; b=juMGCsAhVnUVJYtIRXq5E4agPjE5ofssA9lZbTNh+w0IFQIrWhSej7rzlA/B56eRpor6ShGwcv38OLUkHSK4sFAh8rTvfr0qNqbdZy8ztwda96ruRpAD9fsniUmtmoMmJ7vOPU7k8rYBmhJ7e3zCMGmgsWNSm4KENOa7ThMZUVs=; X-UUID: 4e06724025704201bcfdf617f47b2e6c-20200224 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 388191961; Mon, 24 Feb 2020 18:15:53 -0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 24 Feb 2020 18:13:57 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 25 Feb 2020 10:13:03 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 25 Feb 2020 10:14:09 +0800 Message-ID: <1582596836.31498.4.camel@mtksdaap41> Subject: Re: [PATCH v6 1/4] dt-bindings: display: mediatek: update dpi supported chips From: CK Hu To: Jitao Shi Date: Tue, 25 Feb 2020 10:13:56 +0800 In-Reply-To: <1582596343.12484.6.camel@mszsdaap41> References: <20200221112828.55837-1-jitao.shi@mediatek.com> <20200221112828.55837-2-jitao.shi@mediatek.com> <1582533982.12922.5.camel@mtksdaap41> <1582596343.12484.6.camel@mszsdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200224_181557_240177_0B529A8B X-CRM114-Status: GOOD ( 20.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, bibby.hsieh@mediatek.com, srv_heupstream@mediatek.com, David Airlie , huijuan.xie@mediatek.com, stonea168@163.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, cawa.cheng@mediatek.com, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , yingjoe.chen@mediatek.com, eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Jitao: On Tue, 2020-02-25 at 10:05 +0800, Jitao Shi wrote: > On Mon, 2020-02-24 at 16:46 +0800, CK Hu wrote: > > Hi, Jitao: > > > > On Fri, 2020-02-21 at 19:28 +0800, Jitao Shi wrote: > > > Add decriptions about supported chips, including MT2701 & MT8173 & > > > mt8183 > > > > > > 1. Add more chips support. ex. MT2701 & MT8173 & MT8183 > > > 2. Add property "dpi_pin_mode_swap" and "pinctrl-names" gpio mode dpi mode and > > > gpio oupput-low to avoid leakage current. > > > 3. Add property "dpi_dual_edge" to config the dpi pin output mode dual edge or > > > single edge sample data. > > > > > > Signed-off-by: Jitao Shi > > > --- > > > .../bindings/display/mediatek/mediatek,dpi.txt | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt > > > index b6a7e7397b8b..cd6a1469c8b7 100644 > > > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt > > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt > > > @@ -7,6 +7,7 @@ output bus. > > > > > > Required properties: > > > - compatible: "mediatek,-dpi" > > > + the supported chips are mt2701 , mt8173 and mt8183. > > > - reg: Physical base address and length of the controller's registers > > > - interrupts: The interrupt signal from the function block. > > > - clocks: device clocks > > > @@ -16,6 +17,11 @@ Required properties: > > > Documentation/devicetree/bindings/graph.txt. This port should be connected > > > to the input port of an attached HDMI or LVDS encoder chip. > > > > > > +Optional properties: > > > +- dpi_pin_mode_swap: Swap the pin mode between dpi mode and gpio mode. > > > +- pinctrl-names: Contain "gpiomode" and "dpimode". > > > +- dpi_dual_edge: Control the RGB 24bit data on 12 pins or 24 pins. > > > > I've find that in [1], there are already a property of "pclk-sample" > > which like this, but it only have rising (1) or falling (0) status. Does > > that property describe the same thing with this property? If they are > > the same, I think you should add new state, dual (2), for "pclk-sample". > > > > [1] > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/media/video-interfaces.txt?h=v5.6-rc3 > > > > Regards, > > CK > > > > pclk-sample has two properties rising or falling. > It means to sample on rising or falling edge. > > But, dpi_dual_edge means to sample on both rising and falling edge. > It seems that both describe "When to sample data", so they are the same for me. I think we should prevent to invent a new property if there is already a one. Even though pclk-sample just have two state (rising or falling edge), I think we could add a new state (dual edge) to pclk-sample. Regards, CK > Best Regards > Jitao > > > + > > > Example: > > > > > > dpi0: dpi@1401d000 { > > > @@ -26,6 +32,11 @@ dpi0: dpi@1401d000 { > > > <&mmsys CLK_MM_DPI_ENGINE>, > > > <&apmixedsys CLK_APMIXED_TVDPLL>; > > > clock-names = "pixel", "engine", "pll"; > > > + dpi_dual_edge; > > > + dpi_pin_mode_swap; > > > + pinctrl-names = "gpiomode", "dpimode"; > > > + pinctrl-0 = <&dpi_pin_gpio>; > > > + pinctrl-1 = <&dpi_pin_func>; > > > > > > port { > > > dpi0_out: endpoint { > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel