From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 774F7C35DF5 for ; Tue, 25 Feb 2020 05:08:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 492B824682 for ; Tue, 25 Feb 2020 05:08:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k0rAnrWQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="k6MaK41Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 492B824682 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JnvExvA1Mgyub/3VX1u8tINUUeKKaHirkybdynmzT4w=; b=k0rAnrWQRBxXGh ALXMpFumGkBJG7bu15/YEBtqv84MFg7z0Y2869m5341ELflaXb3m2v3/9NjVsOhEI7eWAEujWYCfF bGuaZZTF7Q6kJNY8isqCU7dqkdkOJPn7F7FBz6wspwKcVCWg0CO0xuJfkzDos+uZ9k0cJ0PgXBT5C t9Wc/F4dAOsNEyZfG9QgHdBWoeRzkUyb+kKLiq1OLwOV2hYvQ8sGhJZ3O5ukBf6U+IIBjvEA6g1ka Mo4wOO7bb8g+Ya31hvmZmgSi+0hEOBpBP0Lr1jmA3a4N7YA+NjHoSsxEg1VqNfYdQzcoqN9wta/Hu n6lPAxsU0deUCRPZ7hrg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6SRq-0004qK-Om; Tue, 25 Feb 2020 05:07:58 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6SRn-0004pU-Tv; Tue, 25 Feb 2020 05:07:57 +0000 X-UUID: 7ffb3ae7994d45a9a050f143c1604cf8-20200224 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=/rtGSIQMd4B3KB57xrUi7K3ubIpRTDkINY3agOAnA5g=; b=k6MaK41Z4INDrhlLEsvigYWeqTh9KMbVAE4ZQ0AUwAR/E6/XeZeuqynBxE/WxD1qeeiY7W6m6HsF1GYPTzQpTTLUSHUPGcjZs4u8fenJ3IydNtJ6BfnlT7x9HSypnkdAbgcTOR+2PeEMeKS5eV4IsmKz/Dev9txQai0K7pSeBEA=; X-UUID: 7ffb3ae7994d45a9a050f143c1604cf8-20200224 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2019203508; Mon, 24 Feb 2020 21:07:50 -0800 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 24 Feb 2020 21:08:25 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 25 Feb 2020 13:07:08 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 25 Feb 2020 13:07:28 +0800 Message-ID: <1582607261.2773.0.camel@mtksdaap41> Subject: Re: [PATCH] drm/mediatek: component type MTK_DISP_OVL_2L is not correctly handled From: CK Hu To: Phong LE Date: Tue, 25 Feb 2020 13:07:41 +0800 In-Reply-To: <1582162568.24713.0.camel@mtksdaap41> References: <20200219141324.29299-1-ple@baylibre.com> <1582162568.24713.0.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200224_210755_970197_2DC3936B X-CRM114-Status: GOOD ( 12.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Phong: On Thu, 2020-02-20 at 09:36 +0800, CK Hu wrote: > Hi, Phong: > > On Wed, 2020-02-19 at 15:13 +0100, Phong LE wrote: > > The larb device remains NULL if the type is MTK_DISP_OVL_2L. > > A kernel panic is raised when a crtc uses mtk_smi_larb_get or > > mtk_smi_larb_put. > > > > Reviewed-by: CK Hu > Applied to mediatek-drm-fixes-5.6 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-fixes-5.6 Regards, CK > > Signed-off-by: Phong LE > > --- > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > index 1f5a112bb034..57c88de9a329 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > @@ -471,6 +471,7 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node, > > /* Only DMA capable components need the LARB property */ > > comp->larb_dev = NULL; > > if (type != MTK_DISP_OVL && > > + type != MTK_DISP_OVL_2L && > > type != MTK_DISP_RDMA && > > type != MTK_DISP_WDMA) > > return 0; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel