From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8C18C3F2CD for ; Fri, 28 Feb 2020 14:59:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9ECB1246AC for ; Fri, 28 Feb 2020 14:59:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GVbgpbDU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="O7wfci0L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9ECB1246AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K2HAufjk1sTm/nKgi+hCOTTL3apKIQONVQVLKdyz4qo=; b=GVbgpbDU/TnprI 4iAgUf33wu1oA0zq8mAFShQd6YoK0eS2bUQQTalyjzIXike2LUm+323qE/plw2kFPZisTSQOFitbg wLILr8/FtLLJkKC8FdUd8JNBM/W1u71U+j5PAEKSFRC+Z8fNTfRPW5lrc117IU0yGX0pwoPOGtC5X lPsL8QodL3iNO0givdft+JB3eBjcVe0JnjTO2KA+cPjQcCpLlvDDysvYYvR0joqb//ZmmF/HCpjh7 zPM3cfL2B3u6Q+3fk3KNglkM4bDDvn115e7k7GpQsp/raWpqQL/PTDIbFJp//6lgtuOe6S6vp1rKP Y/lWfiZPMmHZuv5kDzRQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7h7G-0000cO-0C; Fri, 28 Feb 2020 14:59:50 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7h7C-0000aO-S1; Fri, 28 Feb 2020 14:59:48 +0000 X-UUID: d1757a6a068a4d89b11238bac8893962-20200228 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=NL2GKs6cWZDfq31vqetafIYcn/LVSVpleZHl8l/E0rk=; b=O7wfci0LBzMs+CBDiVNz+g2C6d0p1eYFDc29HRsUl3sjtufIbFNwKiU8mVRFO3tloAXCPQsHIX4N47d7Hr7BRH6xj1iHm6dLhmDzGpEsQUZXwKl8nkQQt7WyfaggBoaaDFeJKelNttA5WjjBow8GLvu9T5AjZWsPPHeT38lSN30=; X-UUID: d1757a6a068a4d89b11238bac8893962-20200228 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1730676086; Fri, 28 Feb 2020 06:59:44 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 28 Feb 2020 07:00:51 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 28 Feb 2020 22:58:36 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 28 Feb 2020 22:59:23 +0800 Message-ID: <1582901981.14824.9.camel@mtksdaap41> Subject: Re: [PATCH v3 11/13] soc: mediatek: cmdq: add jump function From: CK Hu To: Dennis YC Hsieh Date: Fri, 28 Feb 2020 22:59:41 +0800 In-Reply-To: <1582897461-15105-13-git-send-email-dennis-yc.hsieh@mediatek.com> References: <1582897461-15105-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1582897461-15105-13-git-send-email-dennis-yc.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200228_065946_910227_DA1CAA5C X-CRM114-Status: GOOD ( 14.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, srv_heupstream@mediatek.com, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , Ming-Fan Chen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Dennis: On Fri, 2020-02-28 at 21:44 +0800, Dennis YC Hsieh wrote: > Add jump function so that client can jump to any address which > contains instruction. > > Signed-off-by: Dennis YC Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 12 ++++++++++++ > include/linux/soc/mediatek/mtk-cmdq.h | 11 +++++++++++ > 2 files changed, 23 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 58fec634dcf1..bbc68a7c81e9 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -372,6 +372,18 @@ int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value) > } > EXPORT_SYMBOL(cmdq_pkt_assign); > > +int cmdq_pkt_jump(struct cmdq_pkt *pkt, dma_addr_t addr) > +{ > + struct cmdq_client *cl = pkt->cl; > + struct cmdq_instruction inst = { {0} }; > + > + inst.op = CMDQ_CODE_JUMP; > + inst.offset = 1; Symbolize the value '1'. > + inst.value = addr >> cmdq_mbox_shift(cl->chan); If you write as 'cmdq_mbox_shift(pkt->cl->chan)', you could drop local variable 'cl'. Regards, CK > + return cmdq_pkt_append_command(pkt, inst); > +} > +EXPORT_SYMBOL(cmdq_pkt_jump); > + > int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > { > struct cmdq_instruction inst = { {0} }; > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > index 99e77155f967..1a6c56f3bec1 100644 > --- a/include/linux/soc/mediatek/mtk-cmdq.h > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > @@ -213,6 +213,17 @@ int cmdq_pkt_poll_mask(struct cmdq_pkt *pkt, u8 subsys, > */ > int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value); > > +/** > + * cmdq_pkt_jump() - Append jump command to the CMDQ packet, ask GCE > + * to execute an instruction that change current thread PC to > + * a physical address which should contains more instruction. > + * @pkt: the CMDQ packet > + * @addr: physical address of target instruction buffer > + * > + * Return: 0 for success; else the error code is returned > + */ > +int cmdq_pkt_jump(struct cmdq_pkt *pkt, dma_addr_t addr); > + > /** > * cmdq_pkt_finalize() - Append EOC and jump command to pkt. > * @pkt: the CMDQ packet _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel