From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B895C3F2C6 for ; Sat, 29 Feb 2020 13:50:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 411B824650 for ; Sat, 29 Feb 2020 13:50:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="drcuCoen"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="qtHrLnFU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 411B824650 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lXzbIAzNVuuDqIYeaH8GrNNq4RXM6QSthpWShZH9y7o=; b=drcuCoenooSQYe zX5FFy27xw5rd8olygSSqMTPhVQ8cWgrIg+EOuDVxsJC+FB56Nf/URe/wZjm12Hg70e6bfNphBBC9 9nDOIYJBMbYn55p6SHcqUvWEPRRnStJBU9DL2X8qSaGei/Gb4H2MwEOWec+Y6rleitXhwyWDLPZtU 8D6GNALfkn0Auz2LXCC+LxGGVaSIPVW/ALrimHtF/88RgNDrtzqUhjKqwAz0a9kA4jb4zfOQA3w5y NIbQfSOq7Xhp2awDi5dwmpqfudHzzriQ5yaA3ivxbFJeiN2uiXHqtfnm8aXkrLzuiBq4ACik14+hB bCjRUlyOmaqjxGcScgpg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j82W3-0003K6-70; Sat, 29 Feb 2020 13:50:51 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j82Vh-00032S-4f; Sat, 29 Feb 2020 13:50:30 +0000 X-UUID: 158cfb9a92d64469ba34d04820205955-20200229 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=zitOnP+eApgORZH5lc1x2JLP2/ns1VkO1JNAYN3t0Mo=; b=qtHrLnFUYhBMoT1w9NcGdVcwhvo70GhgdkBKqsVFIrTKja51WwEBe0CegOs7ABnbu2OdPVoRul/lb3WPdIc1jiZks6nH0JqO8V75jyyHTyo9ILR+/ZPORx7D9vn3oy8NJZqKduZlqpsBJt6BlAP09+KXdg5+P0W09uNhbLdqaHI=; X-UUID: 158cfb9a92d64469ba34d04820205955-20200229 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 587070405; Sat, 29 Feb 2020 05:50:26 -0800 Received: from mtkmbs08n2.mediatek.inc (172.21.101.56) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 29 Feb 2020 05:41:08 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 29 Feb 2020 21:39:16 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 29 Feb 2020 21:39:54 +0800 Message-ID: <1582983616.21073.4.camel@mtkswgap22> Subject: Re: [PATCH v3 04/13] mailbox: mediatek: cmdq: clear task in channel before shutdown From: Dennis-YC Hsieh To: CK Hu Date: Sat, 29 Feb 2020 21:40:16 +0800 In-Reply-To: <1582905422.14824.22.camel@mtksdaap41> References: <1582897461-15105-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1582897461-15105-6-git-send-email-dennis-yc.hsieh@mediatek.com> <1582905422.14824.22.camel@mtksdaap41> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: 3FC05AABEE98AB8056D43B46ECFD21BB96CB48C37D022F69760BF94E6E4745AE2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200229_055029_185056_AA1B8ABA X-CRM114-Status: GOOD ( 18.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, srv_heupstream@mediatek.com, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , Ming-Fan Chen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi CK, Thanks for your comment. On Fri, 2020-02-28 at 23:57 +0800, CK Hu wrote: > Hi, Dennis: > > On Fri, 2020-02-28 at 21:44 +0800, Dennis YC Hsieh wrote: > > Do success callback in channel when shutdown. For those task not finish, > > callback with error code thus client has chance to cleanup or reset. > > > > Signed-off-by: Dennis YC Hsieh > > --- > > drivers/mailbox/mtk-cmdq-mailbox.c | 38 ++++++++++++++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > > index 7246b7e21a2e..50dec015593f 100644 > > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > > @@ -387,6 +387,12 @@ static int cmdq_mbox_send_data(struct mbox_chan *chan, void *data) > > > > if (list_empty(&thread->task_busy_list)) { > > WARN_ON(clk_enable(cmdq->clock) < 0); > > + /* > > + * The thread reset will clear thread related register to 0, > > + * including pc, end, priority, irq, suspend and enable. Thus > > + * set CMDQ_THR_ENABLED to CMDQ_THR_ENABLE_TASK will enable > > + * thread and make it running. > > + */ > > WARN_ON(cmdq_thread_reset(cmdq, thread) < 0); > > > > writel(task->pa_base >> cmdq->shift_pa, > > @@ -450,6 +456,38 @@ static int cmdq_mbox_startup(struct mbox_chan *chan) > > > > static void cmdq_mbox_shutdown(struct mbox_chan *chan) > > { > > + struct cmdq_thread *thread = (struct cmdq_thread *)chan->con_priv; > > + struct cmdq *cmdq = dev_get_drvdata(chan->mbox->dev); > > + struct cmdq_task *task, *tmp; > > + unsigned long flags; > > + > > + spin_lock_irqsave(&thread->chan->lock, flags); > > + if (list_empty(&thread->task_busy_list)) > > + goto done; > > + > > + WARN_ON(cmdq_thread_suspend(cmdq, thread) < 0); > > + > > + /* make sure executed tasks have success callback */ > > + cmdq_thread_irq_handler(cmdq, thread); > > + if (list_empty(&thread->task_busy_list)) > > + goto done; > > + > > + list_for_each_entry_safe(task, tmp, &thread->task_busy_list, > > + list_entry) { > > + cmdq_task_exec_done(task, -ECONNABORTED); > > cmdq_task_exec_done(task, CMDQ_CB_ERROR) ? However, I've like to use the > standard error as you write here. > Ok, for consistent with current design, I will change to CMDQ_CB_ERROR. And send another patch to change all cmdq error definition to standard error next time. Regards, Dennis > Regards, > CK > > > + kfree(task); > > + } > > + > > + cmdq_thread_disable(cmdq, thread); > > + clk_disable(cmdq->clock); > > +done: > > + /* > > + * The thread->task_busy_list empty means thread already disable. The > > + * cmdq_mbox_send_data() always reset thread which clear disable and > > + * suspend statue when first pkt send to channel, so there is no need > > + * to do any operation here, only unlock and leave. > > + */ > > + spin_unlock_irqrestore(&thread->chan->lock, flags); > > } > > > > static const struct mbox_chan_ops cmdq_mbox_chan_ops = { > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel