From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 202D5C10F25 for ; Mon, 9 Mar 2020 23:13:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E430224655 for ; Mon, 9 Mar 2020 23:13:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DpsrcTUL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="sYQ33oHq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E430224655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t0f34/LnwYxJIjcRCmhmyFqZkEOMUciBPjpYYFjqKNo=; b=DpsrcTULgirozK tHBDDNgoyAdtdMQZ6H6uUzHPafSqBE/NghK/4fT5gY9jfkXp7h3RfT/XCHrgYW/G8BgfHp16nZYiV gun43hX45zW7gZy3lOdE3z3PETFdGBSbxcuXRfor4bO+eygUMDKsoUnM20F+/oibulvZcuzsDJ6P5 sHvI8uorTNKUZow2K/ojWWxDzVJk5tZQZx8q0VufYdzArj6nBQcdDBkOrdbYAvbqpln0FlTBVM5mu U1iP9Y2ouHDeIiDIal9ZyfVR4A4oknLvDFiMjwvGWiz+CclRVOcp7GnT0M3k8C4n5Ckrd82aQva/D BXPSUF9tX44xjgrpB8hA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBRaX-00009J-L3; Mon, 09 Mar 2020 23:13:33 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBRaU-00008L-D7; Mon, 09 Mar 2020 23:13:32 +0000 X-UUID: ca71ff1e4cd24a8b8cd3461cdad889db-20200309 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=yigWAdDzv9r+S5GMZO74ScT7GTvj1to3DrOUWOXQiqM=; b=sYQ33oHqL+8sQNFJNm2aT0ivB/fro+xlCj3aob444ty2uDKTB1hjrSqCrKzdD7xgPeLPVc2KOvDKOlGCNykEqDmBJgfDrIe0bcabLfi3pIUb4P58G83i63muK07LB+k/6CQdH5o6BsCtJEyLdtG2kUPLCqBWSBI5fFtKr+43+rA=; X-UUID: ca71ff1e4cd24a8b8cd3461cdad889db-20200309 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 248871745; Mon, 09 Mar 2020 15:13:22 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 9 Mar 2020 16:13:49 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 10 Mar 2020 07:12:07 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 10 Mar 2020 07:10:36 +0800 Message-ID: <1583795599.23665.4.camel@mtkswgap22> Subject: Re: [PATCH v3 1/4] mmc: core: expose MMC_CAP2_CQE* to dt From: Chun-Hung Wu To: Ulf Hansson Date: Tue, 10 Mar 2020 07:13:19 +0800 In-Reply-To: References: <1581922564-24914-1-git-send-email-chun-hung.wu@mediatek.com> <1581922564-24914-2-git-send-email-chun-hung.wu@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200309_161330_454566_37076C0F X-CRM114-Status: GOOD ( 19.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kate Stewart , wsd_upstream@mediatek.com, "linux-mmc@vger.kernel.org" , Linus Walleij , Pavel Machek , Chaotian Jing , Android Kernel Team , Pan Bian , DTML , Martin Blumenstingl , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Thomas Gleixner , Stanley Chu , Allison Randal , Linux ARM , Mathieu Malaterre , Greg Kroah-Hartman , Kuohong Wang , Linux Kernel Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2020-03-04 at 14:04 +0100, Ulf Hansson wrote: > On Mon, 17 Feb 2020 at 07:56, Chun-Hung Wu wrote: > > > > Expose MMC_CAP2_CQE and MMC_CAP2_CQE_DCMD > > to host->caps2 if > > 1. "supports-cqe" is defined in dt and > > 2. "disable-cqe-dcmd" is not defined in dt. > > Both of these DT properties are defined as common mmc DT properties, > so the above isn't really correct. Please clarify this. Yes, the properties is common. But I think the "supports-cqe" or "disable-cqe-dcmd" is defined in vendor's mmc dt, not common mmc dt? Don't know what's wrong with the above description, any suggestion? > > Moreover, I suggest to update commit message header into "mmc: core: > Extend mmc_of_parse() to parse CQE bindings", as I think it better > describes the change. Thanks, I think the commit message you provide is better, will change it in v4. > > > > > Signed-off-by: Chun-Hung Wu > > --- > > drivers/mmc/core/host.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > > index 105b7a7..efb0dbe 100644 > > --- a/drivers/mmc/core/host.c > > +++ b/drivers/mmc/core/host.c > > @@ -319,6 +319,14 @@ int mmc_of_parse(struct mmc_host *host) > > host->caps2 |= MMC_CAP2_NO_SD; > > if (device_property_read_bool(dev, "no-mmc")) > > host->caps2 |= MMC_CAP2_NO_MMC; > > + if (device_property_read_bool(dev, "supports-cqe")) > > + host->caps2 |= MMC_CAP2_CQE; > > + > > + /* Must be after "supports-cqe" check */ > > + if (!device_property_read_bool(dev, "disable-cqe-dcmd")) { > > + if (host->caps2 & MMC_CAP2_CQE) > > Does it really doesn't matter if we set this cap, even if MMC_CAP2_CQE > isn't set? You can probably skip the check above. Will remove MMC_CAP2_CQE check here. > > > + host->caps2 |= MMC_CAP2_CQE_DCMD; > > + } > > > > /* Must be after "non-removable" check */ > > if (device_property_read_u32(dev, "fixed-emmc-driver-type", &drv_type) == 0) { > > -- > > 1.9.1 > > Kind regards > Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel