From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A757C4332E for ; Mon, 23 Mar 2020 01:12:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44BEF206F8 for ; Mon, 23 Mar 2020 01:12:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hGuUElpU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="fCIOZ+bW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44BEF206F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mxtdaTRrQ2KusrJunz8lnzO5SPc+Ul2PvI9EumzKtuQ=; b=hGuUElpUrP/+Pr BNH/rHw3oQO5FnpVrfDdU815nRRdQEnSUIuX5ja74plQLLIZcMJwW0xqT9WPEu+10po5w7+qmpsg+ UgZm/3qA2iiuYGMTR450LlI6n7pYdmkUT7laHa/45dKnM4Xzc7ot3zEjBj3omTofYeMLNl0PfHw0e qThVWrTTTKwx6Pm6vH389PsOQUyzTmE6o+ocq2Yb8DRTk1FUD7OKCPE1J68tLQfgVZzy2+qggxDqn Hua6NE4QQXSOKhHVpRr924gwecH4UlwsNYOtIS8k/U2fWop1RfsoKAYefBakUZJF9cjhF+9kZJ6u4 4IBWxsHvtWDz4YQZC/bQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGBdZ-0002ou-H0; Mon, 23 Mar 2020 01:12:17 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGBdT-0002mt-BO; Mon, 23 Mar 2020 01:12:14 +0000 X-UUID: e84cfff42ba54b33b7932408f16c0e21-20200322 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Ej7b2xhDVPxexbXWATZXTqKZRMpmRwD04pT0SWLn2fk=; b=fCIOZ+bWNom8QOBcauvYjY7vyph+pCXA1q4bc1Wd1qWLAI/bcnraokHPUBldFY3u+D6NQCQ03BpaRBQiPrVEKxahMNEXn5IkfZ/PTze118rifakZLoiCRwrbNui7FP+7D70UYRuEDzKEJguwIvNTLDrhy2/2kTB8PT035c/RRz4=; X-UUID: e84cfff42ba54b33b7932408f16c0e21-20200322 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 476863208; Sun, 22 Mar 2020 17:12:04 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 22 Mar 2020 18:12:35 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 23 Mar 2020 09:11:00 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 23 Mar 2020 09:09:43 +0800 Message-ID: <1584925915.16928.1.camel@mtkswgap22> Subject: Re: [PATCH v5 02/13] mailbox: cmdq: variablize address shift in platform From: Dennis-YC Hsieh To: Jassi Brar Date: Mon, 23 Mar 2020 09:11:55 +0800 In-Reply-To: References: <1583664775-19382-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1583664775-19382-3-git-send-email-dennis-yc.hsieh@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200322_181211_400201_CEE2B511 X-CRM114-Status: GOOD ( 12.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Devicetree List , Philipp Zabel , wsd_upstream@mediatek.com, David Airlie , Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, HS Liao , CK Hu , Rob Herring , linux-mediatek@lists.infradead.org, Houlong Wei , Daniel Vetter , Matthias Brugger , Bibby Hsieh , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jassi, On Thu, 2020-03-19 at 20:05 -0500, Jassi Brar wrote: > On Sun, Mar 8, 2020 at 5:53 AM Dennis YC Hsieh > wrote: > > > > Some gce hardware shift pc and end address in register to support > > large dram addressing. > > Implement gce address shift when write or read pc and end register. > > And add shift bit in platform definition. > > > > Signed-off-by: Dennis YC Hsieh > > Reviewed-by: CK Hu > > --- > > drivers/mailbox/mtk-cmdq-mailbox.c | 61 ++++++++++++++++++------ > > drivers/soc/mediatek/mtk-cmdq-helper.c | 3 +- > > include/linux/mailbox/mtk-cmdq-mailbox.h | 2 + > > > Please segregate this patch, and any other if, into mailbox and > platform specific patchsets. Ideally soc/client specific changes later > on top of mailbox/provider changes. > > Thanks Thanks for your comment. I'll separate mailbox and soc code. Regards, Dennis _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel