* [PATCH] arm64: dts: hikey960: pinctrl: Fix spi2/spi3 pinconf
@ 2020-03-24 10:07 Loic Poulain
2020-05-15 7:05 ` Wei Xu
0 siblings, 1 reply; 2+ messages in thread
From: Loic Poulain @ 2020-03-24 10:07 UTC (permalink / raw)
To: xuwei5, robh+dt; +Cc: Loic Poulain, linux-arm-kernel
Only the pinmux was selected, not the pinconf, leading to spi issues.
Increase drive strength so that max speed (25Mhz) can be achieved.
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
---
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 4 ++--
arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
index 253cc34..c39b7898 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
@@ -974,7 +974,7 @@
clocks = <&crg_ctrl HI3660_CLK_GATE_SPI2>;
clock-names = "apb_pclk";
pinctrl-names = "default";
- pinctrl-0 = <&spi2_pmx_func>;
+ pinctrl-0 = <&spi2_pmx_func &spi2_cfg_func>;
num-cs = <1>;
cs-gpios = <&gpio27 2 0>;
status = "disabled";
@@ -989,7 +989,7 @@
clocks = <&crg_ctrl HI3660_CLK_GATE_SPI3>;
clock-names = "apb_pclk";
pinctrl-names = "default";
- pinctrl-0 = <&spi3_pmx_func>;
+ pinctrl-0 = <&spi3_pmx_func &spi3_cfg_func>;
num-cs = <1>;
cs-gpios = <&gpio18 5 0>;
status = "disabled";
diff --git a/arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi b/arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi
index d11efc8..920a311 100644
--- a/arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi
@@ -717,7 +717,7 @@
spi3_cfg_func: spi3_cfg_func {
pinctrl-single,pins = <
0x008 0x0 /* SPI3_CLK */
- 0x0 /* SPI3_DI */
+ 0x00c 0x0 /* SPI3_DI */
0x010 0x0 /* SPI3_DO */
0x014 0x0 /* SPI3_CS0_N */
>;
@@ -734,7 +734,7 @@
PULL_UP
>;
pinctrl-single,drive-strength = <
- DRIVE7_02MA DRIVE6_MASK
+ DRIVE7_06MA DRIVE6_MASK
>;
};
};
@@ -1031,7 +1031,7 @@
PULL_UP
>;
pinctrl-single,drive-strength = <
- DRIVE7_02MA DRIVE6_MASK
+ DRIVE7_06MA DRIVE6_MASK
>;
};
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arm64: dts: hikey960: pinctrl: Fix spi2/spi3 pinconf
2020-03-24 10:07 [PATCH] arm64: dts: hikey960: pinctrl: Fix spi2/spi3 pinconf Loic Poulain
@ 2020-05-15 7:05 ` Wei Xu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Xu @ 2020-05-15 7:05 UTC (permalink / raw)
To: Loic Poulain, robh+dt; +Cc: linux-arm-kernel
Hi Loic,
On 2020/3/24 18:07, Loic Poulain wrote:
> Only the pinmux was selected, not the pinconf, leading to spi issues.
> Increase drive strength so that max speed (25Mhz) can be achieved.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Thanks!
Applied to the hisilicon arm64 dt tree.
Best Regards,
Wei
> ---
> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 4 ++--
> arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index 253cc34..c39b7898 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -974,7 +974,7 @@
> clocks = <&crg_ctrl HI3660_CLK_GATE_SPI2>;
> clock-names = "apb_pclk";
> pinctrl-names = "default";
> - pinctrl-0 = <&spi2_pmx_func>;
> + pinctrl-0 = <&spi2_pmx_func &spi2_cfg_func>;
> num-cs = <1>;
> cs-gpios = <&gpio27 2 0>;
> status = "disabled";
> @@ -989,7 +989,7 @@
> clocks = <&crg_ctrl HI3660_CLK_GATE_SPI3>;
> clock-names = "apb_pclk";
> pinctrl-names = "default";
> - pinctrl-0 = <&spi3_pmx_func>;
> + pinctrl-0 = <&spi3_pmx_func &spi3_cfg_func>;
> num-cs = <1>;
> cs-gpios = <&gpio18 5 0>;
> status = "disabled";
> diff --git a/arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi b/arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi
> index d11efc8..920a311 100644
> --- a/arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi
> @@ -717,7 +717,7 @@
> spi3_cfg_func: spi3_cfg_func {
> pinctrl-single,pins = <
> 0x008 0x0 /* SPI3_CLK */
> - 0x0 /* SPI3_DI */
> + 0x00c 0x0 /* SPI3_DI */
> 0x010 0x0 /* SPI3_DO */
> 0x014 0x0 /* SPI3_CS0_N */
> >;
> @@ -734,7 +734,7 @@
> PULL_UP
> >;
> pinctrl-single,drive-strength = <
> - DRIVE7_02MA DRIVE6_MASK
> + DRIVE7_06MA DRIVE6_MASK
> >;
> };
> };
> @@ -1031,7 +1031,7 @@
> PULL_UP
> >;
> pinctrl-single,drive-strength = <
> - DRIVE7_02MA DRIVE6_MASK
> + DRIVE7_06MA DRIVE6_MASK
> >;
> };
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-15 7:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-24 10:07 [PATCH] arm64: dts: hikey960: pinctrl: Fix spi2/spi3 pinconf Loic Poulain
2020-05-15 7:05 ` Wei Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).