From: Henry Chen <henryc.chen@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Nicolas Boichat <drinkcat@google.com>,
Mike Turquette <mturquette@linaro.org>,
srv_heupstream@mediatek.com,
James Liao <jamesjj.liao@mediatek.com>,
Viresh Kumar <vireshk@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Boyd <swboyd@chromium.org>,
Fan Chen <fan.chen@mediatek.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Ryan Case <ryandcase@chromium.org>,
Arvin Wang <arvin.wang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org,
Georgi Djakov <georgi.djakov@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V4 11/13] dt-bindings: regulator: add DVFSRC regulator dt-bindings
Date: Mon, 30 Mar 2020 13:19:13 +0800 [thread overview]
Message-ID: <1585545553.32635.10.camel@mtksdaap41> (raw)
In-Reply-To: <20200324203833.GL7039@sirena.org.uk>
Hi Mark,
On Tue, 2020-03-24 at 20:38 +0000, Mark Brown wrote:
> On Fri, Mar 13, 2020 at 05:34:24PM +0800, Henry Chen wrote:
>
> > +- regulator : The DVFSRC regulator is modelled as a subdevice of the DVFSRC.
> > + Because DVFSRC can request power directly via register read/write, likes
> > + vcore which is a core power of mt8183. As such, the DVFSRC regulator
> > + requires that DVFSRC nodes be present. shall contain only one of the
> > + following: "mediatek,mt8183-dvfsrc-regulator"
>
> Why do we even need a compatible here - it's not adding any new
> information to the parent mt8183 node, the compatible is mainly for the
> way Linux divides things up rather than a description of the hardware.
> We could just say that the regulator node always has a particular name
> instead.
Sorry, not quite sure what you mean, because I think DVFSRC is a
regulator provider that can provide vcore voltage control on mt8183, and
it can provide more power control in the next generation Mediatek SOC.
Here I add a sub-node to describe it. Or should I move this node to
regulator folder?
>
> It's also not quite true that it contains "only" the compatible - it
> also allows the regulator constraints to be defined.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-30 5:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 9:34 [PATCH V4 00/13] Add driver for dvfsrc, support for active state of scpsys Henry Chen
2020-03-13 9:34 ` [PATCH V4 01/13] dt-bindings: soc: Add dvfsrc driver bindings Henry Chen
2020-03-13 9:34 ` [PATCH V4 02/13] dt-bindings: soc: Add opp table on scpsys bindings Henry Chen
2020-03-13 9:34 ` [PATCH V4 03/13] soc: mediatek: add support for the performance state Henry Chen
2020-03-13 9:34 ` [PATCH V4 04/13] arm64: dts: mt8183: add performance state support of scpsys Henry Chen
2020-03-13 9:34 ` [PATCH V4 05/13] soc: mediatek: add header for mediatek SIP interface Henry Chen
2020-03-13 9:34 ` [PATCH V4 06/13] soc: mediatek: add MT8183 dvfsrc support Henry Chen
2020-04-01 14:41 ` Georgi Djakov
2020-04-02 2:48 ` Henry Chen
2020-03-13 9:34 ` [PATCH V4 07/13] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2020-03-13 9:34 ` [PATCH V4 08/13] dt-bindings: interconnect: add MT8183 interconnect dt-bindings Henry Chen
2020-03-20 23:09 ` Rob Herring
2020-03-13 9:34 ` [PATCH V4 09/13] interconnect: mediatek: Add mt8183 interconnect provider driver Henry Chen
2020-04-01 14:55 ` Georgi Djakov
2020-04-02 2:48 ` Henry Chen
2020-03-13 9:34 ` [PATCH V4 10/13] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2020-03-13 9:34 ` [PATCH V4 11/13] dt-bindings: regulator: add DVFSRC regulator dt-bindings Henry Chen
2020-03-24 20:38 ` Mark Brown
2020-03-30 5:19 ` Henry Chen [this message]
2020-03-13 9:34 ` [PATCH V4 12/13] regulator: Regulator driver for the Mediatek DVFSRC Henry Chen
2020-03-13 9:34 ` [PATCH V4 13/13] arm64: dts: mt8183: add dvfsrc regulator nodes Henry Chen
2020-04-01 15:09 ` [PATCH V4 00/13] Add driver for dvfsrc, support for active state of scpsys Georgi Djakov
2020-04-02 2:48 ` Henry Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1585545553.32635.10.camel@mtksdaap41 \
--to=henryc.chen@mediatek.com \
--cc=arvin.wang@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@google.com \
--cc=fan.chen@mediatek.com \
--cc=georgi.djakov@linaro.org \
--cc=jamesjj.liao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@linaro.org \
--cc=robh+dt@kernel.org \
--cc=ryandcase@chromium.org \
--cc=srv_heupstream@mediatek.com \
--cc=swboyd@chromium.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).