From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32A99C2BB55 for ; Thu, 9 Apr 2020 09:57:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04AB220730 for ; Thu, 9 Apr 2020 09:57:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pJHQp3Ni" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04AB220730 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivo.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=Zg45wVMGDdNBKTzLlO/prEJYBP6Vo+hi+Uy5kJpGFD4=; b=pJH Qp3Ni/4VvbOSVo7HP8SisSTN5TBVXZBUU2LnIxQf2LK//rutsTaz6xLXq0zlrUdjRwnmLwB3Q2lo9 Fu4+itCDFyTTntCgR3PvVT1PiPO2ExlQcZ9tgPO+gZ3ARWDmzpR6Y037T7s9UV1L/54abg3Oeyg/4 zaiVvlOmOBtZzhOAEcDa4v9sXRuMJwmQA1LO2bnasmPxKZCG5nM/eVYivB4qlr7RPHGgHAr1tzF5b xuiGu9sUdaAkyb30NK0UbKnsPfannSEQ8F1xoPYAHaPprBvKQYbiMFvnBvI/jO2TCEAGLyKOx+8Om B8HuQ44zdor5LpxGh1NoZ04zshmgbeQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMTe3-00075u-HS; Thu, 09 Apr 2020 09:38:47 +0000 Received: from m17617.mail.qiye.163.com ([59.111.176.17]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMTe0-00074w-MR for linux-arm-kernel@lists.infradead.org; Thu, 09 Apr 2020 09:38:46 +0000 Received: from wangqing-virtual-machine.localdomain (unknown [157.0.31.122]) by m17617.mail.qiye.163.com (Hmail) with ESMTPA id D770B26289F; Thu, 9 Apr 2020 17:38:36 +0800 (CST) From: Wang Qing To: Catalin Marinas , Will Deacon , Mark Rutland , James Morse , "Eric W. Biederman" , Thomas Gleixner , Wang Qing , jinho lim , Dave Martin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM64: fixed dump_backtrace() when task running on another cpu Date: Thu, 9 Apr 2020 17:38:16 +0800 Message-Id: <1586425106-7369-1-git-send-email-wangqing@vivo.com> X-Mailer: git-send-email 2.7.4 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZT1VJS05CQkJDTkpJSU1DSllXWShZQU hPN1dZLVlBSVdZCQ4XHghZQVk1NCk2OjckKS43PlkG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OTI6ASo4MTg#GhYIPh5JThoQ CBIaCVFVSlVKTkNNT0lOSkpMSkxJVTMWGhIXVQwaFRwKEhUcOw0SDRRVGBQWRVlXWRILWUFZSk5M VUtVSEpVSklJWVdZCAFZQUlITk03Bg++ X-HM-Tid: 0a715e4e399d9375kuwsd770b26289f X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200409_023844_914181_7431CBA3 X-CRM114-Status: UNSURE ( 8.25 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: opensource.kernel@vivo.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org We cannot get FP and PC when the task is running on another CPU, task->thread.cpu_context is the last time the task was switched out, it's better to give a reminder than to provide wrong information. Signed-off-by: Wang Qing --- arch/arm64/kernel/traps.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c index cf402be..c04e3e8 100644 --- a/arch/arm64/kernel/traps.c +++ b/arch/arm64/kernel/traps.c @@ -106,6 +106,14 @@ void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk) start_backtrace(&frame, (unsigned long)__builtin_frame_address(0), (unsigned long)dump_backtrace); + } else if (tsk->on_cpu) { + /* + * The task is running in another cpu, so the call stack + * is changing and we cannot get it. + */ + pr_warn("tsk: %s is running in CPU%d, Don't call trace!\n", + tsk->comm, tsk->cpu); + return; } else { /* * task blocked in __switch_to -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel