From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 134A8C2BA19 for ; Tue, 14 Apr 2020 11:41:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D768F2078B for ; Tue, 14 Apr 2020 11:41:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CC8a85D/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ocqZqq6s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D768F2078B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:MIME-Version:In-Reply-To: References:To:Subject:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=25T/TQNPiPVFZ/Vu1k7ABJyYNPIrGsZFAYebK0oWSQk=; b=CC8a85D/WwrYzG Yl5BacxPffkQsQTtCd/WiNhPeDgmG5f+L5cBmG/Jn9CM5YoJ+juSBhNjMF/tQv/eqWky21wMAGIdN L8kQqwOQl4VC8ur1ENsGsxzjhZW2WlhKDx30nLS9C1UEINo7dWmsCm+e7R2Sb7LfHT6gUhwLTMkzB wRV2n0gId7Z3t5qoglFnuxREm3hSWnEK0rf/xVr0NtPU755zFcIzbOrwPEsNC7Ul2PrnbDFrfwjP5 zJU5iSR3tADiSdPlUMRVIWV6UpmPvlsr+LHHAX81kArNr1yJGymwS/XYKVAHVWPl+AnPK7rKDC7jY T4vm7G1uEKqytl8McwjQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOJwg-0000Xz-U9; Tue, 14 Apr 2020 11:41:38 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOJwe-0000XL-F7 for linux-arm-kernel@lists.infradead.org; Tue, 14 Apr 2020 11:41:37 +0000 Received: by mail-pl1-x643.google.com with SMTP id a23so4561402plm.1 for ; Tue, 14 Apr 2020 04:41:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=8Esq4uJjc7hCqZPSyfuH3UXfV8N/MZeW3NHhinZ8EQA=; b=ocqZqq6sP10NyE5Oqrsyu24BO4bUv9d+CybYLvjUEA0qRTbQq8IAo2pJTWQfIqu4RO sPTYsA+WN55nEjfpiAKwJ3efgvE0y02zIRGr4QJLeGvUEOTkWEwmF8lPwgWo+rxrPEs5 VDTf42M1YbD+ARAsRZhdeD47bvnZpwfdPk63IxzHlEP4FOS+xZOTFLokGOmvq6qCsYSC 9tfWtMbUwXgESksl6KkJnUtYDYhwxUwpcnrbpFt8xAH3B/hJvFo4WpPegEXCjs4dhUzZ W26SU5gqovyT9qgqJ6qWu6cT8BV0oBUpmf+pSVOyif6EAbW821Qd95yr49cfUdak8sxQ mhEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=8Esq4uJjc7hCqZPSyfuH3UXfV8N/MZeW3NHhinZ8EQA=; b=JKkxVC8HxpYnQg1QZTxfXBoB2bZqi3qqwod7jae0qQi1LrnMvwadii4JAooBEU4vAC vBQOK0c9ZVhiB6E+VpoOtjZZ7Pg19Uq7aM1uUefg24LKEx/kK+4FdYoBdOQBY+UBDt8E vhYuHqLIOVvNkx1aIGFkAj08yIOHCp8j9KnQGU6SGmZWsK3eHeIsb5CkH9zY92cheh3i /bsTo6RZykz5peYrE6ZVF8yY/6tdZ7Ko1dIHGa1nOAaMAEKx6Zwm0mnSBhlqH0fV5LYt WHP+BgG36TadwQSDmLyxpDBXHkFOtvcKggmAPU8xEOAezjOgZ2Iay2pfnqzO4JJN6VLm G3Qg== X-Gm-Message-State: AGi0PuY6MUlwoENllWERNJFoGJ8DFkD5sFoTpsk1LMDj+6Q8LtPZgYIY UqJYtJcyFyWKn8t8oYCgzT0= X-Google-Smtp-Source: APiQypLIBjtk6RQd/AotCq9xnqN6ML09PMuOg/nS9Dm4xLrHmr38av9P0xvvmudk1+K5veWBSwJi4w== X-Received: by 2002:a17:90a:2281:: with SMTP id s1mr27766299pjc.68.1586864495571; Tue, 14 Apr 2020 04:41:35 -0700 (PDT) Received: from localhost ([203.18.28.220]) by smtp.gmail.com with ESMTPSA id 132sm11155833pfc.183.2020.04.14.04.41.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 04:41:35 -0700 (PDT) Date: Tue, 14 Apr 2020 21:39:53 +1000 From: Nicholas Piggin Subject: Re: [PATCH v2 4/4] mm/vmalloc: Hugepage vmalloc mappings To: Matthew Wilcox References: <20200413125303.423864-1-npiggin@gmail.com> <20200413125303.423864-5-npiggin@gmail.com> <20200413134106.GN21484@bombadil.infradead.org> In-Reply-To: <20200413134106.GN21484@bombadil.infradead.org> MIME-Version: 1.0 Message-Id: <1586863931.xb4yeowkao.astroid@bobo.none> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200414_044136_506927_169C9B98 X-CRM114-Status: GOOD ( 12.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Will Deacon , Catalin Marinas , x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Excerpts from Matthew Wilcox's message of April 13, 2020 11:41 pm: > On Mon, Apr 13, 2020 at 10:53:03PM +1000, Nicholas Piggin wrote: >> +static int vmap_pages_range_noflush(unsigned long start, unsigned long end, >> + pgprot_t prot, struct page **pages, >> + unsigned int page_shift) >> +{ >> + if (page_shift == PAGE_SIZE) { > > ... I think you meant 'page_shift == PAGE_SHIFT' Thanks, good catch. I obviously didn't test the fallback path (the other path works for small pages, it just goes one at a time). > Overall I like this series, although it's a bit biased towards CPUs > which have page sizes which match PMD/PUD sizes. It doesn't offer the > possibility of using 64kB page sizes on ARM, for example. No, it's just an incremental step on existing huge vmap stuff in tree, so such a thing would be out of scope. > But it's a > step in the right direction. > I don't know about moving kernel maps away from a generic Linux page table format. I quite like moving to it and making it as generic as possible. On the other hand, I also would like to make some arch-specific allowances for certain special cases that may not fit within the standard page table format, but it might be a much more specific and limited interface than the general vmalloc stuff. Thanks, Nick _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel