From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1483AC433E0 for ; Fri, 22 Jan 2021 11:24:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A827622DBF for ; Fri, 22 Jan 2021 11:24:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A827622DBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0spRmCwMSRj/cA41KiJwrnaMb8UdOPK0iJYsUuGzPQQ=; b=nz28hMcxaMFeXdb33zi0j4n+B Kihrc00o+aa/bWeTVbsNmMVstad/teN63vH1m9k9MArHuSmHqOZCYaNpx3iifTj8fu7Tg+5o5Ohb6 rs9AlqjtALJ87XbbfXCW55S+AxMCLcMncOpTytFwF2xCNll5T8Q1HN4Xey8rbn8bNxN2fzTX7hxxA DrotqU36CV0i8QL+/XollFuRTej1+F5bXCd4kY1A7ANtXR9jRlLIMk0ZjFmfZl6khSt82Dn3x2Kt0 fnKq5xDEE4a4/v9KPnUT/b6V1djcH1XdDFICQiQk2hYrujy/SCdwg9ktjyyjQBvZzOvdgoG5V/MWy wrXfeC2xw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2uWv-0005TU-Bk; Fri, 22 Jan 2021 11:23:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2uWt-0005T1-Nm for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 11:23:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A04411509; Fri, 22 Jan 2021 03:23:02 -0800 (PST) Received: from [10.37.8.28] (unknown [10.37.8.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AE78F3F719; Fri, 22 Jan 2021 03:23:00 -0800 (PST) Subject: Re: [PATCH v5 6/6] kasan: Forbid kunit tests when async mode is enabled To: Andrey Konovalov References: <20210121163943.9889-1-vincenzo.frascino@arm.com> <20210121163943.9889-7-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: <1586f5ed-c70d-ceb1-88c4-803ea8674dc0@arm.com> Date: Fri, 22 Jan 2021 11:26:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210122_062303_834888_28D0A578 X-CRM114-Status: GOOD ( 13.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Branislav Rankov , Marco Elver , Catalin Marinas , Evgenii Stepanov , LKML , kasan-dev , Alexander Potapenko , Linux ARM , Andrey Ryabinin , Will Deacon , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/21/21 5:40 PM, Andrey Konovalov wrote: >> diff --git a/lib/test_kasan.c b/lib/test_kasan.c >> index 7285dcf9fcc1..1306f707b4fe 100644 >> --- a/lib/test_kasan.c >> +++ b/lib/test_kasan.c >> @@ -52,6 +52,11 @@ static int kasan_test_init(struct kunit *test) >> return -1; >> } >> >> + if (!hw_is_mode_sync()) { >> + kunit_err(test, "can't run KASAN tests in async mode"); >> + return -1; >> + } > I'd rather implement this check at the KASAN level, than in arm64 > code. Just the way kasan_stack_collection_enabled() is implemented. > > Feel free to drop this change and the previous patch, I'll implement > this myself later. > Fine by me, will drop 5 and 6 in v5. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel