From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6886BC8300A for ; Thu, 30 Apr 2020 08:41:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21EE92173E for ; Thu, 30 Apr 2020 08:41:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bI2AdmcY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="UqYKJj7S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21EE92173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0uxYotZ+G3p2Uji7lxhMsAtGTvqEUw9m2+YKUMW8nL4=; b=bI2AdmcYAmo01s Ft7hPMXEJAiR/EL+ZryDjQphqcPWfU1S8FW8cPFxVkqmGzZSQKfFXTWCTcegedCdMDqXcEP6PlFub ByJmC7hAG7We8SRzkDJR9C0VsnQn/Sj96ZcwUjvXQoG9uHTm+tW7vxRkJkRFGPIVD1a2eTAvEjPfn 2IAzrxq36VmMWR/AhE4z+MydQov7Rzfevxg5UAGAnr8PWXzsqjFJpST9dGj5VbN7JesZUH2j3446W /+K/n/ArycOUWut8+e1gdngXSBVtgg1nyrDrgkFcn8f4/F26ZEdQr9oIXu0kYu+FMk1GHIY3aFFo+ jkiMrOUcG1ApfHUcofIA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jU4lE-0002Cs-GN; Thu, 30 Apr 2020 08:41:36 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jU4lB-0002Bi-8X; Thu, 30 Apr 2020 08:41:34 +0000 X-UUID: 9be725c7c28e44188be80d8205102d36-20200430 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=BJN1G2vRhoJNm8shc3cGM0UiBE2w5KQJhfntwPFsV7Y=; b=UqYKJj7S0jitWVlmvMmXxXq6PkpznZPra5UVpDvoHLKE1L1Rj41f65pCwITOGBca9aVJqP2z5pR5/6tntGP49t0+yUZTABM3TIj7ffp8c89KFAR24gucIKveOyH+U5qUjWHUc8s4dJ/jNApBUOVnwZyfBLVQPgG5/4a/cQKVcBA=; X-UUID: 9be725c7c28e44188be80d8205102d36-20200430 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 250260998; Thu, 30 Apr 2020 00:41:16 -0800 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Apr 2020 01:35:25 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Apr 2020 16:35:25 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 30 Apr 2020 16:35:26 +0800 Message-ID: <1588235725.3197.3.camel@mtkswgap22> Subject: RE: [PATCH v2 2/5] scsi: ufs: add "index" in parameter list of ufshcd_query_flag() From: Stanley Chu To: Avri Altman Date: Thu, 30 Apr 2020 16:35:25 +0800 In-Reply-To: References: <20200429135610.23750-1-stanley.chu@mediatek.com> <20200429135610.23750-3-stanley.chu@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200430_014133_309842_FA80129C X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "bvanassche@acm.org" , "martin.petersen@oracle.com" , "andy.teng@mediatek.com" , "jejb@linux.ibm.com" , "chun-hung.wu@mediatek.com" , "kuohong.wang@mediatek.com" , "linux-kernel@vger.kernel.org" , "cang@codeaurora.org" , "linux-mediatek@lists.infradead.org" , "peter.wang@mediatek.com" , "alim.akhtar@samsung.com" , "linux-scsi@vger.kernel.org" , "matthias.bgg@gmail.com" , "beanhuo@micron.com" , "linux-arm-kernel@lists.infradead.org" , "asutoshd@codeaurora.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Avri, On Thu, 2020-04-30 at 07:56 +0000, Avri Altman wrote: > > > > For preparation of LU Dedicated buffer mode support on WriteBooster > > feature, "index" parameter shall be added and allowed to be specified > > by callers. > > > > Signed-off-by: Stanley Chu > > Reviewed-by: Bean Huo > > --- > > drivers/scsi/ufs/ufs-sysfs.c | 2 +- > > drivers/scsi/ufs/ufshcd.c | 28 +++++++++++++++------------- > > drivers/scsi/ufs/ufshcd.h | 2 +- > > 3 files changed, 17 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/scsi/ufs/ufs-sysfs.c b/drivers/scsi/ufs/ufs-sysfs.c > > index 93484408bc40..b86b6a40d7e6 100644 > > --- a/drivers/scsi/ufs/ufs-sysfs.c > > +++ b/drivers/scsi/ufs/ufs-sysfs.c > > @@ -631,7 +631,7 @@ static ssize_t _name##_show(struct device *dev, > > \ > > struct ufs_hba *hba = dev_get_drvdata(dev); \ > > pm_runtime_get_sync(hba->dev); \ > > ret = ufshcd_query_flag(hba, UPIU_QUERY_OPCODE_READ_FLAG, \ > > - QUERY_FLAG_IDN##_uname, &flag); \ > > + QUERY_FLAG_IDN##_uname, 0, &flag); \ > The sysfs entries for flags needs to get an _index argument now Sure, I will fix this in next version. Thanks, Stanley Chu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel