public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 10/15] net: ethernet: Add missing MFD_SYSCON dependency on HAS_IOMEM
Date: Thu, 03 Mar 2016 11:59:22 +0100	[thread overview]
Message-ID: <15882485.8qUKXzsQVL@wuerfel> (raw)
In-Reply-To: <1456992221-26712-11-git-send-email-k.kozlowski@samsung.com>

On Thursday 03 March 2016 17:03:36 Krzysztof Kozlowski wrote:
> The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet
> direct dependencies.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  drivers/net/ethernet/hisilicon/Kconfig      | 1 +
>  drivers/net/ethernet/stmicro/stmmac/Kconfig | 6 ++++++
>  drivers/net/ethernet/ti/Kconfig             | 1 +
>  3 files changed, 8 insertions(+)
> 
> diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig
> index 74beb1867230..6a9c91781bf9 100644
> --- a/drivers/net/ethernet/hisilicon/Kconfig
> +++ b/drivers/net/ethernet/hisilicon/Kconfig
> @@ -26,6 +26,7 @@ config HIX5HD2_GMAC
>  config HIP04_ETH
>  	tristate "HISILICON P04 Ethernet support"
>  	select MARVELL_PHY
> +	depends on HAS_IOMEM	# For MFD_SYSCON
>  	select MFD_SYSCON
>  	select HNS_MDIO
>  	---help---

Geert added a HAS_DMA dependency in linux-next, which takes
care of this, although it's still technically correct as well.

> diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> index cec147d1d34f..d6902bf6e90f 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
> +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> @@ -16,6 +16,7 @@ if STMMAC_ETH
>  config STMMAC_PLATFORM
>  	tristate "STMMAC Platform bus support"
>  	depends on STMMAC_ETH
> +	depends on HAS_IOMEM	# For MFD_SYSCON
>  	select MFD_SYSCON
>  	default y
>  	---help---

NET_VENDOR_STMICRO depends on HAS_IOMEM, so we are good here for the
entire directory.

> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index e7f0b7d95b65..ec56cebe929d 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -62,6 +62,7 @@ config TI_CPSW_ALE
>  config TI_CPSW
>  	tristate "TI CPSW Switch Support"
>  	depends on ARCH_DAVINCI || ARCH_OMAP2PLUS
> +	depends on HAS_IOMEM	# For MFD_SYSCON
>  	select TI_DAVINCI_CPDMA
>  	select TI_DAVINCI_MDIO
>  	select TI_CPSW_PHY_SEL
> 


This again is platform specific, so the chagnge is not needed.

	Arnd

  reply	other threads:[~2016-03-03 10:59 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03  8:03 [RFC 00/15] tree-wide: mfd: syscon: Fix unmet ioremap dependency Krzysztof Kozlowski
2016-03-03  8:03 ` [RFC 01/15] clocksource: atmel: Add missing MFD_SYSCON dependency on HAS_IOMEM Krzysztof Kozlowski
2016-03-03 10:52   ` Arnd Bergmann
2016-03-03  8:03 ` [RFC 02/15] dmaengine: nxp: " Krzysztof Kozlowski
2016-03-03 10:52   ` Arnd Bergmann
2016-03-03  8:03 ` [RFC 03/15] hwspinlock: qcom: " Krzysztof Kozlowski
2016-03-03 10:53   ` Arnd Bergmann
2016-03-03  8:03 ` [RFC 04/15] irqchip: st: " Krzysztof Kozlowski
2016-03-03 10:53   ` Arnd Bergmann
2016-03-03 12:00     ` [rtc-linux] " Krzysztof Kozlowski
2016-03-03 12:28       ` Arnd Bergmann
2016-03-03 12:33         ` Krzysztof Kozłowski
2016-03-03  8:03 ` [RFC 05/15] phy: hi6220: " Krzysztof Kozlowski
2016-03-03 10:54   ` Arnd Bergmann
2016-03-03  8:03 ` [RFC 06/15] pinctrl: rockchip: " Krzysztof Kozlowski
2016-03-03 12:44   ` [rtc-linux] " Krzysztof Kozlowski
2016-03-03  8:03 ` [RFC 07/15] pinctrl: mvebu: " Krzysztof Kozlowski
2016-03-03 12:43   ` [rtc-linux] " Krzysztof Kozlowski
2016-03-03  8:03 ` [RFC 08/15] rtc: at91sam9: " Krzysztof Kozlowski
2016-03-03 10:55   ` Arnd Bergmann
2016-03-03 12:27     ` Geert Uytterhoeven
2016-03-03 12:58       ` Arnd Bergmann
2016-03-03  8:03 ` [RFC 09/15] media: platform: " Krzysztof Kozlowski
2016-03-03 10:57   ` Arnd Bergmann
2016-03-03 12:28     ` Geert Uytterhoeven
2016-03-03 12:40     ` [rtc-linux] " Krzysztof Kozlowski
2016-03-03 13:05       ` Arnd Bergmann
2016-03-03  8:03 ` [RFC 10/15] net: ethernet: " Krzysztof Kozlowski
2016-03-03 10:59   ` Arnd Bergmann [this message]
2016-03-03  8:03 ` [RFC 11/15] power: reset: keystone: " Krzysztof Kozlowski
2016-03-03 11:00   ` Arnd Bergmann
2016-03-03 12:33     ` Sebastian Reichel
2016-03-03 12:35       ` [rtc-linux] " Krzysztof Kozlowski
2016-03-03  8:03 ` [RFC 12/15] soc: qcom: " Krzysztof Kozlowski
2016-03-03 12:43   ` [rtc-linux] " Krzysztof Kozlowski
2016-03-03  8:03 ` [RFC 13/15] staging: media: omap4iss: " Krzysztof Kozlowski
2016-03-03 12:42   ` [rtc-linux] " Krzysztof Kozlowski
2016-03-03  8:03 ` [RFC 14/15] usb: xhci: mtk: " Krzysztof Kozlowski
2016-03-03 11:01   ` Arnd Bergmann
2016-03-03  8:03 ` [RFC 15/15] mfd: syscon: Fix build of missing ioremap on UM Krzysztof Kozlowski
2016-03-03 10:50   ` Arnd Bergmann
2016-03-03 12:24     ` [rtc-linux] " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15882485.8qUKXzsQVL@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox